diff options
| author | Dan Crowell <dcrowell@us.ibm.com> | 2017-11-21 15:45:35 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-01-09 10:37:55 -0500 |
| commit | 7f8aa4b7a01721e52c0c0b4d4d54c6ba8738c11c (patch) | |
| tree | 9097fe9d68881e9ec568d83340468c5413a7f111 /src/include/usr/devicefw | |
| parent | 9ea9546db73d86d46871fcbb94cc93d3f2fb31a1 (diff) | |
| download | talos-hostboot-7f8aa4b7a01721e52c0c0b4d4d54c6ba8738c11c.tar.gz talos-hostboot-7f8aa4b7a01721e52c0c0b4d4d54c6ba8738c11c.zip | |
Tweaks to multicast scom workaround
Added a mode to avoid a pile of FFDC collection for the case
where we expect errors could happen.
Also added a couple new flags to control which chiplets get
accessed as part of the workaround, one to avoid access to
slave cores before they are running and the other to avoid
access to the memory chiplets before they have clocks enabled.
Without these changes, the code is still functionally correct
but the traces get filled with pointless non-errors which makes
real problems harder to find and also increases boot time.
Change-Id: I834781261d16748cbbfd8511d9649ec19de53d81
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/50503
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Reviewed-by: Prachi Gupta <pragupta@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include/usr/devicefw')
| -rw-r--r-- | src/include/usr/devicefw/driverif.H | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/src/include/usr/devicefw/driverif.H b/src/include/usr/devicefw/driverif.H index 550b90f09..df90800b3 100644 --- a/src/include/usr/devicefw/driverif.H +++ b/src/include/usr/devicefw/driverif.H @@ -93,7 +93,14 @@ namespace DeviceFW * @param[in] i_address - XSCom address to operate on. */ #define DEVICE_XSCOM_ADDRESS(i_address) \ - DeviceFW::XSCOM, static_cast<uint64_t>((i_address)) + DeviceFW::XSCOM, static_cast<uint64_t>((i_address)), 0ull + + /** Construct the device addressing parameters for XSCOM device ops + * when no error handling is required. + * @param[in] i_address - XSCom address to operate on. + */ + #define DEVICE_XSCOM_ADDRESS_NO_ERROR(i_address) \ + DeviceFW::XSCOM, static_cast<uint64_t>((i_address)), 1ull /** Construct the device addressing parameters for IBSCOM (inband scom) * device ops. |
