summaryrefslogtreecommitdiffstats
path: root/src/include/kernel
diff options
context:
space:
mode:
authorPatrick Williams <iawillia@us.ibm.com>2014-07-17 14:01:40 -0500
committerA. Patrick Williams III <iawillia@us.ibm.com>2014-07-17 16:03:02 -0500
commitcbcc22add05fb4a43faed34edd2b1ffa039dfc23 (patch)
tree74b26fb64fc221d58c66e94da3f090fa9e10e62d /src/include/kernel
parent89bd6adf7689cbddad15cd9a9e55d4b98b1df183 (diff)
downloadtalos-hostboot-cbcc22add05fb4a43faed34edd2b1ffa039dfc23.tar.gz
talos-hostboot-cbcc22add05fb4a43faed34edd2b1ffa039dfc23.zip
Restrict timebase sync to once per core.
As part of Id3a3bc0b7367e61f2725af17975fe3ba068f69a9, I fixed the deferred work queue to not leak work objects if there are multiple objects. When cores wake up, each thread inserts a work object to synchronize its timebase. Now that they are not leaking, we are running this 8 times, which is causing enough clock drift that we are getting passed the timeout for core wakeups. Modify deferred work queue to allow us to skip performing work if there is already an outstanding deferred work object. This will return us to running the timebase sync just once. Change-Id: Iccffeb9d0578dcd08d41d41ca6af1b82388e7e34 RTC: 111512 Backport: release-fips811 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/12281 Tested-by: Jenkins Server Reviewed-by: Brian Silver <bsilver@us.ibm.com> Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/include/kernel')
-rw-r--r--src/include/kernel/deferred.H10
1 files changed, 7 insertions, 3 deletions
diff --git a/src/include/kernel/deferred.H b/src/include/kernel/deferred.H
index f80a47bdb..5d22557c3 100644
--- a/src/include/kernel/deferred.H
+++ b/src/include/kernel/deferred.H
@@ -5,7 +5,9 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
-/* COPYRIGHT International Business Machines Corp. 2012,2014 */
+/* Contributors Listed Below - COPYRIGHT 2012,2014 */
+/* [+] International Business Machines Corp. */
+/* */
/* */
/* Licensed under the Apache License, Version 2.0 (the "License"); */
/* you may not use this file except in compliance with the License. */
@@ -149,11 +151,13 @@ class DeferredQueue
/** Insert a work item into the queue.
*
* @param i_work - The item to add.
+ * @param i_onlyIfEmpty - Only insert the object if the queue is
+ * already empty, otherwise delete.
*
* Ownership of the work item is transfered to the queue, which is
* responsible for delete once the work is complete.
*/
- static void insert(DeferredWork* i_work);
+ static void insert(DeferredWork* i_work, bool i_onlyIfEmpty = false);
/** Execute any pending work items. */
static void execute();
@@ -161,7 +165,7 @@ class DeferredQueue
friend class DeferredWork;
// Instance functions for static pair.
- void _insert(DeferredWork* i_work);
+ void _insert(DeferredWork* i_work, bool i_onlyIfEmpty);
void _execute();
/** Remove a completed work item from the queue.
OpenPOWER on IntegriCloud