path: root/src/import
diff options
authorStephen Glancy <>2019-11-12 15:57:48 -0500
committerDaniel M Crowell <>2019-11-14 10:22:47 -0600
commit78426ddee158cfed3e45f837900aba01f1dd109d (patch)
tree91c939f6e68f4c2b5e876cb4b06bcf1137992a6a /src/import
parent06b4ead53152d4363fe153d48a06bf5aef6d3ed0 (diff)
Disables broadcast mode in memdiags::continue_cmd
Broadcast mode at runtime can cause issues. memdiags::continue_cmd is called at runtime, so disabling the broadcast mode check will fix an NVDIMM runtime bug. Change-Id: Ib13ad0bf46c44aa26a6df39ffabc507348a1a14e CQ:SW480744 Reviewed-on: Reviewed-by: Mark Pizzutillo <> Tested-by: FSP CI Jenkins <> Tested-by: Jenkins Server <> Tested-by: Hostboot CI <> Reviewed-by: Louis Stermole <> Reviewed-by: Zane C Shelley <> Reviewed-by: Caleb N Palmer <> Reviewed-by: Jennifer A Stofer <> Reviewed-on: Reviewed-by: Jenkins Server <> Reviewed-by: Daniel M Crowell <> Tested-by: Daniel M Crowell <>
Diffstat (limited to 'src/import')
1 files changed, 6 insertions, 2 deletions
diff --git a/src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H b/src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H
index dfb6b495b..efd2e9bd9 100644
--- a/src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H
+++ b/src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H
@@ -1103,8 +1103,12 @@ fapi2::ReturnCode continue_cmd( const fapi2::Target<T>& i_target,
// Read-modify-write the fields in the program.
FAPI_TRY( mss::getScom(i_target, TT::MCBAGRAQ_REG, l_program.iv_addr_gen) );
- // Configure broadcast mode if needed
- FAPI_TRY(mss::mcbist::configure_broadcast_mode(i_target, l_program));
+ // Note: we are specifically not configuring broadcast mode here
+ // The continue command is called by PRD exclusively at mainline
+ // If we're at mainline, we can't run in broadcast mode
+ // If we ever need to call continue elsewhere, we'll need to do the following
+ // 1) add the function to configure broadcast mode
+ // 2) add in a switch to disable broadcast mode if we're at runtime
OpenPOWER on IntegriCloud