diff options
| author | Joe McGill <jmcgill@us.ibm.com> | 2018-07-20 14:42:45 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-07-31 15:30:32 -0500 |
| commit | 73f196ac8f86bbe898733721db58e143b0a42d6c (patch) | |
| tree | 51ae4b1a845dfc133929218342d47f80f98f57cb /src/import | |
| parent | 3fa58ab0e3034903f4f571b5e4c011ba4c1df4ca (diff) | |
| download | talos-hostboot-73f196ac8f86bbe898733721db58e143b0a42d6c.tar.gz talos-hostboot-73f196ac8f86bbe898733721db58e143b0a42d6c.zip | |
p9_xip_customize.C -- update filter PLL bucket select only for AW keyword ver2
IPL failures observed with filemode VPD containing the old AW keyword (ver1)
content with no keyword version byte -- add check to enforce attribute update
only when 2 is present in keyword version byte
Change-Id: I8bbb0b3656a98e1147ba38b2d666d24ff7478d8a
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/63058
Reviewed-by: Joseph E. Dery <dery@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: Joseph J. McGill <jmcgill@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/63077
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/customize/p9_xip_customize.C | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/src/import/chips/p9/procedures/hwp/customize/p9_xip_customize.C b/src/import/chips/p9/procedures/hwp/customize/p9_xip_customize.C index 0832f9a6c..b5307e11b 100644 --- a/src/import/chips/p9/procedures/hwp/customize/p9_xip_customize.C +++ b/src/import/chips/p9/procedures/hwp/customize/p9_xip_customize.C @@ -1976,6 +1976,7 @@ ReturnCode p9_xip_customize ( { fapi2::ATTR_MRW_FILTER_PLL_BUCKET_Type l_filterPllBucketMRW = 0; uint8_t l_filterPllBucket = 0; + uint8_t l_keywordVersion = 0; P9XipItem l_item; FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_MRW_FILTER_PLL_BUCKET, @@ -2022,8 +2023,14 @@ ReturnCode p9_xip_customize ( "getMvpdField(valid buffer) failed w/rc=0x%08x", (uint64_t)fapi2::current_err ); - // extract data - l_filterPllBucket = (uint8_t)(*(l_bufMvpdField + 1)); + // extract first byte (keyword version) + l_keywordVersion = (uint8_t)(*l_bufMvpdField); + + if (l_keywordVersion == 2) + { + // extract data + l_filterPllBucket = (uint8_t)(*(l_bufMvpdField + 1)); + } } FAPI_ASSERT( l_filterPllBucket <= MAX_FILTER_PLL_BUCKETS, |
