diff options
author | Mark Pizzutillo <Mark.Pizzutillo@ibm.com> | 2020-01-27 19:13:30 -0500 |
---|---|---|
committer | Christian R Geddes <crgeddes@us.ibm.com> | 2020-02-12 12:41:59 -0600 |
commit | 798af67f241d6a8479c952485099e7b60d4aa823 (patch) | |
tree | 00e462b989ecc1fd2995fa203f24e7c31856b5a1 /src/import/generic/memory/lib/spd/common | |
parent | 3dbe6a1963d4561ff5bca378caf9e107e7807bfc (diff) | |
download | talos-hostboot-798af67f241d6a8479c952485099e7b60d4aa823.tar.gz talos-hostboot-798af67f241d6a8479c952485099e7b60d4aa823.zip |
Add attribute for SPD_REVISION (byte 1)
Rename previous uses of Byte 192, the ddimm module spd section
to avoid ambiguity. Renamed from spd_revision --> ddimm_module_spd_revision
git-coreq:hostboot:I039173097619111ae5847660472e75ed9f2d5f1d
git-coreq:sbe:I039173097619111ae5847660472e75ed9f2d5f1d
git-coreq:hwsv:I039173097619111ae5847660472e75ed9f2d5f1d
Change-Id: I039173097619111ae5847660472e75ed9f2d5f1d
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/90410
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/90508
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
Diffstat (limited to 'src/import/generic/memory/lib/spd/common')
-rw-r--r-- | src/import/generic/memory/lib/spd/common/dimm_module_decoder.H | 17 |
1 files changed, 14 insertions, 3 deletions
diff --git a/src/import/generic/memory/lib/spd/common/dimm_module_decoder.H b/src/import/generic/memory/lib/spd/common/dimm_module_decoder.H index b1c47aa3f..7ccd72116 100644 --- a/src/import/generic/memory/lib/spd/common/dimm_module_decoder.H +++ b/src/import/generic/memory/lib/spd/common/dimm_module_decoder.H @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2016,2019 */ +/* Contributors Listed Below - COPYRIGHT 2016,2020 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -107,6 +107,17 @@ class dimm_module_decoder } /// + /// @brief Decodes SPD Revision -> SPD_REVISION + /// @param[out] o_output encoding from SPD + /// @return FAPI2_RC_SUCCESS if okay + /// + virtual fapi2::ReturnCode revision(uint8_t& o_output) const + { + o_output = 0; + return fapi2::FAPI2_RC_SUCCESS; + } + + /// /// @brief Decodes module nominal height max /// @param[out] o_output height range encoding from SPD /// @return FAPI2_RC_SUCCESS if okay @@ -559,11 +570,11 @@ class dimm_module_decoder // DDIMM information from here on out ////////////////////////////////////////// /// - /// @brief Decodes SPD Revision for bytes 192->447 -> SPD_REVISION + /// @brief Decodes SPD Revision for bytes 192->447 -> SPD_REV_DDIMM_MODULE /// @param[out] o_output encoding from SPD /// @return FAPI2_RC_SUCCESS if okay /// - virtual fapi2::ReturnCode ddimm_spd_revision(uint8_t& o_output) const + virtual fapi2::ReturnCode ddimm_module_spd_revision(uint8_t& o_output) const { o_output = 0; return fapi2::FAPI2_RC_SUCCESS; |