summaryrefslogtreecommitdiffstats
path: root/src/import/chips/p9a/procedures
diff options
context:
space:
mode:
authorAndre A. Marin <aamarin@us.ibm.com>2019-04-26 16:41:53 -0500
committerChristian R. Geddes <crgeddes@us.ibm.com>2019-04-30 11:55:05 -0500
commit3b13a6483b18a93d67b36c5a28d07415212a6995 (patch)
treeef114a2ef722e7a3b355b5b0738d49b560839614 /src/import/chips/p9a/procedures
parent114d10d29c181671b0ec51c1bef37652a2df9b83 (diff)
downloadtalos-hostboot-3b13a6483b18a93d67b36c5a28d07415212a6995.tar.gz
talos-hostboot-3b13a6483b18a93d67b36c5a28d07415212a6995.zip
Add call to setup derived attributes in p9a_mss_eff_config
Previously there was some work done to write the functions that do the calculations for these derived attributes but the code was not being called, and one of the functions had an incorrect parameter. This commit addresses both of those issues and also improves on a trace in eff_grouping that made debugging this issue tricky. Change-Id: I8394f1dcc29374afc765668fce79e55f9f823e7d RTC: 207850 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76616 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76661 Reviewed-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Tested-by: Christian R. Geddes <crgeddes@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9a/procedures')
-rw-r--r--src/import/chips/p9a/procedures/hwp/memory/p9a_mss_eff_config.C4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/import/chips/p9a/procedures/hwp/memory/p9a_mss_eff_config.C b/src/import/chips/p9a/procedures/hwp/memory/p9a_mss_eff_config.C
index 3bbf0ea9f..8a5529734 100644
--- a/src/import/chips/p9a/procedures/hwp/memory/p9a_mss_eff_config.C
+++ b/src/import/chips/p9a/procedures/hwp/memory/p9a_mss_eff_config.C
@@ -112,6 +112,10 @@ fapi2::ReturnCode p9a_mss_eff_config( const fapi2::Target<fapi2::TARGET_TYPE_MEM
FAPI_TRY( mss::attr_eff_engine<mss::exp::attr_eff_engine_fields>::set(l_spd_decoder) );
}
}
+
+ // Set up derived ATTRS
+ FAPI_TRY( mss::attr_derived_engine<mss::attr_engine_derived_fields>::set(dimm) );
+
}// dimm
fapi_try_exit:
OpenPOWER on IntegriCloud