diff options
| author | Joachim Fenkes <fenkes@de.ibm.com> | 2019-02-14 16:11:27 +0100 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-02-22 13:33:08 -0600 |
| commit | 5cf2cfc52a72e93fdd7f531e1f070969e8fc469a (patch) | |
| tree | 8ea2a3022177ce0440880bc886aa89a539f4ca87 /src/import/chips/p9/procedures/xml/attribute_info | |
| parent | 0fd6d39f64cdaf778f177df57e7e79f27d353e88 (diff) | |
| download | talos-hostboot-5cf2cfc52a72e93fdd7f531e1f070969e8fc469a.tar.gz talos-hostboot-5cf2cfc52a72e93fdd7f531e1f070969e8fc469a.zip | |
p9_sbe_npll_setup: Enable spread spectrum before starting PLL
There's a synchronizer missing on the sscgen input of the filter
PLLs, thus any changes to that input must be made before the PLL
is taken out of reset, or the spread generator inside the PLL might
start up in a skewed state, resulting in a broken spread profile.
Thus, change the procedure to enable spread before taking the PLL
out of reset, and also make sure we never try to synchronously
enable spread.
Change-Id: Ie0e545a6baf492d394a7d63d99ba5b83a0c46423
CQ: SW457204
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/71886
Reviewed-by: Joseph J. McGill <jmcgill@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Kevin F. Reick <reick@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/71913
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Tested-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/xml/attribute_info')
| -rw-r--r-- | src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml index 985115386..7e7a5ccf0 100644 --- a/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml +++ b/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml @@ -8567,8 +8567,9 @@ <chip> <name>ENUM_ATTR_NAME_AXONE</name> <ec> - <value>0x10</value> - <test>GREATER_THAN_OR_EQUAL</test> + <!-- essentially... never, since synchronous spread start is broken --> + <value>0xAF</value> + <test>EQUAL</test> </ec> </chip> </chipEcFeature> |
