diff options
| author | Greg Still <stillgs@us.ibm.com> | 2018-03-14 20:32:16 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-03-15 15:14:18 -0400 |
| commit | c3364dfd26504e19fe144362f813ae0c633b9f7e (patch) | |
| tree | 131e348ff950062fdb60ec413ae04ac4e6eb2c75 /src/import/chips/p9/procedures/hwp | |
| parent | cbcd27d3a6292e709ab4b22811364b1abc47441a (diff) | |
| download | talos-hostboot-c3364dfd26504e19fe144362f813ae0c633b9f7e.tar.gz talos-hostboot-c3364dfd26504e19fe144362f813ae0c633b9f7e.zip | |
PM: p9_setup_evid - deal with attribute clearing during MPIPL
Key_Cronus_Test=PM_REGRESS
Change-Id: I5a262518f2d4ecfb496f114e16f054a892285a9f
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/55898
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Tested-by: Cronus HW CI <cronushw-ci+hostboot@us.ibm.com>
Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA <prasadbgr@in.ibm.com>
Reviewed-by: Brian T. Vanderpool <vanderp@us.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/55899
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/pm/p9_setup_evid.C | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/src/import/chips/p9/procedures/hwp/pm/p9_setup_evid.C b/src/import/chips/p9/procedures/hwp/pm/p9_setup_evid.C index 15af9ab31..d52409657 100644 --- a/src/import/chips/p9/procedures/hwp/pm/p9_setup_evid.C +++ b/src/import/chips/p9/procedures/hwp/pm/p9_setup_evid.C @@ -513,19 +513,19 @@ p9_setup_evid_voltageWrite(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_ while (!l_goodResponse); // Compute the delta - l_delta_mv = l_present_voltage_mv - i_voltage_mv; + l_delta_mv = (int32_t)l_present_voltage_mv - (int32_t)i_voltage_mv; if (l_delta_mv > 0) { - FAPI_DBG("Decreasing voltage - delta = %d", l_delta_mv ); + FAPI_INF("Decreasing voltage - delta = %d", l_delta_mv ); } else if (l_delta_mv < 0) { - FAPI_DBG("Increasing voltage - delta = %d", l_delta_mv ); + FAPI_INF("Increasing voltage - delta = %d", l_delta_mv ); } else { - FAPI_DBG("Voltage to be set equals the initial voltage"); + FAPI_INF("Voltage to be set equals the initial voltage"); } // Break into steps limited by attr.attr_ext_vrm_step_size_mv @@ -534,7 +534,7 @@ p9_setup_evid_voltageWrite(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_ // Hostboot doesn't support abs() uint32_t l_abs_delta_mv = l_delta_mv < 0 ? -l_delta_mv : l_delta_mv; - if (l_abs_delta_mv > i_ext_vrm_step_size_mv) + if (i_ext_vrm_step_size_mv > 0 && l_abs_delta_mv > i_ext_vrm_step_size_mv ) { if (l_delta_mv > 0) // Decreasing { @@ -586,7 +586,8 @@ p9_setup_evid_voltageWrite(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_ while (!l_goodResponse); l_present_voltage_mv = l_target_mv; - l_delta_mv = l_present_voltage_mv - i_voltage_mv; + l_delta_mv = (int32_t)l_present_voltage_mv - (int32_t)i_voltage_mv; + FAPI_INF("New delta = %d", l_delta_mv ); } fapi_try_exit: |
