diff options
| author | crgeddes <crgeddes@us.ibm.com> | 2016-04-29 16:45:40 -0500 |
|---|---|---|
| committer | William G. Hoffa <wghoffa@us.ibm.com> | 2016-05-02 17:25:06 -0400 |
| commit | b26ecdfc7dce7f3f7f71c0e9acc2942012e3fe6d (patch) | |
| tree | 77e3bbbc707d1872dc7eee45012b32167f6ac3c6 /src/import/chips/p9/procedures/hwp/pm | |
| parent | 321e7344c6b85a0ad5e58e7a7a92848df900efd1 (diff) | |
| download | talos-hostboot-b26ecdfc7dce7f3f7f71c0e9acc2942012e3fe6d.tar.gz talos-hostboot-b26ecdfc7dce7f3f7f71c0e9acc2942012e3fe6d.zip | |
Update get_poundv_bucket so that it passes the pointer to #V data
I got a little carried away dereferencing pointers. I was mem_cpy'ing
to a pointer of a pointer. Also I am removing temp_defaults from this
commit because they collide real attributes attribute_gets
Change-Id: Ia3fecfa6550f21b07aedbe244de07ba3f117e6e7
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/23899
Tested-by: Jenkins Server
Tested-by: Hostboot CI
Reviewed-by: Matt K. Light <mklight@us.ibm.com>
Reviewed-by: Gregory S. Still <stillgs@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/23900
Tested-by: FSP CI Jenkins
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/pm')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/pm/p9_pm_get_poundv_bucket.C | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/import/chips/p9/procedures/hwp/pm/p9_pm_get_poundv_bucket.C b/src/import/chips/p9/procedures/hwp/pm/p9_pm_get_poundv_bucket.C index 91e4a81cb..515381599 100644 --- a/src/import/chips/p9/procedures/hwp/pm/p9_pm_get_poundv_bucket.C +++ b/src/import/chips/p9/procedures/hwp/pm/p9_pm_get_poundv_bucket.C @@ -32,7 +32,7 @@ fapi2::ReturnCode p9_pm_get_poundv_bucket( const fapi2::Target<fapi2::TARGET_TYPE_EQ>& i_target, fapi2::voltageBucketData_t& o_data) { - FAPI_INF("Entering p9_pm_get_poundv_bucket ...."); + FAPI_IMP("Entering p9_pm_get_poundv_bucket ...."); //Create a pointer version of the out param o_data so that @@ -204,10 +204,10 @@ fapi2::ReturnCode p9_pm_get_poundv_bucket_attr( //Allocate memory for vpd data l_fullVpdData = reinterpret_cast<uint8_t*>(malloc(l_vpdSize)); - FAPI_ASSERT(l_vpdSize - 4 - (l_bucketId * 0x33) >= sizeof(fapi2::ATTR_POUNDV_BUCKET_DATA_Type), + FAPI_ASSERT(l_vpdSize - 4 - ((l_bucketId - 1) * 0x33) >= sizeof(fapi2::ATTR_POUNDV_BUCKET_DATA_Type), fapi2::BAD_VPD_READ() .set_EXPECTED_SIZE(sizeof(fapi2::ATTR_POUNDV_BUCKET_DATA_Type)) - .set_ACTUAL_SIZE(l_vpdSize - 4 - (l_bucketId * 0x33)), + .set_ACTUAL_SIZE(l_vpdSize - 4 - ((l_bucketId - 1) * 0x33)), "#V data read was too small!" ); //Second read is to get data of vpd record @@ -236,8 +236,8 @@ fapi2::ReturnCode p9_pm_get_poundv_bucket_attr( //bucket f: 0x33 byte if( *l_fullVpdData == 0x2) { - memcpy(&o_data, - l_fullVpdData + 4 + (l_bucketId) * 0x33, + memcpy(o_data, + l_fullVpdData + 4 + (l_bucketId - 1) * 0x33, sizeof(fapi2::ATTR_POUNDV_BUCKET_DATA_Type)); } else |
