summaryrefslogtreecommitdiffstats
path: root/src/import/chips/p9/procedures/hwp/pm/p9_pstate_parameter_block.C
diff options
context:
space:
mode:
authorBrian Vanderpool <vanderp@us.ibm.com>2017-07-17 12:06:12 -0500
committerDaniel M. Crowell <dcrowell@us.ibm.com>2017-08-04 10:43:36 -0400
commit25d477f208be87dd23e89e0289695e81fa68a854 (patch)
tree213b740fd6b2522f210d16f0eb1730921bd006d4 /src/import/chips/p9/procedures/hwp/pm/p9_pstate_parameter_block.C
parent02970aadead4f3d0e4bf02b3efe803f391904946 (diff)
downloadtalos-hostboot-25d477f208be87dd23e89e0289695e81fa68a854.tar.gz
talos-hostboot-25d477f208be87dd23e89e0289695e81fa68a854.zip
Fix PoundW Invalid Freq Drop Value calculation
Change-Id: I79e3b0c8ac895b2a5c676f8a67c79bfa12d39512 CQ: SW396056 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43217 Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA <prasadbgr@in.ibm.com> Reviewed-by: CHRISTOPHER M. RIEDL <cmriedl@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43220 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/pm/p9_pstate_parameter_block.C')
-rw-r--r--src/import/chips/p9/procedures/hwp/pm/p9_pstate_parameter_block.C11
1 files changed, 9 insertions, 2 deletions
diff --git a/src/import/chips/p9/procedures/hwp/pm/p9_pstate_parameter_block.C b/src/import/chips/p9/procedures/hwp/pm/p9_pstate_parameter_block.C
index 7e0da1d14..ce21aa1c9 100644
--- a/src/import/chips/p9/procedures/hwp/pm/p9_pstate_parameter_block.C
+++ b/src/import/chips/p9/procedures/hwp/pm/p9_pstate_parameter_block.C
@@ -2962,8 +2962,15 @@ proc_get_mvpd_poundw(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>& i_target
for (uint8_t p = 0; p < NUM_OP_POINTS; ++p)
{
- VALIDATE_FREQUENCY_DROP_VALUES(((o_data->poundw[p].vdm_small_large_normal_freq >> 4) & 0x0F), // N_L
- ((o_data->poundw[p].vdm_small_large_normal_freq) & 0x0F), //N_S
+ // These fields are 4 bits wide, and stored in a uint8, hence the shifting
+ // N_S, N_L, L_S, S_N
+ FAPI_INF("o_data->poundw[%d] VDM_FREQ_DROP N_S = %d", p, ((o_data->poundw[p].vdm_small_large_normal_freq >> 4) & 0x0F));
+ FAPI_INF("o_data->poundw[%d] VDM_FREQ_DROP N_L = %d", p, ((o_data->poundw[p].vdm_small_large_normal_freq) & 0x0F));
+ FAPI_INF("o_data->poundw[%d] VDM_FREQ_DROP L_S = %d", p, ((o_data->poundw[p].vdm_large_small_normal_freq >> 4) & 0x0F));
+ FAPI_INF("o_data->poundw[%d] VDM_FREQ_DROP S_N = %d", p, ((o_data->poundw[p].vdm_large_small_normal_freq) & 0x0F));
+
+ VALIDATE_FREQUENCY_DROP_VALUES(((o_data->poundw[p].vdm_small_large_normal_freq) & 0x0F), //N_L
+ ((o_data->poundw[p].vdm_small_large_normal_freq >> 4) & 0x0F), // N_S
((o_data->poundw[p].vdm_large_small_normal_freq >> 4) & 0x0F), //L_S
((o_data->poundw[p].vdm_large_small_normal_freq) & 0x0F), //S_N
l_frequency_value_state);
OpenPOWER on IntegriCloud