diff options
| author | Matthew Hickman <Matthew.Hickman@ibm.com> | 2018-02-02 17:31:51 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-03-07 21:50:47 -0500 |
| commit | 1b11547e01a8e2be3bd08f52829686b787258d65 (patch) | |
| tree | 848180c816173eb3d86b0007ed893ec5b7f2a294 /src/import/chips/p9/procedures/hwp/memory | |
| parent | 3877eeac3ff31d06880de1bef669009d3a172938 (diff) | |
| download | talos-hostboot-1b11547e01a8e2be3bd08f52829686b787258d65.tar.gz talos-hostboot-1b11547e01a8e2be3bd08f52829686b787258d65.zip | |
Fixed Maint IUE unmasked with mnfg flags
Change-Id: I33eb20071e2b694bdaac9e1d625a08138ecfa360
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53319
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53497
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/memory')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/lib/fir/memdiags_fir.C | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/fir/memdiags_fir.C b/src/import/chips/p9/procedures/hwp/memory/lib/fir/memdiags_fir.C index 988811f0c..c15ea5220 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/fir/memdiags_fir.C +++ b/src/import/chips/p9/procedures/hwp/memory/lib/fir/memdiags_fir.C @@ -63,11 +63,12 @@ fapi2::ReturnCode after_memdiags( const fapi2::Target<TARGET_TYPE_MCBIST>& i_tar { fapi2::ReturnCode l_rc; fapi2::buffer<uint64_t> dsm0_buffer; + fapi2::buffer<uint64_t> l_mnfg_buffer; uint64_t rd_tag_delay = 0; uint64_t wr_done_delay = 0; - uint64_t mnfg_flag = 0; fapi2::buffer<uint64_t> l_aue_buffer; fapi2::ATTR_CHIP_EC_FEATURE_HW414700_Type l_checkstop_flag; + constexpr uint64_t MNFG_THRESHOLDS_ATTR = 63; // Broadcast mode workaround for UEs causing out of sync FAPI_TRY(mss::workarounds::mcbist::broadcast_out_of_sync(i_target, mss::ON)); @@ -104,9 +105,9 @@ fapi2::ReturnCode after_memdiags( const fapi2::Target<TARGET_TYPE_MCBIST>& i_tar } // If MNFG FLAG Threshhold is enabled skip IUE unflagging - FAPI_TRY (mss::mnfg_flags(mnfg_flag) ); + FAPI_TRY ( mss::mnfg_flags(l_mnfg_buffer) ); - if (mnfg_flag != fapi2::ENUM_ATTR_MNFG_FLAGS_MNFG_THRESHOLDS) + if ( !(l_mnfg_buffer.getBit<MNFG_THRESHOLDS_ATTR>()) ) { l_ecc64_fir_reg.recoverable_error<MCA_FIR_MAINTENANCE_IUE>(); } |
