diff options
author | Brian Silver <bsilver@us.ibm.com> | 2016-03-07 12:47:33 -0600 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2016-03-14 17:44:42 -0400 |
commit | 2c7af1f6cf8995bed10e9f2aacce431015bb4f96 (patch) | |
tree | a6c0102caa97242a904363da4489dddee1204933 /src/import/chips/p9/procedures/hwp/memory | |
parent | 4f05f4d60452be280c4b958e31d53c28a234efb2 (diff) | |
download | talos-hostboot-2c7af1f6cf8995bed10e9f2aacce431015bb4f96.tar.gz talos-hostboot-2c7af1f6cf8995bed10e9f2aacce431015bb4f96.zip |
Add p9_mss_dump_regs wrapper, remove from procedures
Change-Id: I2239ab9daff4d9d398539bd2a4f2a646393abe26
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/21768
Tested-by: Jenkins Server
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/21769
Tested-by: FSP CI Jenkins
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/memory')
-rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/p9_mss_draminit_mc.C | 7 | ||||
-rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/p9_mss_draminit_training.C | 2 |
2 files changed, 0 insertions, 9 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/p9_mss_draminit_mc.C b/src/import/chips/p9/procedures/hwp/memory/p9_mss_draminit_mc.C index 124722c55..fcf17386f 100644 --- a/src/import/chips/p9/procedures/hwp/memory/p9_mss_draminit_mc.C +++ b/src/import/chips/p9/procedures/hwp/memory/p9_mss_draminit_mc.C @@ -183,13 +183,6 @@ extern "C" // Kick it off, wait for a result FAPI_TRY( mss::mcbist::execute(i_target, l_program) ); - - // Just because the program executed and no MCBIST failure was reported, it is poosible that - // there were address errors. An address error in the only address in a range causes the - // 'BIST to skip that command. Since it's the only address, the subtest (or program) can - // complete succedssfully even though nothing actually happend. - // For now, just dump the registers and vgrep for errors. BRS - FAPI_TRY( mss::dump_regs<TARGET_TYPE_MCBIST>(i_target) ); } } diff --git a/src/import/chips/p9/procedures/hwp/memory/p9_mss_draminit_training.C b/src/import/chips/p9/procedures/hwp/memory/p9_mss_draminit_training.C index c2217182b..ec5914f17 100644 --- a/src/import/chips/p9/procedures/hwp/memory/p9_mss_draminit_training.C +++ b/src/import/chips/p9/procedures/hwp/memory/p9_mss_draminit_training.C @@ -149,8 +149,6 @@ extern "C" // • Section 5.2.6.2 WC Configuration 1 Register on page 436 // • Section 5.2.6.3 WC Configuration 2 Register on page 438 - FAPI_TRY( mss::dump_regs<TARGET_TYPE_MCA>(p) ); - // Get our rank pairs. FAPI_TRY( mss::get_rank_pairs(p, l_pairs) ); |