diff options
| author | Jacob Harvey <jlharvey@us.ibm.com> | 2017-03-22 09:25:04 -0500 |
|---|---|---|
| committer | William G. Hoffa <wghoffa@us.ibm.com> | 2017-03-24 10:22:28 -0400 |
| commit | 6cfd9c7e4dcb22c4d8ce1bf2feb99328ed185781 (patch) | |
| tree | 486d51a189516a575aaa7670a245301582d1735a /src/import/chips/p9/procedures/hwp/memory/p9_mss_bulk_pwr_throttles.C | |
| parent | b4b696de54dedb5e835a0f8abca5731b1f1bdeea (diff) | |
| download | talos-hostboot-6cfd9c7e4dcb22c4d8ce1bf2feb99328ed185781.tar.gz talos-hostboot-6cfd9c7e4dcb22c4d8ce1bf2feb99328ed185781.zip | |
Fix defect SW384182 for p9_mss_eff_config_thermal
Change-Id: I24fe5d5a03fff3313ac44a124d30fa090e8c0917
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38288
Reviewed-by: Matt K. Light <mklight@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Reviewed-by: Brian R. Silver <bsilver@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38298
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/memory/p9_mss_bulk_pwr_throttles.C')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/p9_mss_bulk_pwr_throttles.C | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/p9_mss_bulk_pwr_throttles.C b/src/import/chips/p9/procedures/hwp/memory/p9_mss_bulk_pwr_throttles.C index f918fd45a..47173cdb0 100644 --- a/src/import/chips/p9/procedures/hwp/memory/p9_mss_bulk_pwr_throttles.C +++ b/src/import/chips/p9/procedures/hwp/memory/p9_mss_bulk_pwr_throttles.C @@ -62,7 +62,7 @@ extern "C" { FAPI_INF("Start p9_mss_bulk_pwr_throttles for %s type throttling", (( i_throttle_type == THERMAL) ? "THERMAL" : "POWER")); - fapi2::ReturnCode l_rc; + for ( const auto& l_mcs : i_targets) { @@ -72,6 +72,8 @@ extern "C" for (const auto& l_mca : mss::find_targets<TARGET_TYPE_MCA>(l_mcs)) { + fapi2::ReturnCode l_rc = fapi2::FAPI2_RC_SUCCESS; + //Don't run if there are no dimms on the port if (mss::count_dimm(l_mca) == 0) { @@ -110,12 +112,12 @@ extern "C" //Set all of the throttles to the lowest value per port for performance reasons FAPI_TRY(mss::power_thermal::equalize_throttles(i_targets)); FAPI_INF("End bulk_pwr_throttles"); - return l_rc; + return fapi2::current_err; fapi_try_exit: FAPI_ERR("Error calculating bulk_pwr_throttles using %s throttling", ((i_throttle_type == POWER) ? "power" : "thermal")); - return l_rc; + return fapi2::current_err; } } //extern C |
