diff options
| author | Stephen Glancy <sglancy@us.ibm.com> | 2017-06-16 15:44:22 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-06-20 11:23:21 -0400 |
| commit | 32d63b3d13514409fc186933237238efb2d64660 (patch) | |
| tree | fa6e31264751a7cd64d2927c8dea4b27f66f9858 /src/import/chips/p9/procedures/hwp/memory/lib/phy | |
| parent | 2ba9ff874e2f66f6dc7b2c1b13f56b2806613093 (diff) | |
| download | talos-hostboot-32d63b3d13514409fc186933237238efb2d64660.tar.gz talos-hostboot-32d63b3d13514409fc186933237238efb2d64660.zip | |
Fixed DLL workarounds to always run
DLL workarounds will not be fixed in hardware,
in the foreseeable future. As such, always run the workarounds.
Change-Id: Iaa48b1b976908fdbb8af1eb8d518147fabc8cdce
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41998
Reviewed-by: LUCAS W. MULKEY <lwmulkey@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Matt K. Light <mklight@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/42008
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/memory/lib/phy')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/lib/phy/ddr_phy.C | 17 |
1 files changed, 2 insertions, 15 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/phy/ddr_phy.C b/src/import/chips/p9/procedures/hwp/memory/lib/phy/ddr_phy.C index 60feb017d..051d7e6e1 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/phy/ddr_phy.C +++ b/src/import/chips/p9/procedures/hwp/memory/lib/phy/ddr_phy.C @@ -1637,25 +1637,12 @@ fapi2::ReturnCode dll_calibration( const fapi2::Target<fapi2::TARGET_TYPE_MCBIST if( mss::pc::get_dll_cal_status(l_read) != mss::YES ) { - // For < DD2.0 parts we want to run DLL workaround so + // For all Nimbus parts parts we want to run DLL workaround so // Instead of using FAPI_ASSERT and logging FFDC we will // return a "bad" ReturnCode to trigger a workaround that // will be run after DLL Calibration for all failing DLLs. // FFDC will be collected there if it doesn't pass. - if( mss::chip_ec_feature_mss_dll_workaround(p) ) - { - FAPI_INF("%s DLL failed to calibrate", mss::c_str(p)); - return fapi2::FAPI2_RC_FALSE; - } - - // If we are here than we are not running DLL workaround - // because this part is not < DD2.0, so we want to fail out here - // and log FFDC - FAPI_ASSERT( false, - fapi2::MSS_DLL_FAILED_TO_CALIBRATE() - .set_MCA_IN_ERROR(p), - "%s DLL failed to calibrate", - mss::c_str(i_target) ); + return fapi2::FAPI2_RC_FALSE; }// endif |
