diff options
| author | Grover Monster <bsilver@us.ibm.com> | 2016-08-19 15:45:23 -0500 |
|---|---|---|
| committer | Christian R. Geddes <crgeddes@us.ibm.com> | 2016-09-02 15:07:25 -0400 |
| commit | abcddd674843ac76c72966014707369a2d73b8ec (patch) | |
| tree | cecec60b9b89cc072a9b8d9f0f85ba4c8795b7cf /src/import/chips/p9/procedures/hwp/memory/lib/eff_config | |
| parent | ad5994c1a9346903ef6bb5b0b69d700b39567b16 (diff) | |
| download | talos-hostboot-abcddd674843ac76c72966014707369a2d73b8ec.tar.gz talos-hostboot-abcddd674843ac76c72966014707369a2d73b8ec.zip | |
Change VPD for power on and VBU
Create directory for ZZ, vbu and templates
Add ZZ vpd, vbu vpd, dq map and cke map templates
Update hb_temp_defaults.xml with new attributes in MR
Update the accessor generator to handle non-array attrs
Update the vpd decoder generator to handle MCS attrs only
Add comment describing nibble/rank mapping for VPD
Add support for signed attributes
Change-Id: Ib37b21b72a9885e0a104d63e37005935a4c2d8b9
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/28961
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/28994
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/memory/lib/eff_config')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/lib/eff_config/eff_config.C | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/eff_config/eff_config.C b/src/import/chips/p9/procedures/hwp/memory/lib/eff_config/eff_config.C index 7aa8c264b..aeab68657 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/eff_config/eff_config.C +++ b/src/import/chips/p9/procedures/hwp/memory/lib/eff_config/eff_config.C @@ -2861,21 +2861,16 @@ fapi2::ReturnCode eff_config::geardown_mode(const fapi2::Target<TARGET_TYPE_DIMM // Attribute storage uint8_t l_2n_autoset = 0; uint8_t l_2n_mrw_mode = 0; - FAPI_TRY( mss::vpd_mr_mc_2n_mode_autoset(i_target, l_2n_autoset) ); + FAPI_TRY( mss::vpd_mr_mc_2n_mode_autoset(l_mcs, l_2n_autoset) ); FAPI_TRY( mss::mrw_dram_2n_mode(l_2n_mrw_mode) ); // Geardown maps directly to autoset = 0 gets 1/2 rate, 1 get 1/4 rate. FAPI_TRY( eff_geardown_mode(l_mcs, l_attrs_geardown_mode.data()) ); // If the MRW states 'auto' we use what's in VPD, otherwise we use what's in the MRW. - // (Errr ... does this make sense? The MRW is really just another form of VPD ...) - if (l_2n_mrw_mode != fapi2::ENUM_ATTR_MSS_MRW_DRAM_2N_MODE_AUTO) - { - // MRW values are 1 and 2 (to make room for 0 being the default.) So we subtract one. - l_2n_autoset = l_2n_mrw_mode - 1; - } - - l_attrs_geardown_mode[l_port_num] = l_2n_autoset; + // We remove 1 from the value as that matches the expectations in the MR perfectly. + l_attrs_geardown_mode[l_port_num] = (l_2n_mrw_mode != fapi2::ENUM_ATTR_MSS_MRW_DRAM_2N_MODE_AUTO) ? + l_2n_mrw_mode - 1 : l_2n_autoset - 1; FAPI_TRY( FAPI_ATTR_SET(fapi2::ATTR_EFF_GEARDOWN_MODE, l_mcs, |
