diff options
| author | Chris Steffen <cwsteffen@us.ibm.com> | 2017-07-27 15:59:49 -0500 |
|---|---|---|
| committer | Christian R. Geddes <crgeddes@us.ibm.com> | 2017-08-30 14:20:26 -0400 |
| commit | 98ca7f4c5d1657b65f507ecf2e3dcdab143c699a (patch) | |
| tree | 2d9101748668c7f2f5e0b4af32e8a964f4b5d1c8 /src/import/chips/p9/procedures/hwp/io | |
| parent | 0657c035694c6ba6c21c73bf3ab9fe0ae56541bd (diff) | |
| download | talos-hostboot-98ca7f4c5d1657b65f507ecf2e3dcdab143c699a.tar.gz talos-hostboot-98ca7f4c5d1657b65f507ecf2e3dcdab143c699a.zip | |
Making zcal errors visible
Change-Id: I66752b6d0e0795b124b77008952c748f256f44c2
Original-Change-Id: I6a4dff7d58441bb2783ecd206254c3ccf125c3b6
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43802
Reviewed-by: Gary A. Peterson <garyp@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Richard J. Knight <rjknight@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45337
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/io')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/io/p9_io_dmi_dccal.C | 33 |
1 files changed, 18 insertions, 15 deletions
diff --git a/src/import/chips/p9/procedures/hwp/io/p9_io_dmi_dccal.C b/src/import/chips/p9/procedures/hwp/io/p9_io_dmi_dccal.C index 68e36b3f8..5fdc4daf9 100644 --- a/src/import/chips/p9/procedures/hwp/io/p9_io_dmi_dccal.C +++ b/src/import/chips/p9/procedures/hwp/io/p9_io_dmi_dccal.C @@ -226,29 +226,29 @@ fapi2::ReturnCode tx_zcal_verify_results( if(io_pval > ZCAL_MAX) { io_pval = ZCAL_MAX; - FAPI_ERR("tx_zcal_verify_results: Tx Zcal Pval(0x%X) > Max Allowed(0x%X)", - io_pval, ZCAL_MAX); + FAPI_ERR("I/O EDI+ DMI Tx Zcal Pval(0x%X) > Max Allowed(0x%X); Code will override with 0x%X and continue.", + io_pval, ZCAL_MAX, ZCAL_MAX); } if(io_nval > ZCAL_MAX) { io_nval = ZCAL_MAX; - FAPI_ERR("tx_zcal_verify_results: Tx Zcal Nval(0x%X) > Max Allowed(0x%X)", - io_nval, ZCAL_MAX); + FAPI_ERR("I/O EDI+ DMI Tx Tx Zcal Nval(0x%X) > Max Allowed(0x%X); Code will override with 0x%X and continue.", + io_nval, ZCAL_MAX, ZCAL_MAX); } if(io_pval < ZCAL_MIN) { io_pval = ZCAL_MIN; - FAPI_ERR("tx_zcal_verify_results: Tx Zcal Pval(0x%X) < Min Allowed(0x%X)", - io_pval, ZCAL_MIN); + FAPI_ERR("I/O EDI+ DMI Tx Tx Zcal Pval(0x%X) < Min Allowed(0x%X); Code will override with 0x%X and continue.", + io_pval, ZCAL_MIN, ZCAL_MIN); } if(io_nval < ZCAL_MIN) { io_nval = ZCAL_MIN; - FAPI_ERR("tx_zcal_verify_results: Tx Zcal Nval(0x%X) < Min Allowed(0x%X)", - io_nval, ZCAL_MIN); + FAPI_ERR("I/O EDI+ DMI Tx Tx Zcal Nval(0x%X) < Min Allowed(0x%X); Code will override with 0x%X and continue.", + io_nval, ZCAL_MIN, ZCAL_MIN); } FAPI_IMP("tx_zcal_verify_results: I/O EDI+ Dmi Exiting"); @@ -323,18 +323,22 @@ fapi2::ReturnCode tx_zcal_run_bus_poll(const DMI_TGT i_tgt) FAPI_TRY(io::read(EDIP_TX_IMPCAL_PB, i_tgt, GRP3, LN0, l_data)); } - + // Check for Zcal Done if(io::get(EDIP_TX_ZCAL_DONE, l_data) == 1) { - FAPI_DBG("tx_zcal_run_sm: I/O EDI+ Dmi Tx Zcal Poll Completed(%d/%d).", l_count, TIMEOUT); + FAPI_DBG("I/O EDI+ Dmi Tx Zcal Poll Completed(%d/%d).", l_count, TIMEOUT); } - else if(io::get(EDIP_TX_ZCAL_ERROR, l_data) == 1) + + // Check for Zcal Error + if(io::get(EDIP_TX_ZCAL_ERROR, l_data) == 1) { - FAPI_ERR("tx_zcal_run_sm: WARNING: Tx Z Calibration Error"); + FAPI_ERR("I/O EDI+ DMI Tx Z Calibration Error"); } - else + + // Check for Zcal Timeout + if( l_count >= TIMEOUT) { - FAPI_ERR("tx_zcal_run_sm: WARNING: Tx Z Calibration Timeout: Loops(%d)", l_count); + FAPI_ERR("I/O EDI+ DMI Tx Z Calibration Timeout: Loops(%d)", l_count); } fapi_try_exit: @@ -842,4 +846,3 @@ fapi_try_exit: FAPI_IMP("rx_dccal_poll_grp: I/O EDI+ Dmi Exiting"); return fapi2::current_err; } - |
