diff options
| author | Andre A. Marin <aamarin@us.ibm.com> | 2019-03-20 09:01:13 -0500 |
|---|---|---|
| committer | Christian R. Geddes <crgeddes@us.ibm.com> | 2019-04-02 13:20:03 -0500 |
| commit | ee76c2ca5927122cc9bfc792de240f20b87abe82 (patch) | |
| tree | 5a2a256cc16f3b45ba1d3bf166b41b17692ab490 /src/import/chips/centaur | |
| parent | 8daf280f7d24a3f5b2c553bb39ceda4d0fd32736 (diff) | |
| download | talos-hostboot-ee76c2ca5927122cc9bfc792de240f20b87abe82.tar.gz talos-hostboot-ee76c2ca5927122cc9bfc792de240f20b87abe82.zip | |
Fix c_str and pos DIMM specialization
Change-Id: Id234f7f14bc4dd90de1f8ea70a4617c513ca1ffa
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/74846
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/74877
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Diffstat (limited to 'src/import/chips/centaur')
4 files changed, 18 insertions, 6 deletions
diff --git a/src/import/chips/centaur/procedures/hwp/memory/lib/utils/mem_size.C b/src/import/chips/centaur/procedures/hwp/memory/lib/utils/mem_size.C index 0a804bdf0..465e31779 100644 --- a/src/import/chips/centaur/procedures/hwp/memory/lib/utils/mem_size.C +++ b/src/import/chips/centaur/procedures/hwp/memory/lib/utils/mem_size.C @@ -26,11 +26,10 @@ #include <fapi2.H> #include <lib/shared/dimmConsts.H> +#include <p9c_mss_funcs.H> #include <generic/memory/lib/utils/memory_size.H> #include <generic/memory/lib/utils/find.H> - -namespace mss -{ +#include <generic/memory/lib/utils/c_str.H> /// /// @brief Check if a given DIMM is functional @@ -74,6 +73,8 @@ bool is_dimm_functional(const uint8_t i_valid_dimm_bitmap, return fapi2::buffer<uint8_t>(i_valid_dimm_bitmap).getBit(VALID_DIMM_POS[i_port][i_dimm]); } +namespace mss +{ /// /// @brief Return the total memory size behind an MBA diff --git a/src/import/chips/centaur/procedures/hwp/memory/mss_dynamic_vid_utils.C b/src/import/chips/centaur/procedures/hwp/memory/mss_dynamic_vid_utils.C index 38aed25e9..f8324bb84 100644 --- a/src/import/chips/centaur/procedures/hwp/memory/mss_dynamic_vid_utils.C +++ b/src/import/chips/centaur/procedures/hwp/memory/mss_dynamic_vid_utils.C @@ -33,8 +33,7 @@ #include <mss_dynamic_vid_utils.H> #include <generic/memory/lib/utils/find.H> - - +#include <generic/memory/lib/utils/c_str.H> /// /// @brief Checks centaur configurations and outputs DRAM device type diff --git a/src/import/chips/centaur/procedures/hwp/memory/p9c_mss_funcs.H b/src/import/chips/centaur/procedures/hwp/memory/p9c_mss_funcs.H index d53e72730..3472a6547 100755 --- a/src/import/chips/centaur/procedures/hwp/memory/p9c_mss_funcs.H +++ b/src/import/chips/centaur/procedures/hwp/memory/p9c_mss_funcs.H @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2016,2018 */ +/* Contributors Listed Below - COPYRIGHT 2016,2019 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -447,5 +447,16 @@ fapi2::ReturnCode cs_decode(const fapi2::Target<fapi2::TARGET_TYPE_MBA>& i_targe const uint8_t i_stack_type, fapi2::variable_buffer& o_csn_8); +/// +/// @brief Check if a given DIMM is functional +/// @param[in] i_valid_dimm_bitmap from ATTR_CEN_MSS_EFF_DIMM_FUNCTIONAL_VECTOR +/// @param[in] i_port port index [0:1] +/// @param[in] i_dimm dimm index [0:1] +/// @return true if dimm is functional, false otherwise +/// +bool is_dimm_functional(const uint8_t i_valid_dimm_bitmap, + const uint8_t i_port, + const uint8_t i_dimm); + #endif /* _MSS_FUNCS_H */ diff --git a/src/import/chips/centaur/procedures/hwp/memory/p9c_mss_rowRepairFuncs.C b/src/import/chips/centaur/procedures/hwp/memory/p9c_mss_rowRepairFuncs.C index 65b95f894..8362380a7 100644 --- a/src/import/chips/centaur/procedures/hwp/memory/p9c_mss_rowRepairFuncs.C +++ b/src/import/chips/centaur/procedures/hwp/memory/p9c_mss_rowRepairFuncs.C @@ -24,6 +24,7 @@ /* IBM_PROLOG_END_TAG */ #include <p9c_mss_rowRepairFuncs.H> #include <generic/memory/lib/utils/find.H> +#include <generic/memory/lib/utils/c_str.H> using namespace fapi2; |
