summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndres Lugo-Reyes <aalugore@us.ibm.com>2018-05-15 17:20:52 -0500
committerDaniel M. Crowell <dcrowell@us.ibm.com>2018-05-16 17:14:39 -0400
commit56ff2943a5df5c1f04e2ec0e0f0418f4b1d1ad7b (patch)
tree993995322093060d9b35ae341b109ffc19c3a335
parent2e51696943687dcbb5d1a41b2aa693c3fa085b53 (diff)
downloadtalos-hostboot-56ff2943a5df5c1f04e2ec0e0f0418f4b1d1ad7b.tar.gz
talos-hostboot-56ff2943a5df5c1f04e2ec0e0f0418f4b1d1ad7b.zip
Fix off-by-one error when counting WOF reset counts
Change-Id: I4f4707e6c532a7459fe50137af6353a9b9995ca2 CQ:SW429098 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58873 Reviewed-by: Martha Broyles <mbroyles@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christopher J. Cain <cjcain@us.ibm.com> Reviewed-by: Sheldon Bailey <baileysh@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
-rw-r--r--src/usr/htmgt/occError.C6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/usr/htmgt/occError.C b/src/usr/htmgt/occError.C
index 47b0eb395..37bd6595c 100644
--- a/src/usr/htmgt/occError.C
+++ b/src/usr/htmgt/occError.C
@@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
-/* Contributors Listed Below - COPYRIGHT 2014,2017 */
+/* Contributors Listed Below - COPYRIGHT 2014,2018 */
/* [+] International Business Machines Corp. */
/* */
/* */
@@ -133,7 +133,9 @@ namespace HTMGT
// Check if we need a WOF requested reset
if(iv_needsWofReset == true)
{
- if( iv_wofResetCount < WOF_RESET_COUNT_THRESHOLD )
+ // We compare against one less than the threshold because
+ // the WOF reset count doesnt get incremented until resetPrep
+ if( iv_wofResetCount < (WOF_RESET_COUNT_THRESHOLD-1) )
{
// Not at WOF reset threshold yet. Set sev to INFO
severity = ERRORLOG::ERRL_SEV_INFORMATIONAL;
OpenPOWER on IntegriCloud