diff options
| author | Mike Baiocchi <mbaiocch@us.ibm.com> | 2018-04-23 13:18:50 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-05-10 22:29:40 -0400 |
| commit | 8e601e32703bc4d7f28d47fb07ded59c3a810e11 (patch) | |
| tree | f0b11bdece00c3e83d870b1e5c6b91c55542bfda | |
| parent | 89bbfaf84a74f09c2865a87e7f13a020b12f01a0 (diff) | |
| download | talos-hostboot-8e601e32703bc4d7f28d47fb07ded59c3a810e11.tar.gz talos-hostboot-8e601e32703bc4d7f28d47fb07ded59c3a810e11.zip | |
Remove System Level TCE Attributes
For Fleetwood support the TCE attributes refering to memory regions
had to move from the system level to the node level. Now that the
Hostboot and FSP code no longer use these attributes at the system
level we can remove them and their usage.
Change-Id: I4f71b940787689d4ee9f3b3b6ad081dd4632c65b
RTC:190014
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57680
Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
| -rw-r--r-- | src/usr/targeting/common/xmltohb/target_types.xml | 3 | ||||
| -rw-r--r-- | src/usr/util/utiltcemgr.C | 20 |
2 files changed, 0 insertions, 23 deletions
diff --git a/src/usr/targeting/common/xmltohb/target_types.xml b/src/usr/targeting/common/xmltohb/target_types.xml index b7cc025ce..01a526eb7 100644 --- a/src/usr/targeting/common/xmltohb/target_types.xml +++ b/src/usr/targeting/common/xmltohb/target_types.xml @@ -957,9 +957,6 @@ <attribute><id>MAX_DMI_PER_PROC</id></attribute> <attribute><id>PIB_I2C_REFCLOCK</id></attribute> <attribute><id>USE_TCES_FOR_DMAS</id></attribute> - <attribute><id>TCE_START_TOKEN_FOR_PAYLOAD</id></attribute> - <attribute><id>START_MEM_ADDRESS_FOR_PAYLOAD_TCE_TOKEN</id></attribute> - <attribute><id>TCE_START_TOKEN_FOR_HDAT</id></attribute> <!--fsp requirement--> <attribute> <id>BOOT_FREQ_MHZ</id> diff --git a/src/usr/util/utiltcemgr.C b/src/usr/util/utiltcemgr.C index a0a2d58d5..072793970 100644 --- a/src/usr/util/utiltcemgr.C +++ b/src/usr/util/utiltcemgr.C @@ -164,19 +164,6 @@ errlHndl_t utilSetupPayloadTces(void) // opened for it pNodeTgt->setAttr<TARGETING::ATTR_START_MEM_ADDRESS_FOR_PAYLOAD_TCE_TOKEN>(addr); - // Legacy Support: Also set System Level Attributes on Node 0 - // @TODO RTC 190014 Can Be Removed Once FSP Switches To Node Attributes - // Get Target Service and the system target to set attributes - TARGETING::TargetService& tS = TARGETING::targetService(); - TARGETING::Target* sys = nullptr; - (void) tS.getTopLevelTarget( sys ); - assert(sys, "utilSetupPayloadTces() system target is NULL"); - if (nodeId == 0) - { - sys->setAttr<TARGETING::ATTR_TCE_START_TOKEN_FOR_PAYLOAD>(token); - sys->setAttr<TARGETING::ATTR_START_MEM_ADDRESS_FOR_PAYLOAD_TCE_TOKEN>(addr); - } - // Save for internal use since can't trust FSP won't change attribute Singleton<UtilTceMgr>::instance().setToken(UtilTceMgr::PAYLOAD_TOKEN, token); @@ -212,13 +199,6 @@ errlHndl_t utilSetupPayloadTces(void) // Set attribute to tell FSP what the HDAT token is pNodeTgt->setAttr<TARGETING::ATTR_TCE_START_TOKEN_FOR_HDAT>(token); - // Legacy Support: Also set System Level Attributes on Node 0 - // @TODO RTC 190014 Can Be Removed Once FSP Switches To Node Attributes - if (nodeId == 0) - { - sys->setAttr<TARGETING::ATTR_TCE_START_TOKEN_FOR_HDAT>(token); - } - // Save for internal use since we can't trust FSP won't change the attribute Singleton<UtilTceMgr>::instance().setToken(UtilTceMgr::HDAT_TOKEN, token); |
