summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCorey Swenson <cswenson@us.ibm.com>2018-04-19 17:05:28 -0500
committerDaniel M. Crowell <dcrowell@us.ibm.com>2018-04-23 20:46:35 -0400
commitc5ed4fa654edf1cd2c869677007659578b554119 (patch)
tree51bf8f877cabb24c4ba1e1d8dfe495f8f03d9f32
parentf331fdfae22d11fa2897c779e38185190ca0168d (diff)
downloadtalos-hostboot-c5ed4fa654edf1cd2c869677007659578b554119.tar.gz
talos-hostboot-c5ed4fa654edf1cd2c869677007659578b554119.zip
Update Centaur attributes used in PRD Target Services
ATTR_EFF_CUSTOM_DIMM -> ATTR_CEN_EFF_CUSTOM_DIMM ATTR_EFF_DRAM_GEN -> ATTR_CEN_EFF_DRAM_GEN Change-Id: Iab0df8ebdcf3d8e2b070289607c14e5c8a0ae352 RTC:153297 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57523 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> CI-Ready: Zane C. Shelley <zshelle@us.ibm.com> Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com> Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
-rwxr-xr-xsrc/usr/diag/prdf/common/plat/prdfTargetServices.C30
1 files changed, 13 insertions, 17 deletions
diff --git a/src/usr/diag/prdf/common/plat/prdfTargetServices.C b/src/usr/diag/prdf/common/plat/prdfTargetServices.C
index 0a15b80bc..5b447a382 100755
--- a/src/usr/diag/prdf/common/plat/prdfTargetServices.C
+++ b/src/usr/diag/prdf/common/plat/prdfTargetServices.C
@@ -1327,21 +1327,17 @@ int32_t isMembufOnDimm( TARGETING::TargetHandle_t i_memTarget,
do
{
-// @TODO RTC: 153297 ATTR_EFF_CUSTOM_DIMM Type does not exist yet for P9
-// and will change from how it was defined in P8
-//
-// // The DIMMs in an node should either all be buffered or all not. So
-// // we can check the attribute from ANY MBA.
-// TargetHandleList list = getConnected( i_memTarget, TYPE_MBA );
-// if ( 0 == list.size() )
-// {
-// PRDF_ERR( "[isMembufOnDimm] Couldn't find an MBA target" );
-// break;
-// }
-//
-//
-// const TargetHandle_t mbaTarget = list[0];
-// o_isBuffered = mbaTarget->getAttr<ATTR_EFF_CUSTOM_DIMM>();
+ // The DIMMs in a node should either all be buffered or all not. So
+ // we can check the attribute from ANY MBA.
+ TargetHandleList list = getConnected( i_memTarget, TYPE_MBA );
+ if ( 0 == list.size() )
+ {
+ PRDF_ERR( "[isMembufOnDimm] Couldn't find an MBA target" );
+ break;
+ }
+
+ const TargetHandle_t mbaTarget = list[0];
+ o_isBuffered = mbaTarget->getAttr<ATTR_CEN_EFF_CUSTOM_DIMM>();
o_rc = SUCCESS;
@@ -1371,8 +1367,8 @@ int32_t getDramGen( TARGETING::TargetHandle_t i_mba, uint8_t & o_dramGen )
getHuid( i_mba ) );
break;
}
- //@TODO RTC: 153297 ATTR_EFF_CUSTOM_DIMM Type has changed
-// o_dramGen = i_mba->getAttr<ATTR_EFF_DRAM_GEN>( );
+
+ o_dramGen = i_mba->getAttr<ATTR_CEN_EFF_DRAM_GEN>( );
o_rc = SUCCESS;
OpenPOWER on IntegriCloud