diff options
| author | Alex Taft <amtaft@us.ibm.com> | 2017-06-15 13:46:56 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-06-19 13:46:49 -0400 |
| commit | 12a64eb99ca387c7fa1112611d274d17c7537c30 (patch) | |
| tree | 7437fee8f3cfa9357e69b5802024ae5eafc249a1 | |
| parent | 0f213e529348b462f2fad24b9ad12ad1aa8d76a7 (diff) | |
| download | talos-hostboot-12a64eb99ca387c7fa1112611d274d17c7537c30.tar.gz talos-hostboot-12a64eb99ca387c7fa1112611d274d17c7537c30.zip | |
L3 Initfile: Qualify divide_minor setting
L3_REF_TIMER_DIVIDE_MINOR needs to be left at default value of
Divide by 10 for DD1.X, DD2.0 due to bug
Change-Id: I9bfbf243ecf854c2375e852f60d0bcb47812fe87
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41893
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: LUKE MURRAY <murrayl@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Joseph J. McGill <jmcgill@us.ibm.com>
Reviewed-by: Matt K. Light <mklight@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41900
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/pm/p9_hcode_image_build.C | 14 | ||||
| -rw-r--r-- | src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml | 17 |
2 files changed, 28 insertions, 3 deletions
diff --git a/src/import/chips/p9/procedures/hwp/pm/p9_hcode_image_build.C b/src/import/chips/p9/procedures/hwp/pm/p9_hcode_image_build.C index 1b536348d..89572953a 100644 --- a/src/import/chips/p9/procedures/hwp/pm/p9_hcode_image_build.C +++ b/src/import/chips/p9/procedures/hwp/pm/p9_hcode_image_build.C @@ -3608,15 +3608,17 @@ fapi_try_exit: /** * @brief populate L3 Refresh Timer Control register * @param i_pChipHomer points to start of P9 HOMER. + * @param i_procTgt fapi2 target for p9 chip. * @return fapi2 return code. */ -fapi2::ReturnCode populateL3RefreshScomReg( void* i_pChipHomer ) +fapi2::ReturnCode populateL3RefreshScomReg( void* i_pChipHomer, CONST_FAPI2_PROC& i_procTgt) { FAPI_DBG("> populateL3RefreshScomReg"); do { uint32_t l_nest_freq_mhz = 0; + uint8_t l_chip_ec_feature_hw408892 = 0; uint32_t scomAddr = 0; uint32_t rc = IMG_BUILD_SUCCESS; uint64_t l_refreshScomVal ; @@ -3634,8 +3636,14 @@ fapi2::ReturnCode populateL3RefreshScomReg( void* i_pChipHomer ) l_nest_freq_mhz), "Error from FAPI_ATTR_GET for attribute ATTR_FREQ_PB_MHZ"); + FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CHIP_EC_FEATURE_HW408892, + i_procTgt, + l_chip_ec_feature_hw408892), + "Error from FAPI_ATTR_GET for attribute ATTR_CHIP_EC_FEATURE_HW408892"); + + // above 2GHz, set DIVIDE_MINOR = DIV_BY_12 = 0x2 - if (l_nest_freq_mhz >= 2000) + if ((l_nest_freq_mhz >= 2000) && (l_chip_ec_feature_hw408892 == 0)) { refreshValBuf.insertFromRight<EX_DRAM_REF_REG_L3_TIMER_DIVIDE_MINOR, EX_DRAM_REF_REG_L3_TIMER_DIVIDE_MINOR_LEN>(0x2); @@ -4025,7 +4033,7 @@ fapi2::ReturnCode p9_hcode_image_build( CONST_FAPI2_PROC& i_procTgt, "populateEpsilonL3ScomReg failed" ); //Update L3 Refresh Timer Control SCOM Registers - FAPI_TRY( populateL3RefreshScomReg( pChipHomer ), + FAPI_TRY( populateL3RefreshScomReg( pChipHomer, i_procTgt), "populateL3RefreshScomReg failed" ); //populate HOMER with SCOM restore value of NCU RNG BAR SCOM Register diff --git a/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml index d0490a5ab..6b99e7f6f 100644 --- a/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml +++ b/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml @@ -1952,6 +1952,23 @@ </attribute> <!-- ******************************************************************** --> <attribute> + <id>ATTR_CHIP_EC_FEATURE_HW408892</id> + <targetType>TARGET_TYPE_PROC_CHIP</targetType> + <description> + Nimbus DD1.X, DD2.0: Leave at deafult value of DIV_BY_10 + </description> + <chipEcFeature> + <chip> + <name>ENUM_ATTR_NAME_NIMBUS</name> + <ec> + <value>0x20</value> + <test>LESS_THAN_OR_EQUAL</test> + </ec> + </chip> + </chipEcFeature> + </attribute> + <!-- ******************************************************************** --> + <attribute> <id>ATTR_CHIP_EC_FEATURE_HW405880_LCO_IN_RETENTION</id> <targetType>TARGET_TYPE_PROC_CHIP</targetType> <description> |
