SBE Update: Don't alter HBB partition when customizing SBE image

This change creates a scratch copy of the HBBL (bootloader) partition during
SBE image customization because the data is potentially altered prior to
customizing it into the SBE image.  If the partition data is altered directly,
that can trigger a storage exception when HBBL's memory pages are read only.

Change-Id: I00f220170c69401d4dcefd294e96aacccc7baff8
Resolves: #133
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57442
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
CI-Ready: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com>
Reviewed-by: Marshall J. Wilks <mjwilks@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>

1 files changed, 8 insertions, 2 deletions

diff --git a/src/usr/sbe/sbe_update.C b/src/usr/sbe/sbe_update.C
index cf27fac16..4cdb67d1c 100644
--- a/src/usr/sbe/sbe_update.C
+++ b/src/usr/sbe/sbe_update.C
@@ -2078,8 +2078,14 @@ namespace SBE
                            err->reasonCode() );
                 break;
             }
-            const void* hbblPnorPtr = reinterpret_cast<const void*>(
-                                                                pnorInfo.vaddr);
+
+            // Create a working copy of HBBL since it may need to be modified
+            // and it's not legal to update code partitions
+            uint8_t pHbbl[MAX_HBBL_SIZE]={0};
+            memcpy(pHbbl,
+                   reinterpret_cast<const void*>(pnorInfo.vaddr),
+                   sizeof(pHbbl));
+            const void* hbblPnorPtr = reinterpret_cast<const void*>(pHbbl);
 
             // Use max hbbl size and not the PNOR size. The PNOR size can grow
             // to add a secure header, but the code size limit is still 20K.