summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian Geddes <crgeddes@us.ibm.com>2018-04-12 17:53:51 -0500
committerDaniel M. Crowell <dcrowell@us.ibm.com>2018-04-18 17:22:33 -0400
commit3c368848cf5e4ac3d585f3a56e7131fca08e88cb (patch)
treefcff4845545698a91655f858f68740add0a9f500
parent2d3cfebc29cc581d61719bf778fe06804024f0b3 (diff)
downloadtalos-hostboot-3c368848cf5e4ac3d585f3a56e7131fca08e88cb.tar.gz
talos-hostboot-3c368848cf5e4ac3d585f3a56e7131fca08e88cb.zip
Add recovery summary traces for sbeAttemptRecovery for FSP runtime
Previously you had to look at other traces, or decipher to binary trace to determine if the sbe was recovered or not, this commit adds clear traces after the recover effort is done to tell whether it was successful or not. Change-Id: I17ce4de2f7e1168409758ca0ef1a5eaa044d6728 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57146 CI-Ready: Christian R. Geddes <crgeddes@us.ibm.com> Reviewed-by: Martin Gloff <mgloff@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
-rw-r--r--src/usr/sbeio/common/sbe_attn.C4
-rw-r--r--src/usr/util/runtime/rt_fwnotify.C2
2 files changed, 6 insertions, 0 deletions
diff --git a/src/usr/sbeio/common/sbe_attn.C b/src/usr/sbeio/common/sbe_attn.C
index 338dc62c9..5d8be78e4 100644
--- a/src/usr/sbeio/common/sbe_attn.C
+++ b/src/usr/sbeio/common/sbe_attn.C
@@ -86,6 +86,8 @@ namespace SBEIO
// success or not
if (!l_sbeObj.isSbeAtRuntime())
{
+ TRACFCOMP( g_trac_sbeio,
+ "handleVitalAttn: SBE recovery attempt FAILED" );
/*@
* @errortype ERRL_SEV_PREDICTIVE
* @moduleid SBEIO_HANDLE_VITAL_ATTN
@@ -117,6 +119,8 @@ namespace SBEIO
// Inform OPAL the state of the SBE after a retry is successful
else
{
+ TRACFCOMP( g_trac_sbeio,
+ "handleVitalAttn: SBE recovery attempt was a SUCCESS" );
if (TARGETING::is_sapphire_load())
{
l_err = RT_SBEIO::vital_attn_inform_opal(i_procTarg,
diff --git a/src/usr/util/runtime/rt_fwnotify.C b/src/usr/util/runtime/rt_fwnotify.C
index 6f9a02cbc..5515563b6 100644
--- a/src/usr/util/runtime/rt_fwnotify.C
+++ b/src/usr/util/runtime/rt_fwnotify.C
@@ -182,11 +182,13 @@ void sbeAttemptRecovery(uint64_t i_data)
// Set msgType based on recovery success or failure (If sbe made it back to runtime)
if (l_SBEobj.isSbeAtRuntime())
{
+ TRACFCOMP(g_trac_runtime, "sbeAttemptRecovery: RECOVERY_SUCCESS");
l_req_fw_msg.generic_msg.msgType =
GenericFspMboxMessage_t::MSG_SBE_RECOVERY_SUCCESS;
}
else
{
+ TRACFCOMP(g_trac_runtime, "sbeAttemptRecovery: RECOVERY_FAILED");
l_req_fw_msg.generic_msg.msgType =
GenericFspMboxMessage_t::MSG_SBE_RECOVERY_FAILED;
}
OpenPOWER on IntegriCloud