diff options
| author | Zane Shelley <zshelle@us.ibm.com> | 2017-07-11 10:04:04 -0500 |
|---|---|---|
| committer | Zane C. Shelley <zshelle@us.ibm.com> | 2017-07-12 14:37:30 -0400 |
| commit | e8f1d8cc777476524f4097c4fab70543584f030f (patch) | |
| tree | 388fd570acf91c4df9fad36a2bbe436e55219b0d | |
| parent | 910b8651331e9678eced95c74fe1bd9d8eed7bad (diff) | |
| download | talos-hostboot-e8f1d8cc777476524f4097c4fab70543584f030f.tar.gz talos-hostboot-e8f1d8cc777476524f4097c4fab70543584f030f.zip | |
PRD: array out-of-bounds in MemUtils::getDramSize()
Change-Id: I86360e1fb7bd18e148185bd33124d70271140a4a
CQ: SW390498
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/42985
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com>
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43039
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
| -rwxr-xr-x | src/usr/diag/prdf/common/plat/mem/prdfMemUtils.C | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/usr/diag/prdf/common/plat/mem/prdfMemUtils.C b/src/usr/diag/prdf/common/plat/mem/prdfMemUtils.C index 124c4a6d8..942d98b94 100755 --- a/src/usr/diag/prdf/common/plat/mem/prdfMemUtils.C +++ b/src/usr/diag/prdf/common/plat/mem/prdfMemUtils.C @@ -398,7 +398,7 @@ uint8_t getDramSize<TYPE_MCA>(ExtensibleChip *i_chip, uint8_t i_dimmSlct) PRDF_ASSERT( nullptr != mcsTrgt ); - uint8_t mcaPos = i_chip->getPos(); + uint8_t mcaRelPos = i_chip->getPos() % MAX_MCA_PER_MCS; uint8_t tmp[MAX_MCA_PER_MCS][DIMM_SLCT_PER_PORT]; @@ -408,7 +408,7 @@ uint8_t getDramSize<TYPE_MCA>(ExtensibleChip *i_chip, uint8_t i_dimmSlct) PRDF_ASSERT( false ); } - return tmp[mcaPos][i_dimmSlct]; + return tmp[mcaRelPos][i_dimmSlct]; #undef PRDF_FUNC } |
