diff options
| author | Richard J. Knight <rjknight@us.ibm.com> | 2016-05-04 07:44:06 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2016-05-17 11:59:24 -0400 |
| commit | 78c1fff95273d42204726041595c6a2a201c0eb6 (patch) | |
| tree | 24703c66bb518bab54a3d6bf76b4dc8af5475bba | |
| parent | b65d352091a544ffa07bfeb4c37ebc44d16cabc2 (diff) | |
| download | talos-hostboot-78c1fff95273d42204726041595c6a2a201c0eb6.tar.gz talos-hostboot-78c1fff95273d42204726041595c6a2a201c0eb6.zip | |
Unable to add FFDC to RC after hwp returns error
-Updated ffdc execute path so that error is returned instead
of being committed, this change will make the error flow
similar to how it was in p8.
Change-Id: I2bbabb441aea4007f8ab90d7a68f9b266ddf9929
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/24068
Tested-by: Jenkins Server
Tested-by: Hostboot CI
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/24071
Tested-by: FSP CI Jenkins
| -rwxr-xr-x | src/import/hwpf/fapi2/tools/parseErrorInfo.pl | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/src/import/hwpf/fapi2/tools/parseErrorInfo.pl b/src/import/hwpf/fapi2/tools/parseErrorInfo.pl index 61a626673..9934d056e 100755 --- a/src/import/hwpf/fapi2/tools/parseErrorInfo.pl +++ b/src/import/hwpf/fapi2/tools/parseErrorInfo.pl @@ -1212,7 +1212,7 @@ foreach my $argnum (0 .. $#ARGV) # the default severity. print ECFILE " void execute(fapi2::errlSeverity_t" . " i_sev = fapi2::FAPI2_ERRL_SEV_UNDEFINED," . - "bool commit = true )\n"; + "bool commit = false )\n"; if ($arg_empty_ffdc eq undef) { print ECFILE " {\n"; @@ -1223,12 +1223,6 @@ foreach my $argnum (0 .. $#ARGV) "(i_sev == fapi2::FAPI2_ERRL_SEV_UNDEFINED)" . " ? iv_sev : i_sev);\n"; print ECFILE " }\n"; - print ECFILE " else\n"; - print ECFILE " {\n"; - print ECFILE " fapi2::createPlatLog(iv_rc, " . - "(i_sev == fapi2::FAPI2_ERRL_SEV_UNDEFINED)". - " ? iv_sev : i_sev);\n"; - print ECFILE " }\n\n"; print ECFILE " }\n"; } @@ -1236,6 +1230,7 @@ foreach my $argnum (0 .. $#ARGV) { print ECFILE " {\n"; print ECFILE " static_cast<void>(i_sev);\n"; + print ECFILE " static_cast<void>(commit);\n"; print ECFILE " }\n\n"; } |
