talos-hostboot/src/usr/sbe, branch master

Secure Boot: Inform FSP of key transition progress

2018-05-11T02:37:38+00:00

The existing key transition flow updates all SBE SEEPROMs within the system in the same boot, thereby quiescing all SBEs. This compromises the ability of FSP to detect a key transition TI at the end of the update process because the SBE is not alive to service FSP's incoming SBE FIFO request to read the memory holding the attention information. This change adds new support to log the key transition progress in a node target attribute introduced in an earlier commit and send that status to FSP via a new mailbox message. Change-Id: I828184ae8be89ac87137d7510a3c375cef2e05d7 CQ: SW418697 CMVC-Prereq: 1053806 CMVC-Prereq: 1053552 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56677 Tested-by: Jenkins Server Tested-by: FSP CI Jenkins Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Michael Baiocchi Reviewed-by: Marshall J. Wilks Reviewed-by: Daniel M. Crowell

SBE Update: Don't alter HBB partition when customizing SBE image

2018-04-19T18:43:07+00:00

This change creates a scratch copy of the HBBL (bootloader) partition during SBE image customization because the data is potentially altered prior to customizing it into the SBE image. If the partition data is altered directly, that can trigger a storage exception when HBBL's memory pages are read only. Change-Id: I00f220170c69401d4dcefd294e96aacccc7baff8 Resolves: #133 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57442 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins CI-Ready: Nicholas E. Bofferding Reviewed-by: Michael Baiocchi Reviewed-by: Martin Gloff Reviewed-by: ILYA SMIRNOV Reviewed-by: Marshall J. Wilks Reviewed-by: Daniel M. Crowell

Secure Boot: Close SBE Security Backdoor

2018-03-30T21:02:21+00:00

During a key transition process from dev to prod keys the lab override bit does not get unset and does not get customized into SBE at the time of the transition. Only when the system reaches istep 10.2 with prod keys does the bit get reset. This change customizes the bit at the time of the transition, which ensures the system is secure all the way through IPL with prod keys. Change-Id: I1343d2dd95aa4549b92e46ebcb9df142303c1f0b RTC: 188958 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56127 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Michael Baiocchi Reviewed-by: Nicholas E. Bofferding Reviewed-by: Daniel M. Crowell

Ensure ATTR_EC_GARD and ATTR_EQ_GARD are updated before SBE update

2018-03-26T17:02:22+00:00

The xip_customize code does not look at target states directly. Instead it just shoves a couple of attributes directly into the image. This change ensures those attributes are set correctly before executing the xip_customize procedure. Change-Id: I6e9ffedcea08af70882be1de6ff2203de8b3e30b CQ: SW421514 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56144 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Martin Gloff Reviewed-by: Christian R. Geddes Tested-by: FSP CI Jenkins CI-Ready: Nicholas E. Bofferding Reviewed-by: Nicholas E. Bofferding

Created individual update flags for both SEEPROM 0 and SEEPROM 1

2018-03-12T18:22:13+00:00

I created individual update flags for both SEEPROM 0 and SEEPROM 1 to better target which seeprom to update. Now SEEPROM 0 or SEEPROM 1 or both can be singled out for update(s). Change-Id: I91f1b66f6a1f2e42d37173fb9e21f87e440d3a21 RTC: 189218 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/55173 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Tested-by: Jenkins OP HW Reviewed-by: Martin Gloff CI-Ready: Daniel M. Crowell Reviewed-by: Christian R. Geddes Reviewed-by: William G. Hoffa

Introduce new shared library for image processing fucntions

2018-03-02T16:52:56+00:00

-Moved xip functions from pm lib into libimageprocs.so -Updated DEPLIBS to include new libimageprocs.so for istep libs. Change-Id: I9e1c90643448146f6e8ef953106c0eea521e35f0 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/51754 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: William G. Hoffa CI-Ready: Thi N. Tran Reviewed-by: Daniel M. Crowell

Force an SBE update upon boot failure as well as break out common data

2018-02-28T18:46:06+00:00

This commit takes care of two stories since they are related to each other. First, moved all common data (structs, enums, constant literals) from file sbe_update.H into sbe_common.H. This will allow content to be shared between FSP and HB with out having to have simultaneous updates. Secondly, an update will be forced if bit 3 of the SB keyword flags dictates it, regardless of whether an update is recommended or not by other logic. Change-Id: I3bd3c5cdd648309637bdf657db8f0935670c7d12 RTC:181140 RTC:181141 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/54408 Reviewed-by: Martin Gloff Reviewed-by: Brian E. Bakke Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Tested-by: Jenkins OP HW Reviewed-by: Daniel M. Crowell

Send additional FSP progress messages during long isteps (e.g. memdiags)

2018-02-16T02:52:28+00:00

Updated sendProgressCode() so that it would only output trace or console messages once per step/substep. Replaced most calls to IPMIWATCHDOG::resetWatchDogTimer() with calls to sendProgressCode() which calls resetWatchDogTimer() if communicating with a BMC, or updates the FSP with its progress on FSP-based systems. Change-Id: I29beb7ce5cdae467d26a0b2c5fee9e3cc4629161 RTC: 169682 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53995 Reviewed-by: William G. Hoffa Reviewed-by: Prachi Gupta Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

Cumulus updates and testcase workarounds

2018-01-25T20:22:21+00:00

Change-Id: I24092ef382fc56b7d3e0aa90a2699ff6cf42d8e7 RTC:180894 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/48703 Reviewed-by: William G. Hoffa Reviewed-by: Prachi Gupta Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

Remove is_master conditional from getVersionInfo in sbe_update

2018-01-18T19:10:50+00:00

Previously we were having issues reading from the slave proc's SBE while we were in cache containment. We have re-order the IPL steps to reset the memory bars later on in the boot. This allows us to perform the reads now. We had issues running chipOps on simics. I am opening up a defect to look into this problem but for now we will only do i2c reads on simics. Change-Id: I177082d9c443d83ee750c57cde9a16c09844807f RTC: 182266 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/52040 Reviewed-by: Martin Gloff Reviewed-by: Roland Veloz Tested-by: Jenkins Server Reviewed-by: Daniel M. Crowell