talos-hostboot/src/usr/pnor, branch master

Reduce Console Output Trace from PNOR component in OpenPower

2018-04-18T21:23:53+00:00

I found that these TRACFCOMPs were adding thousands of lines to my console output and they are benign good-path traces. I have changed them to TRACDCOMPs. Change-Id: Ia5939bfa6eb4b6efa6587ff577c76e5824b38c75 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57359 Reviewed-by: ILYA SMIRNOV Reviewed-by: Nicholas E. Bofferding Tested-by: Jenkins Server Reviewed-by: William G. Hoffa Tested-by: FSP CI Jenkins Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Daniel M. Crowell

Mark Read-Only Partitions as Such

2018-04-12T20:20:04+00:00

Partitions marked with readOnly tag in the xml were treated as WRITABLE in the code. This change modifies the permissions to be READ_ONLY and adds unit tests to test the read only functionality. Change-Id: I8c1f23fd7e30edc38ff882c59716ab63a4f310e6 CQ: SW423350 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56771 CI-Ready: ILYA SMIRNOV Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Nicholas E. Bofferding Reviewed-by: Daniel M. Crowell Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57066 Tested-by: FSP CI Jenkins

Handle early life PNOR fails in HBRT instead of hanging

2018-04-09T21:16:24+00:00

A hang happens when RtPNOR code creates an error log while it still hasn't initialized completely. Error log code calls PNOR code that hasn't completed initialization yet. The fix is to assert in HBRT and by the time HBRT gets restarted, PNOR should be present and accessible. Change-Id: I24a4046be9da921933e7ca9005088945a0c25cfa RTC:189291 CQ:SW423599 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56802 Reviewed-by: Martin Gloff Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Christian R. Geddes Reviewed-by: Daniel M. Crowell

Secure Boot: Close SBE Security Backdoor

2018-03-30T21:02:21+00:00

During a key transition process from dev to prod keys the lab override bit does not get unset and does not get customized into SBE at the time of the transition. Only when the system reaches istep 10.2 with prod keys does the bit get reset. This change customizes the bit at the time of the transition, which ensures the system is secure all the way through IPL with prod keys. Change-Id: I1343d2dd95aa4549b92e46ebcb9df142303c1f0b RTC: 188958 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56127 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Michael Baiocchi Reviewed-by: Nicholas E. Bofferding Reviewed-by: Daniel M. Crowell

Revert "Check the Section Headers in Non-Secure Mode"

2018-03-26T17:08:58+00:00

This reverts commit c82b626e6ea1d56c0d25cbd5954064e256135002. Change-Id: I0ae2328866e0f90ec583b19044ff917a4f52726c Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56126 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: ILYA SMIRNOV Reviewed-by: Michael Baiocchi Reviewed-by: Daniel M. Crowell

Only call PNOR::init() on systems with BMC

2018-03-12T19:06:41+00:00

Code to fix SW412798 forgot to check for non-fsp systems. FSP systems will return an error. 0 size FIRDATA section. Change-Id: Ic2c2c49707d49b29cc38358ef6ab9dd372e8ffab Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/55373 Reviewed-by: Christian R. Geddes Reviewed-by: Prachi Gupta CI-Ready: William G. Hoffa Tested-by: William G. Hoffa Reviewed-by: William G. Hoffa

Check the Section Headers in Non-Secure Mode

2018-03-12T18:27:28+00:00

When a PNOR section without a header is flashed onto a system that doesn't have SECUREBOOT compiled in, no header checks are performed, but the code still acts as if the header is present, and so the virtual address of the section is set to point past the secure header, which is 0x1000 into the section image, which causes all kinds of issues. This change adds logic to check the headers even when Secure Boot features are compiled out. Change-Id: Ieece371014192f160273939a35cb175aef0ddb25 Resolves: #126 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/54831 Reviewed-by: Nicholas E. Bofferding Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Michael Baiocchi Reviewed-by: Daniel M. Crowell

Secure Boot: Detach secure PNOR provider task

2018-03-07T20:02:55+00:00

Once secure PNOR provider task starts, immediately detach it so that, should it die, Hostboot will terminate; otherwise, Hostboot can hang until terminated by a service processor boot timeout. Change-Id: I586db0bb56e7e1eedb1183cda34e4bda4bc03bbd CQ: SW419735 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/55048 Tested-by: Jenkins Server Reviewed-by: ILYA SMIRNOV Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Michael Baiocchi Reviewed-by: Daniel M. Crowell

Initialize FIRDATA section and ErrlManager just incase BMC resets

2018-03-07T17:54:24+00:00

PRD needs to read the PNOR to tell OCC where to write in the pnor. This will cache the PNOR section so PRD will not fail the read call. If an error is created with pnor inaccessible, errl manager could get stuck unless it was initialized first. Change-Id: Ia7212bf99e947a1016423b37aff6f13ddfc7190a CQ:SW412798 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/54990 Reviewed-by: Martin Gloff Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Reviewed-by: Roland Veloz Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins CI-Ready: Daniel M. Crowell Reviewed-by: Daniel M. Crowell

Tweak IBM SFC flash settings for Micron chips

2018-02-07T14:31:15+00:00

-Micron flash chips were failing in FSP based systems Removed offending settings, but need to figure out why -Also added in some useful printk's for debug Change-Id: I46c1c7ce7d5f74d9302985ac821214ff25c6bfc1 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53344 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Prachi Gupta Reviewed-by: Richard J. Knight Reviewed-by: William G. Hoffa