talos-hostboot/src/usr/mbox, branch 07-25-2019

Automatically include config.h

2019-12-06T16:28:47+00:00

Rather than having to remember to include config.h anywhere we reference a CONFIG variable (and usually forgetting), this adds it to the default compiler flags so that it gets included in every source file we build. Change-Id: I53622ab4d46c55d942e98cae6ec03049fd5b3d08 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87475 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Zachary Clark Reviewed-by: Roland Veloz Reviewed-by: Christian R Geddes Reviewed-by: Nicholas E Bofferding

Serialize all attribute synchronization calls

2018-10-17T13:18:29+00:00

Forces all FSP attribute synchronizations down to FSP to serialize in the attribute resource provider attribute synchronization daemon thread to avoid concurrenty problems. Change-Id: Ifb355ba6f42872465ea3d6f0d9009cfd6f768d7a CQ: SW448280 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67450 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

Improve error traces for MBOX errors

2018-10-16T16:23:14+00:00

If an error flag is found to be set when reading a mbox msg we want to print out the error status register in addition to stating that an error occured. Change-Id: I56267880bf6d8ea3edc0bf1ff7bf25c1cf900361 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67520 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Dean Sanner Reviewed-by: Matt Derksen Reviewed-by: Daniel M. Crowell

Shutdown: Move attribute sync to shutdown handler

2018-10-01T20:37:58+00:00

Moved synching attributes into an attribute resource provider shutdown path to avoid race conditions along the shutdown path where a normal error path coupled with parallel shutdown leads to FSP attribute sync errors. Change-Id: Ibdb828f8132da1e251f880ef0e7d4fea2e4619a3 CQ: SW443737 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66431 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

Additional tracing for shutdown events

2018-09-12T15:31:05+00:00

Hit an issue where a shutdown was called but all that is traced is a msgQ pointer. These traces should help associate the msgQ pointer to an actual task being shutdown. Change-Id: Ic22fdde1a146eec90f26d557e8af1ddec3c85c4e CQ:SW443508 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65464 Reviewed-by: Christian R. Geddes Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Corey V. Swenson Reviewed-by: Daniel M. Crowell

Turn off core xstop escalalation on slave nodes prior payload handoff

2018-09-10T15:05:45+00:00

There was a bug in the code where we only were turning off core xstop escalation on the master node. This is because we were not using IPC to tell slave nodes they also need to do this. This commit re-adds the enableCoreCheckstop function to istep21 and adds it to part of the IPC_START_PAYLOAD message handler so this will happen prior to shutdown on all nodes. Change-Id: I0b601f379635107c851d6fc723b75a0ba21d1016 CQ: SW444801 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65768 Reviewed-by: Dean Sanner Reviewed-by: William G. Hoffa Reviewed-by: Nicholas E. Bofferding Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Christian R. Geddes

Only unmask source on proc targ passed to unmask function in intrrp

2018-08-01T21:13:13+00:00

There was a bug in the code where if an interrupt was resolved for a source the code to clean up the pending interrupt in the intrrp will unmask the source. This was actually unmasking the source on all processors. This causes odd behavior if there was an outstanding int on that source on one of the other processors. Essentially the intrrp would think that a new interrupt came in but we will already be handling it. The logic breaks down here and we end up getting in a locked state. Fixing this caused issues with Hostboot management of the maskList which kept track of which sources were masked. Instead of managing this list of masked sources hostboot will instead keep track of sources which are not registered to any msg Qs. When new processors are added to the interrupt resource provider after fabric is up, all LSI sources who are not registered to a msg Q will be masked for the new processor. CQ: SW419101 Change-Id: I86f5bc2a748383e18b1853d9bf9480f265c214fd Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/63158 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Dean Sanner Reviewed-by: Daniel M. Crowell

SBE PSU timeout during MBOX init causes task crash/HB TI

2018-07-05T21:13:04+00:00

- Handling a PSU DD Timeout involves invoking the SBE Retry handler, which can cause crashes (FAPI library not yet initialized) if the timeout happens very early in the IPL. - Added a check if the FAPI Library was loaded, and added a call to handle the early timeout later in the IPL. Change-Id: I199cf0302af916b3f6ffec598ccab04c031e48e6 RTC:433868 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/61730 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Disable-CI: Nicholas E. Bofferding Reviewed-by: Prachi Gupta Reviewed-by: William G. Hoffa

Print out MBOX/INTR state info on DMA request hang

2018-07-05T13:50:43+00:00

We have been stuck on a hang that occurs during memdiags on our multi-node p9 systems. It appears that Hostboot is never receiving the response to the request to reclaim DMA buffers from the FSP. From debugging we know the FSP thinks it has sent the message over the FSI mbox but hostboot isnt seeing it. Next time this happens if this is in the code we should be able to get a better idea of what is happening. Change-Id: I6b702e4094da3576ba454b5cdf0660841961baff Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/60977 Reviewed-by: Richard Ward Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Roland Veloz Tested-by: FSP CI Jenkins Reviewed-by: William G. Hoffa

Leverage INTRP fully for SBE PSU Interrupt Handling

2018-06-29T02:43:13+00:00

- Remove PSU Handling from INTRP code and instead treat PSU interrupts like any other interrupt type - Add msg_handler to SBE PSU Code to handle interrupts - Add better interrupt handling to timeout path so the interrupt condition will be cleared instead of represented continuously - Handle shutdown message from INTRP Change-Id: I5eafea806e147c22be235ae1c54a5ce4706aa012 RTC: 149698 CQ: SW418168 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/60049 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Christian R. Geddes Reviewed-by: Nicholas E. Bofferding Reviewed-by: Daniel M. Crowell