talos-hostboot/src/usr/isteps/ucd, branch 07-25-2019

Automatically include config.h

2019-12-06T16:28:47+00:00

Rather than having to remember to include config.h anywhere we reference a CONFIG variable (and usually forgetting), this adds it to the default compiler flags so that it gets included in every source file we build. Change-Id: I53622ab4d46c55d942e98cae6ec03049fd5b3d08 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87475 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Zachary Clark Reviewed-by: Roland Veloz Reviewed-by: Christian R Geddes Reviewed-by: Nicholas E Bofferding

Fix UCD invalid command error for 0 byte block read SMBus requests

2019-04-17T20:51:00+00:00

If a UCD device had a legitimate 0-sized reponse to a block read request, this set off a bug in the code where the i2c driver would issue a 0 byte read request without a start, stop, or address bit, which causes the i2c engine to throw a command invalid error. This commit fixes the logic so that in that condition, the driver either skips the offending read (for cases where a PEC byte follows), or completes the transaction with a stop bit (for no PEC byte case) Change-Id: I64011b4e540120c8547fa3ca84a4dd68f45b479a CQ: SW462736 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75940 Reviewed-by: Ilya Smirnov Reviewed-by: Matthew Raybuck Reviewed-by: Michael Baiocchi Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

Cleanup UCD Update Algorithm Code

2019-04-03T14:52:25+00:00

This commit converts previous asserts to valid error log calls while also updating some traces to the UCD update algorithm procedure. Change-Id: I4579d1eb602bbcb35ef9fd01131178d24007727a RTC:205979 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75323 Reviewed-by: Matthew Raybuck Tested-by: Jenkins Server Reviewed-by: Ilya Smirnov Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Tested-by: Jenkins OP HW Reviewed-by: Nicholas E. Bofferding

Fix UCD retry loop size bug

2019-03-30T22:55:50+00:00

There is a bug in the attemptDeviceOp code where an error during the deviceOp function will overwrite the io_bufferLength value causing the retry loop to fail permanently on subsequent retries. Change-Id: Ib525e60e1c6cca2604a279cc595946a92cd4f94d RTC: 205982 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75243 Reviewed-by: Michael Baiocchi Reviewed-by: Ilya Smirnov Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Nicholas E. Bofferding

Create Attribute to force UCD Updates

2019-03-30T13:41:17+00:00

This commit adds ATTR_UCD_MFR_REVISION_OVERRIDE such that a user can override the MFR_REVISION seen on a UCD device. This could then force a UCD flash update. Change-Id: I3d807b3ddf2c62752046953f0f3d1754d80da381 RTC:205982 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75179 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Reviewed-by: Ilya Smirnov Tested-by: Jenkins OP HW Reviewed-by: Nicholas E. Bofferding

Handle bad PEC from UCD device op

2019-03-30T03:24:18+00:00

The current UCD code doesn't have any error handling for a bad PEC byte instead it is just ignored. This will add the necessary error handling to the retry code for bad PEC bytes. Change-Id: I8d9960a203b5864812bcaa0019087bb3dcff0c53 RTC:205982 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75174 Reviewed-by: Michael Baiocchi Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Tested-by: Jenkins OP HW Reviewed-by: Nicholas E. Bofferding

Add retry loop to UCD deviceOps

2019-03-29T19:54:25+00:00

The UCD requirements say that if a device operation fails to attempt a total of three times before giving up. This commit adds that functionality. Each deviceOp is attempted three times with the addition of the attemptDeviceOp function. Change-Id: I03874f66465960c672026fb42a8719e6b6aad7ec RTC:205982 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75109 Reviewed-by: Nicholas E. Bofferding Reviewed-by: Ilya Smirnov Tested-by: Jenkins Server Reviewed-by: Michael Baiocchi Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

Verify UCD update success at end of store to UCD flash

2019-03-29T19:53:08+00:00

Implements manufacturer recommended verification procedure to determine if the UCD updates to data flash worked correctly. Verifies if the MFR_STATUS bit indicating flash update completed is set, then checks to see if the flash update error bit is confirmed not to be set. On any failure, calls out the UCD device as a predictive error. Change-Id: Ibe0e00029dbd41291f8651f083434ce059c2c37f RTC: 205979 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75099 Reviewed-by: Matthew Raybuck Reviewed-by: Michael Baiocchi Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

Invoke UCD Update Algorithm on UCD Devices

2019-03-26T15:38:01+00:00

This commit invokes the full UCD update algorithm on all UCD9090 and UCD90120A devices found in ZZ and Zeppelin systems. The algorithm is based on walking through a pre-processed update binary per UCD device and calling the appropriate SMBUS device operations. Change-Id: I626df3612260d505e65a22d0620b65216d00c65f RTC:205979 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/74887 Reviewed-by: Matthew Raybuck Reviewed-by: Ilya Smirnov Tested-by: Jenkins Server Tested-by: FSP CI Jenkins Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Nicholas E. Bofferding

Add check to determine if a UCD's I2C Master is functional

2019-03-26T15:21:13+00:00

Inside the code that loops over all the supported UCD devices for possibly updating their flash image, a check was added to make sure that the UCD's I2C Master target is functional. Change-Id: Id03bf20f0295a27f67f9da8da207934af710630f CQ:SW460918 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75002 Tested-by: Jenkins Server Tested-by: FSP CI Jenkins Reviewed-by: Matthew Raybuck Reviewed-by: Ilya Smirnov Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Nicholas E. Bofferding