talos-hostboot/src/usr/ipmi, branch 07-25-2019

ipmi: Split into ipmibase and ipmiext modules

2018-10-10T18:39:41+00:00

Split the IPMI module into base and ext portions, with the BT interface, device driver and resource provider in the base portion, and all remaining IPMI functionality in the ext portion. The split is in preparation for moving the base functionality in the hostboot base image. Change-Id: Iec864f96240d79f4fadd5519d2ef46437d07c1fd Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66792 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Reviewed-by: Corey V. Swenson Tested-by: FSP CI Jenkins Tested-by: Jenkins OP HW Reviewed-by: Daniel M. Crowell

ipmi: IpmiDD and IpmiRP must never free resources

2018-10-10T18:38:21+00:00

An IPMI-based PNOR implementation will be introduced in the future. If it is in use (and it likely will be), then IpmiDD and IpmiRP must be functional right up until the shutdown() syscall is invoked. This is necessary because hostboot assumes parts of the PNOR can be paged in at any time (though not necessarily dirtied and flushed), and IPMI is now required to fulfil the requests. Remove the unnecessary shutdown-related code from both classes. Change-Id: I82276e5e12c8b917d655000a456b72a2ccacdb5f Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67077 Tested-by: Jenkins Server Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

ipmi: Terminate SEL task via shutdown event

2018-10-09T15:07:42+00:00

The IpmiSEL task will become part of the extended image once the IPMI module is split in two. Once split, if we need to handle an early shutdown we cannot be referencing code from HBI in HBB. To that end, ensure we don't instantiate an IpmiSEL via Singleton in an attempt to shutdown its event loop when it hasn't been loaded, let alone started. Instead, have IpmiSEL register itself in the shutdown handler, and shut down the SEL task before IpmiRP. Change-Id: I358f6cb1f5528a4ad72c93477ad883cad19e2bf6 Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67076 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Corey V. Swenson Reviewed-by: Daniel M. Crowell

ipmi: Introduce register_for_event() interface

2018-10-08T20:29:30+00:00

register_for_event() allows the IPMI PNOR implementation to indicate interest in SELs from the hiomap protocol used for managing the LPC FW space. Change-Id: I3bf6cb7f860d41a0c46755e23fd54276ae2258ff Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65938 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

ipmi: Drop unnecessary ipmibt dependency from ipmifru

2018-10-08T20:25:52+00:00

Change-Id: I5c0f88f5a95c95928248141b3a8713fb9fe0ed6d Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66791 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

ipmi: Drop unnecessary ipmiconfig dependencies

2018-10-08T20:25:31+00:00

Removing the unused include is a cleanup motivated by splitting the ipmi module in two, into parts consisting of the service (DD and RP) and clients (FRU, SEL, etc). Change-Id: Idc4b7c839edda5f23d73a0e0ad8112b2bcbb255d Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66790 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Daniel M. Crowell

ipmi: Break circular dependency between IpmiDD and IpmiRP

2018-10-08T20:24:20+00:00

Previously IpmiDD depended on IpmiRP to acquire IpmiRP's message queue for IpmiDD to enqueue hardware state change events. IpmiRP in-turn depends on IpmiDD for shutdown event handling, calling through IpmiDD::handleShutdown() in IpmiRP::shutdownNow(). Break the circular dependency by asynchronously publishing hardware state change events from IpmiDD on a queue owned by IpmiDD. IpmiRP consumes messages from IpmiDD's event queue and republishes them on its own internal queue for consumption by the state management task. This is a little inefficient but provides for greater design clarity in the face of a lack of a select() or poll() style interface that would allow listening for messages on multiple message queues. Change-Id: I3c3c3209d515ec9e90c04630779624bf85e953b1 Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65936 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Corey V. Swenson Reviewed-by: Daniel M. Crowell

Support for extended FRU data for memory modules

2018-10-03T14:36:59+00:00

Decode some DIMM SPD fields according to JEDEC format to write detailed info into an IMPI FRU message: 1. Manufacturer field contains real orgainsation name instead of ID. 2. Module name contains type, capacity, speed and other attributes. Change-Id: I869d2fdcdffa40aa0439a119a1327d83931f5ec5 Signed-off-by: Artem Senichev Signed-off-by: Maxim Polyakov Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66746 Tested-by: Jenkins Server Reviewed-by: Daniel M. Crowell Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: William G. Hoffa Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66902 Tested-by: FSP CI Jenkins

ipmi: Replace incorrect dependency on ipmibt with ipmimsg

2018-10-02T19:42:51+00:00

No symbols from ipmibt.H were required, but some from ipmimsg.H were. Change-Id: I9730670b5c2686cbf3f55e2b52e91ded3d78cfb0 Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65935 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Corey V. Swenson Reviewed-by: Daniel M. Crowell

ipmi: Break circular dependency between ipmimsg and ipmibt

2018-10-02T19:42:41+00:00

Implement the message factory in the back-end implementation for which it is producing messages. The linker will resolve the right implementation based on the build configuration. Change-Id: I407f51e239b3dd3795502942cc24d80fbf0ffac6 Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65934 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Corey V. Swenson Reviewed-by: Daniel M. Crowell