talos-hostboot/src/usr/initservice, branch 07-25-2019

Add detailed ISTEP output option to hostboot

2020-02-19T20:15:52+00:00

Output detailed ISTEP data over LPC port 81h/82h in support of RCS Talos II systems. These systems will deadlock due to FSI silicon bugs in the CPUs unless the BMC is aware of the current ISTEP data in order to properly sequence BMC-side FSI service startup.

Add current istep into TI SRC

2019-12-18T17:41:02+00:00

Word4 of the SRC is defined to be the 'last progress code' for FSP SRCs. For Hostboot TIs, we currently leave that word zero. This change will add the same data that we put into the scratch register 5 into word4 so that we will have the failing istep for any TI we encounter. Change-Id: Iaf5ec835d45b1ea3a6ced20b5b7f7d07216c548e Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/88813 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Ilya Smirnov Reviewed-by: Matt Derksen Reviewed-by: Nicholas E Bofferding

Automatically include config.h

2019-12-06T16:28:47+00:00

Rather than having to remember to include config.h anywhere we reference a CONFIG variable (and usually forgetting), this adds it to the default compiler flags so that it gets included in every source file we build. Change-Id: I53622ab4d46c55d942e98cae6ec03049fd5b3d08 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87475 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Zachary Clark Reviewed-by: Roland Veloz Reviewed-by: Christian R Geddes Reviewed-by: Nicholas E Bofferding

Fix invalid use of vector iterator

2019-10-16T13:21:11+00:00

Once an element of a vector is erased using an iterator, that iterator should be considered invalid and not used. The accepted practice is to update the iterator with the return value of the erase method and not to increment the iterator. CQ: SW465848 Change-Id: If6ec7887d8c2b6c6ad44a9608c474b9c118bd117 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85220 Reviewed-by: Zachary Clark Reviewed-by: Michael Baiocchi Reviewed-by: Daniel M Crowell Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Nicholas E Bofferding

Add wrapper to exp_getidec HWP so we can call it in platform code

2019-09-20T21:14:31+00:00

There has been a trend to create more HWPs that process raw data. This allows Hostboot and Cronus to share more code. The trick is that we generally want to call these HWPs inside traditionally hostboot-only code. This new fapiwrap directory will help encapsulate all of the calls to ekb code in one place. That way if we ever need to remove HWPs/EKB code it will be easier to stub out the calls. In the past we have contaminated a lot of Hostboot-only code with calls out to EKB code. This new new directory should help avoid this issue. Change-Id: I2b2d0d1e62c97f0976c9c9ede3fe2eac30c7a40f RTC: 214627 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83029 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Ilya Smirnov Reviewed-by: Daniel M Crowell

Add SMF mode flag to HOMER for use by OCC

2019-04-30T18:27:01+00:00

Change-Id: I03daab724811f09aa83c4e0d7929f0a013a2b731 RTC: 164116 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76398 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Reviewed-by: Christopher J. Cain Tested-by: FSP CI Jenkins Tested-by: Jenkins OP HW Reviewed-by: Martha Broyles Reviewed-by: Sheldon Bailey Reviewed-by: Daniel M. Crowell

Moving libnvdimm into a resident module

2019-03-22T11:48:52+00:00

The nvdimm module provides the back-end of a device driver interface. That means that it has a REGISTER_ROUTE call that will run when the module is loaded. Right now the module is loaded/unloaded for several isteps, which means we end up seeing DEVFW_RC_DOUBLE_REGISTRATION errors. These are only informational, but they are still indicating a problem. This change moves the libnvdimm.so module into the list of extended initservice tasks that get loaded before we start the isteps. This is where all of our other device drivers live. I cleaned up a leftover call to libmmio.so that was there from the same kind of change previously. Change-Id: I3e2e1bc8e273b46b8c297be0d9d75ff3e660fa00 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72731 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Matt Derksen Reviewed-by: Corey V. Swenson Reviewed-by: William G. Hoffa

Add ASSERT trace buffer to task crash log

2019-03-19T19:36:50+00:00

A common cause of task crashes is an explicit assert. Without full traces we can't differentiate an assert from a nullptr error, and we don't know which line failed. This will add the ASSERT trace to the error log that gets created for any task crash. Change-Id: Ieaccf74ab7c8688109b80b0e22818e45cfdb8028 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72557 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Tested-by: Jenkins OP HW Reviewed-by: Matt Derksen Reviewed-by: Roland Veloz Reviewed-by: Corey V. Swenson Reviewed-by: Daniel M. Crowell

Dropped messages at shutdown

2019-03-15T15:34:40+00:00

Mailbox is needed to send attrs to FSP but it is disabled after a shutdown request, which causes messages to be dropped. Solution is to process messages as normal, but after the shutdown is requested we then ignore all future attr messages Change-Id: I7f3cc4bea66f324ae9ab8dbffe59bf9a7a7edc87 CQ: SW448904 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/71012 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Reviewed-by: Nicholas E. Bofferding Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Michael Baiocchi Reviewed-by: Daniel M. Crowell

Create a common explorer accesss module expaccess

2019-03-11T20:53:07+00:00

Move everything from expscom to the new, more general, expaccess. All code dealing with io to explorer should live here. Also add some ocmb communication test cases. Change-Id: Icd57bc094782873afb18ac22518aa2681db0b933 RTC: 186630 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72224 Reviewed-by: Matt Derksen Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Reviewed-by: Christian R. Geddes