talos-hostboot/src/usr/i2c, branch master

Rediscover I2C Targets after Host I2C Reset

2018-05-07T13:54:48+00:00

It's possible that some targets that use I2C to detect if they are present might not be present after a system re-IPLs and performs a FSI I2C Reset. Therefore, later in the IPL, after a Host I2C Reset sequence an attempt to rediscover any of these targets is made. If any new targets are found, the system will re-IPL. Currently only supporting looking for DIMMs now on OpenPower systems with securemode enabled. Change-Id: I010135231f2f74869529a3dbc3344413b6d19dc9 RTC:178973 Backport:release-op920 CQ:SW427365 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57744 Tested-by: Jenkins Server Tested-by: FSP CI Jenkins Reviewed-by: Nicholas E. Bofferding Reviewed-by: ILYA SMIRNOV Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Daniel M. Crowell

Reset Host-mode Processor I2C Masters connected to the TPMs

2018-03-30T21:07:19+00:00

This commit resets the I2C buses connected to the TPMs early in the IPL since the FSP can't do the reset for us as they lack a FSI I2C connection to the TPMs. Change-Id: I4b4893da447f3c567c04a8d0c2b647f2927ec0ab RTC:188956 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56188 Reviewed-by: ILYA SMIRNOV Reviewed-by: Nicholas E. Bofferding Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

Add FFDC to 'No Functional TPM' Fails

2018-03-19T15:40:49+00:00

When no functional TPMs are detected, but TPMs are required, this commit will capture the Security Registers of each processor in the system and add them to the error log. It also updates how the tpmMarkFailed() function links and commits various error logs. Change-Id: I2e95bbfcb6ab3f3dff26149f234c219d4280e1fb CQ:SW417814 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/54808 CI-Ready: Michael Baiocchi Reviewed-by: Nicholas E. Bofferding Reviewed-by: ILYA SMIRNOV Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

Secure Boot: Mark redundant TPM not present until SMP is enabled

2018-03-15T22:13:50+00:00

Until the SMP is up, a redundant TPM is not able to be presence detected. This change updates the TPM presence detect routine to report a TPM connected to remote processor as not present when the remote processor is not connected to the SMP, so that Hostboot doesn't hit errors attempting to access/use the TPM at inappropriate times. Change-Id: I10aa683ec073be2b44e810746bee320dd6366184 RTC: 184515 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/55814 Reviewed-by: ILYA SMIRNOV Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Christopher J. Engel Reviewed-by: Michael Baiocchi Reviewed-by: Daniel M. Crowell

Add Reset to TPM's I2C Bus for MPIPLs

2018-03-01T14:51:04+00:00

This commit updates the general I2C reset function to only reset certain engine(s) of the I2C master. This new functionality is then used to reset all of the processor I2C engines that can drive the TPMs on MPIPLs. Change-Id: Ie19e93233b5012b69d59bfc3f485ce2914d665da CQ:SW419116 Backport:release-fips910 Backport:release-fips900 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/54840 CI-Ready: Nicholas E. Bofferding CI-Ready: Marshall J. Wilks CI-Ready: Michael Baiocchi Reviewed-by: Nicholas E. Bofferding Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Reviewed-by: Marshall J. Wilks Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: ILYA SMIRNOV Reviewed-by: Daniel M. Crowell

Update utilDeallocateTces and other TCE Cleanup

2018-02-13T22:09:41+00:00

This commit removes the size parameter from utilDeallocateTces() as we should be able to use the token parameter to get back the saved size of the region. This commit also cleans up some other minor TCE issues and even fixes one I2C trace. Change-Id: I9ed5695d5ea13d89a22ace9593b5d9dc31a16736 RTC:168745 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53908 Reviewed-by: Nicholas E. Bofferding Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Reviewed-by: Marshall J. Wilks Reviewed-by: ILYA SMIRNOV Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

Add callout for unresponsive TPMs

2018-02-11T03:19:49+00:00

Adds a callout for TPMs that are unresponsive to i2c requests and lowers the processor callout priority to avoid recommending a processor replacement when it was the TPM that was unresponsive. Change-Id: Ia213183f2e93e3bd7e56e93c831ef52c28af31c4 CQ:SW415447 Backport:release-fips910 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53387 Reviewed-by: Michael Baiocchi Reviewed-by: Nicholas E. Bofferding Reviewed-by: ILYA SMIRNOV Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

I2C Reset Path: Add Poll of SCL High Before Issuing Stop Command

2018-01-26T22:03:43+00:00

At the end of the I2C reset sequence, a 'stop' command is sent to each port on the master that was reset. Before sending this 'stop' command, a poll has been added such to check that SCL (clock line) is high. This addresses a known issue with current TPMs. Change-Id: I13b199f5b4d10d7224d3ccc5d1a8baaecb4f2326 CQ: SW405816 Backport: release-fips910 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/52636 Reviewed-by: Christopher J. Engel Reviewed-by: Timothy R. Block Tested-by: Jenkins Server Reviewed-by: Nicholas E. Bofferding Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: William G. Hoffa

Update TPM Retry Policy and Timings

2018-01-25T14:05:18+00:00

This commit allows for all TPMDD errors to be re-tried (not just NACK errors) and adds a longer wait time between retries. Change-Id: Ibc38483881e710519f4a30cde5359c69fbbdaa62 Backport: release-fips910 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/52392 Reviewed-by: Timothy R. Block Reviewed-by: Christopher J. Engel Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Nicholas E. Bofferding Reviewed-by: William G. Hoffa

Set variables to nullptr after they are deleted

2017-09-25T15:54:57+00:00

While updating some LPC logic a developer noticed a bug where an errlog handle wasnt getting set to nullptr after it was deleted this caused a confusing bug that took awhile to track. I noticed that this bug was all over our code so this commit fixes a lot of cases where variables get deleted but not set to nullptr Change-Id: I103b5c71b93686c3c89b04d1d565a24d4de74e6f Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45890 Tested-by: Jenkins Server Tested-by: FSP CI Jenkins Reviewed-by: William G. Hoffa Tested-by: Jenkins OP Build CI Reviewed-by: Matt Derksen Tested-by: Jenkins OP HW Reviewed-by: Daniel M. Crowell