talos-hostboot/src/usr/console, branch 07-25-2019

sio: Add test for availability

2018-10-15T21:11:08+00:00

Some components can continue to operate in the face of the SuperIO controller being unavailable on the LPC bus (specifically, the UART and boot flag processing). Other components require it present (AST-based SFC implementations and the AST mailbox). Components in the latter category can just fail with an errl when they attempt to access the controller, but for those in the former category we add an isAvailable() function in the SIO namespace to sidestep dealing with errors. Specifically, isAvailable() tests for the expected error when the SuperIO controller is disabled, and returns an errlHndl_t if any other error occurs. This way true LPC errors are propagated to the caller to commit as desired. For the moment *all* errors produced by the SIO::isAvailable() LPC bus access will result in the SIO code assuming the device is absent. We should be more precise about this, but the hardware behaviour seen under hostboot currently prevents us from being more specific. This problem is highlighted by a FIXME block in the implementation of SIO::isAvailable(). Change-Id: Id30a09b48586d2054e0cdae625ee23df68ac2aa3 Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67460 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Corey V. Swenson Reviewed-by: Daniel M. Crowell

Revert "sio: Add test for availability - LPC error tweak"

2018-10-15T21:11:03+00:00

This reverts commit 627379aeaa27e30d66ebb0aecf218708d465162c, which incorrectly attempted to account for LPC errors during testing for SIO absence. The broken patch interprets the OPBM status as LPCHC status and expects an LPCHC SYNC Abnormal error, however as it's the OPBM status that indicates the error we never hit the LPCHC error path to populate the errl with the error RC expected by the SIO driver. Change-Id: Ib993d4a2b9b4e5018d9273a1c82f8b5c21ec9a25 Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67459 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

sio: Add test for availability - LPC error tweak

2018-10-11T22:53:08+00:00

Some components can continue to operate in the face of the SuperIO controller being unavailable on the LPC bus (specifically, the UART and boot flag processing). Other components require it present (AST-based SFC implementations and the AST mailbox). Components in the latter category can just fail with an errl when they attempt to access the controller, but for those in the former category we add an isAvailable() function in the SIO namespace to sidestep dealing with errors. Specifically, isAvailable() tests for the expected error when the SuperIO controller is disabled, and returns an errlHndl_t if any other error occurs. This way true LPC errors are propagated to the caller to commit as desired. Change-Id: Ib94ceabfd4f4e9c63c114cfe3db3c954dbb6d6e5 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67315 Tested-by: Jenkins Server Reviewed-by: ANDREW R. JEFFERY Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Corey V. Swenson Reviewed-by: William G. Hoffa

Additional tracing for shutdown events

2018-09-12T15:31:05+00:00

Hit an issue where a shutdown was called but all that is traced is a msgQ pointer. These traces should help associate the msgQ pointer to an actual task being shutdown. Change-Id: Ic22fdde1a146eec90f26d557e8af1ddec3c85c4e CQ:SW443508 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65464 Reviewed-by: Christian R. Geddes Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Corey V. Swenson Reviewed-by: Daniel M. Crowell

console: Fix whitespace in ast2400 initialize() method

2018-07-25T14:26:42+00:00

Change-Id: I2d6ae43f123f745ee64e59c12017f12d7593123b Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/62507 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Dean Sanner Reviewed-by: Nicholas E. Bofferding Disable-CI: Nicholas E. Bofferding Reviewed-by: Daniel M. Crowell

console: ast2400: Indicate SP has met configuration requirements

2018-07-25T14:26:37+00:00

If the service processor has pre-configured the hardware to the state required by the host firmware it can set a bit to indicate this. If the bit is set, avoid touching the UART configuration. Change-Id: I96d228b5d89749eb531522e4ae90396b47776c43 Signed-off-by: Andrew Jeffery Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/62506 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Reviewed-by: Dean Sanner Tested-by: Jenkins OP HW Reviewed-by: Nicholas E. Bofferding Disable-CI: Nicholas E. Bofferding Disable-CI: Daniel M. Crowell Reviewed-by: Daniel M. Crowell

New Global For Console Daemon

2018-06-19T21:36:31+00:00

This change implements a new global variable that indicates whether the console daemon has been started. This variable is checked in the doShutdown path prior to printing any console traces. There may be a situation very early in the IPL where we attempt to write to console before the console daemon has been started. This causes timeouts and IPL failures. Change-Id: Ibec90d2207e5db9ef3b9507503d1ea9e2eb7cf6d CQ: SW431130 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/60060 Tested-by: Jenkins Server Reviewed-by: Nicholas E. Bofferding Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Michael Baiocchi Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell

Fix memory leaks associated with various msg_sendrecv calls

2018-06-04T15:30:30+00:00

Change-Id: I30bb6627610391aea248d4a3c4d722ef1695b02f Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59677 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: ILYA SMIRNOV Reviewed-by: Michael Baiocchi Reviewed-by: Nicholas E. Bofferding

Increase UART delay based on some lab issues

2017-06-25T21:52:23+00:00

Merging in a patch that we've been carrying for a couple years now. Change-Id: Ia9b2ccbcdf63b8d52423e6ddcb250a033c7efaeb Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38117 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Reviewed-by: Matthew A. Ploetz Reviewed-by: Daniel M. Crowell

hostboot: Add a printed out banner add startup

2017-03-06T21:22:23+00:00

This better clarifies the ImageId immediately to the end user. Resolves #90 Signed-off-by: William A. Kennington III Change-Id: Ieab56b9d1902aebbbf9f4f093f0a4a13c41d81f7 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/37457 Reviewed-by: William G. Hoffa Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Reviewed-by: Dean Sanner Reviewed-by: Daniel M. Crowell