talos-hostboot/src/build/mkrules, branch 07-25-2019

Automatically include config.h

2019-12-06T16:28:47+00:00

Rather than having to remember to include config.h anywhere we reference a CONFIG variable (and usually forgetting), this adds it to the default compiler flags so that it gets included in every source file we build. Change-Id: I53622ab4d46c55d942e98cae6ec03049fd5b3d08 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87475 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Zachary Clark Reviewed-by: Roland Veloz Reviewed-by: Christian R Geddes Reviewed-by: Nicholas E Bofferding

New Optional Argument to PnorUtils.pm’s loadPnorLayout

2019-10-29T16:27:59+00:00

New Optional Argument to PnorUtils.pm’s loadPnorLayout to declare where to place the newly created layout file. If argument is not given, file will not be saved. Edited scripts and makefiles that use this function. Change-Id: I7b9ee0f7ad33ad88be58598ddf594765eabe29ea Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85916 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Nicholas E Bofferding Reviewed-by: Christian R Geddes Reviewed-by: Michael Baiocchi Reviewed-by: Daniel M Crowell

Compile Hostboot with -Os

2019-10-03T15:55:14+00:00

Hostboot currently spends a significant percentage of time loading data from PNOR across a relatively slow LPC bus. This commit enables compilation of Hostboot with -Os, optimized for space to reduce the amount of data required to be transferred across the LPC bus Rough measurements show a ~30% size reduction of the hostboot image and a ~10% reduction (improvement) in boot time Change-Id: Ib73863019595a24cc7d10e924bc5c92cd64af1ed Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84436 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: William G Hoffa

Patch For: Implement Static Analysis with cppcheck

2019-09-19T04:14:10+00:00

CPPCHECK commands fail in machines that do not use bin/sh. Wrap commands inside an if-statement to only be read when User explicitly run the tool. Change-Id: Ifad56b0978c8190efa033203f661daf9259a4d43 RTC: 201451 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83938 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Tested-by: Jenkins OP HW Reviewed-by: Daniel M Crowell

Implement Static Analysis with cppcheck

2019-09-11T15:53:06+00:00

Cppcheck static analysis tool can now be run when compiling by running: make cppcheck And it will always run when committing without stopping the commit if an error is found. This commit suppresses some false positives found in the code. A false positive can be suppressed inline by placing “// cppcheck-suppress syntaxError” in a line before the false positive., e.g.: char arr[5]; // cppcheck-suppress arrayIndexOutOfBounds arr[10] = 0; Change-Id: I9e833a153d6b04df2f8a72cd994e43922c61c2fe RTC: 201451 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/79629 Reviewed-by: Zachary Clark Reviewed-by: Nicholas E Bofferding Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M Crowell

Revert "Compile Hostboot with -Os"

2019-08-08T21:43:33+00:00

This reverts commit cd1e5c91e4a15ca933c699553ece9b841825ac03. The previous change seems to be causing problems with thread local storage (TLS) access. CQ: SW471547 Change-Id: Ic6f43fbba2a3d5abe94ea73e8e5fd03702b84365 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/81652 Reviewed-by: Daniel M Crowell Tested-by: Daniel M Crowell

Remove MVPD,MEMD and CENHWIMG section from Axone pnor layout

2019-07-30T20:19:58+00:00

This commit removes the MVPD, MEMD and CENHWIMG sections from the axone pnor layout as they are not being used and pnor space is limited. Along with removing the defintion in the pnor layout xml some code changes were required to no longer attempt to load the MVPD/MEMD sections. Change-Id: I20739e30ad497737c0a30b66cc36052c08c11de2 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80295 Reviewed-by: Glenn Miles Tested-by: Jenkins Server Reviewed-by: Matt Derksen Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M Crowell

Compile Hostboot with -Os

2019-07-25T18:59:23+00:00

Hostboot currently spends a significant percentage of time loading data from PNOR across a relatively slow LPC bus. This commit enables compilation of Hostboot with -Os, optimized for space to reduce the amount of data required to be transferred across the LPC bus Rough measurements show a ~30% size reduction of the hostboot image and a ~10% reduction (improvement) in boot time Change-Id: Ib140e6f07b112ae95a901f49b75416ef91c94a9d Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/79059 Reviewed-by: Nicholas E Bofferding Tested-by: Jenkins Server Tested-by: FSP CI Jenkins Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Zachary Clark Reviewed-by: Michael Baiocchi Reviewed-by: William G Hoffa

Update buildBpmFlashImages.pl to support configuration data binary generation

2019-07-23T16:43:16+00:00

Currently, buildBpmFlashImages.pl will only generate the firmware binaries for the BPM update for firmware versions less than 1.05. This commit adds support for the configuration portion of the update for version 1.05 and updates the script so that the generated firmware binaries are compliant with v1.05 requirements. Change-Id: I29b80b01fc8af85ffdefe8c4ad486206e557306e RTC:212446 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80198 Reviewed-by: Roland Veloz Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Matt Derksen Reviewed-by: Daniel M Crowell

Cache objdump output for build performance

2019-07-18T21:01:54+00:00

Hostboot uses the objdump tool to disassemble modules and the genlist program to create the listing files (*.list.bz2) for each binary blob generated by the build process (hbibl, hbicore, etc). The hundreds of objdump invocations account for a majority of the build time when recompiling hostboot after a small number of files have been changed because all the shared objects for a binary must be dumped again regardless of whether they have been modified. This commit causes the genlist program and the makefiles to cache the (compressed) disassembly when the BUILD_FAST flag is set so that only modified ELF files need to be redumped. Also several binaries include the same modules, which means that a given module may be dumped multiple times needlessly. Benchmarks for recompilation after modifying small numbers of files show at least a 5x speedup as compared with the original build system. Using BUILD_FAST comes with a cost of about 35 MB of disk space. When compiling all of hostboot (i.e. all libraries must be dumped), using BUILD_FAST is not slower than a vanilla build. The cached objdump output is stored in the img/objdump/ folder. Example: make BUILD_FAST=1 -j32 Change-Id: I65be7b29cec953950bfa664a5ee04e3a711007b5 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80115 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Reviewed-by: Luis P Fernandez Tested-by: Jenkins OP HW Reviewed-by: Nicholas E Bofferding Reviewed-by: Daniel M Crowell