talos-hcode/import/hwpf/fapi2, branch 03-26-2018

PM: Generation of summarized version of STOP Recovery FFDC.

2018-03-09T21:32:51+00:00

A summary of STOP recovery FFDC is created after generation of complete FFDC. It is stored at the end of FFDC section. It is intended for copying to an error log created during second phase of STOP Recovery. Commit also incorporates some changes to support creation of PM Display from STOP Recovery FFDC. Key_Cronus_Test=PM_REGRESS CQ: SW416531 Change-Id: I9e39e2ae9cfc7436464609e7884e1b3d9fd02c9f Original-Change-Id: Ieb0bceeb141cc80b18f63b01e881e5ad3b50263d Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/50414 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: Cronus HW CI Tested-by: HWSV CI Tested-by: Hostboot CI Tested-by: PPE CI Reviewed-by: AMIT J. TENDOLKAR Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA Reviewed-by: Gregory S. Still

multiple collectFfdc tags results in dupicate code

2018-03-09T21:32:49+00:00

-Updated parser to eliminate multiple calls when there are more than on collectFfdc tag in the hwpError section Change-Id: I04b485d7d232d65d9ba02add03d8ac0901872c7f RTC:179620 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45904 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: AMIT J. TENDOLKAR Reviewed-by: Prem Shanker Jha Reviewed-by: Jennifer A. Stofer

Update default case in set_sbe_error

2018-03-09T21:32:48+00:00

-Capture the ERRVAL as well as the FFDC buffer Change-Id: I7d15d3215c85128e98b188cf316a4e763448c074 RTC:169625 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45344 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Matt K. Light Reviewed-by: ARAVIND T. NAIR Reviewed-by: Sachin Gupta Reviewed-by: Jennifer A. Stofer

Update set_sbe_error macro exceeds line length

2018-03-09T21:32:46+00:00

-Undate macro to call a function for each RC value instead of inlining of all FFDC collection -Update parseErrorInfo.pl script to generate a new file which contains functions for use in new macro layout Change-Id: I40a02fef07b3618b137a8e0c2bfa10c9756da600 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/46719 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: HWSV CI Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: ARAVIND T. NAIR Reviewed-by: Sachin Gupta Reviewed-by: Jennifer A. Stofer

Power Cleanup + stopclocks

2018-03-09T21:32:46+00:00

Change-Id: I4d152dd6a04513a8e9cd024543aefd61c8fbbb95 Original-Change-Id: I4857b6e1264530a919afe8e75abe170ca0699d55 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/42571 Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Jennifer A. Stofer

Compile failure in cronus env

2018-03-09T21:32:44+00:00

-Added missing fapi2:: namespace qualifier to sbeFfdc_t Change-Id: I9f646c774994f8c456af2d8535a456fea6736c00 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/44055 Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Brent Wieman Dev-Ready: Brent Wieman Reviewed-by: Thi N. Tran Reviewed-by: Jennifer A. Stofer

B1814616 - hwsvd sig:11 core dump on zzfp247

2018-03-09T21:32:42+00:00

-Modified collectRegFfdc to skip register data if the passed in target pointer is null. -Added new RC to be used when we detect an invalid SBE ffdc buffer. -Updated parseErrorInfo.pl to genrate code to support logging the new error when an invalid pointer is detected Change-Id: I436de31738af3f2b93b5776d7ce1459c8664ebf1 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43707 Tested-by: Jenkins Server Tested-by: Hostboot CI Tested-by: PPE CI Reviewed-by: MURULIDHAR NATARAJU Reviewed-by: Sachin Gupta Reviewed-by: Jennifer A. Stofer

Adding a static method to get scom failure address

2018-03-09T21:32:41+00:00

Added a static method 'SBE_SCOM_FAILURE::get_address' to fetch scom failure address from SBE HWP ffdc data blob Change-Id: Iec5fc6c5eb8e1ad4dbb51805b8b6d4b2d7e5ecbd Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/42275 Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Santosh S. Puranik Reviewed-by: Sachin Gupta Reviewed-by: Prachi Gupta

Allow HWP to deconfigure parts without a callout

2018-03-09T21:32:40+00:00

Change-Id: I1a903257c8c87957ed1a1331aab0b6398e416def RTC: 174701 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41850 Reviewed-by: Martin Gloff Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Christian R. Geddes Reviewed-by: Daniel M. Crowell Reviewed-by: Jennifer A. Stofer

Enable and fix error log variable_buffer support.

2018-03-09T21:32:39+00:00

Errorlog support for the fapi2::variable_buffer type was not enabled in hostboot. Tests showed that when enabled, variable_buffer data was not being propagated properly to the error log. The issue was found to be that the pointer to the variable_buffer's internal data was not being properly passed to an ffdc_t object. Also, transferring the size of the variable_buffer data was not being correctly communicated to an ffdc_t object because a specialization of the getErrorInfoFfdcSize template function is needed. Becuase the specialization of the getErrorInfoFfdcSize function with an ffdc_t parameter did not exist, the code base used the primary function template for the getErrorInfoFfdcSize function which just returns the size of an ffdc_t object passed to it instead of the size of the contained data within the ffdc_t. Changes: * Added specialization of getErrorInfoFfdcSize for fapi2::ffdc_t. * Enabled variable_buffer support in parseErrorInfo.mk. * Added const overload of the pointer() method for the fapi2::buffer and fapi2::variable_buffer classes. This to allow these methods to be used in the set_BUFFER methods that take a const reference to objects of these classes. * Modified parseErrorInfo.pl to generate code to use the above mentioned pointer methods. The adjusted generated code fixes the problem of assigning an incorrect buffer pointer. Change-Id: I02d33fa346fe7797849a6e871572f26aca203dba Original-Change-Id: I96dc89fbb68ee6a153ca43191181c56804b84ae8 RTC: 175239 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41541 Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: William G. Hoffa Reviewed-by: Richard J. Knight Reviewed-by: Prachi Gupta