talos-hcode/import/hwpf/fapi2/include, branch master

Support for PPE commit 49883 to error out on non-TOR ring section.

2018-02-01T21:46:47+00:00

Change-Id: I7912c20e865aafe28c894bad98e4fbc3156d59ce Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/50107 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: HWSV CI Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Thi N. Tran Reviewed-by: Sachin Gupta Reviewed-by: Jennifer A. Stofer

fapi2: Fix template call sites for GCC 7

2018-02-01T21:46:00+00:00

The following errors stop hostboot from building with modern GCC: src/import/hwpf/fapi2/include/buffer.H:710:23: error: invalid operands of types ‘’ and ‘fapi2::bufferTraits::bits_type {aka unsigned int}’ to binary ‘operator<’ out.insert(iv_data); ~~~~~~~~~~^~~ src/import/hwpf/fapi2/include/buffer.H: In member function ‘fapi2::buffer& fapi2::buffer::flipBit()’: src/import/hwpf/fapi2/include/buffer.H:316:49: error: expected primary-expression before ‘)’ token iv_data ^= buffer().setBit(); ^ In both cases the call site needs to be prepended with the keyword 'template'. Otherwise the name is assumed to be a non-template (as per C++ 14.2/4). Change-Id: I925c35d51787c4f4f232372f0e1299ec2a5cab42 Signed-off-by: Joel Stanley Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/49760 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: HWSV CI Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Daniel M. Crowell Reviewed-by: ANDRE A. MARIN Reviewed-by: Jennifer A. Stofer

AVSBUS: Move fapi2 return code to error xml file

2017-10-23T23:59:31+00:00

- rebased Change-Id: I186e716986012ede094a09e490a983ddcb4b92ef Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43582 Dev-Ready: Brent Wieman Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Gregory S. Still

L3 Level changes in p9_avbus_lib.C

2017-10-23T23:28:12+00:00

Change-Id: Ifc24ad797b27dce520e4bd921958e74aff2b1192 RTC:165492 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/42702 Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: BRIAN D. VICTOR Reviewed-by: Brian T. Vanderpool Reviewed-by: AMIT J. TENDOLKAR Reviewed-by: Jennifer A. Stofer

Enable and fix error log variable_buffer support.

2017-10-23T22:50:28+00:00

Errorlog support for the fapi2::variable_buffer type was not enabled in hostboot. Tests showed that when enabled, variable_buffer data was not being propagated properly to the error log. The issue was found to be that the pointer to the variable_buffer's internal data was not being properly passed to an ffdc_t object. Also, transferring the size of the variable_buffer data was not being correctly communicated to an ffdc_t object because a specialization of the getErrorInfoFfdcSize template function is needed. Becuase the specialization of the getErrorInfoFfdcSize function with an ffdc_t parameter did not exist, the code base used the primary function template for the getErrorInfoFfdcSize function which just returns the size of an ffdc_t object passed to it instead of the size of the contained data within the ffdc_t. Changes: * Added specialization of getErrorInfoFfdcSize for fapi2::ffdc_t. * Enabled variable_buffer support in parseErrorInfo.mk. * Added const overload of the pointer() method for the fapi2::buffer and fapi2::variable_buffer classes. This to allow these methods to be used in the set_BUFFER methods that take a const reference to objects of these classes. * Modified parseErrorInfo.pl to generate code to use the above mentioned pointer methods. The adjusted generated code fixes the problem of assigning an incorrect buffer pointer. Change-Id: I96dc89fbb68ee6a153ca43191181c56804b84ae8 RTC: 175239 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41541 Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: William G. Hoffa Reviewed-by: Richard J. Knight Reviewed-by: Prachi Gupta

Add another writeBit API, modify getBit. Add unit tests.

2017-10-23T22:23:55+00:00

Change-Id: I9bd9efdc4b2c8a2eac26b7b1f1e1ef183d81f9b6 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38817 Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: STEPHEN GLANCY Reviewed-by: JACOB L. HARVEY Reviewed-by: Matt K. Light Reviewed-by: Thi N. Tran

Defining generic RingId_t type for transitional eCMD release

2017-10-23T22:17:36+00:00

Change-Id: Iaf9e18900517a18f0cbfa10c5a960e2d6adfeaff Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38403 Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Matt K. Light Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA Reviewed-by: Jennifer A. Stofer

SBE: Handle error part in putring code

2017-10-23T21:53:40+00:00

Change-Id: I11391e341b688a38a672a657494a5f1e29542489 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/33467 Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Sachin Gupta Reviewed-by: RAJA DAS Reviewed-by: PARVATHI RACHAKONDA

fapi2: Add helper classes for streaming data into/out of variable_buffers

2017-10-23T21:06:08+00:00

This adds buffer_stream.H which currently contains three classes: buffer_ostream - for streaming bits into a variable_buffer fixed_buffer_ostream - for streaming OT-sized chunks into a buffer fixed_buffer_istream - for streaming OT-sized chunks out of a buffer The classes keep track of the current write/read position so we don't have to drag that along with the buffers manually. There's no buffer_istream -- I didn't need that yet so haven't implemented it. Also adds tests to fapi2_variable_buffer_test.C. Change-Id: I53578d800c5c52c688bd761326b36a51c06dd213 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/25520 Dev-Ready: Joachim Fenkes Tested-by: PPE CI Tested-by: Jenkins Server Reviewed-by: Brian R. Silver Reviewed-by: Matt K. Light Reviewed-by: Jennifer A. Stofer

PutRing utils to scan rings

2017-10-23T21:04:30+00:00

Change-Id: Ieab183be571fda1013ef658568aee495c68c7100 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/21795 Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Michael S. Floyd Dev-Ready: Michael S. Floyd Reviewed-by: Claus M. Olsen Reviewed-by: Jennifer A. Stofer