talos-hcode/import/hwpf/fapi2/include/buffer.H, branch 06-18-2018

fapi2: Fix template call sites for GCC 7

2018-02-01T21:46:00+00:00

The following errors stop hostboot from building with modern GCC: src/import/hwpf/fapi2/include/buffer.H:710:23: error: invalid operands of types ‘’ and ‘fapi2::bufferTraits::bits_type {aka unsigned int}’ to binary ‘operator<’ out.insert(iv_data); ~~~~~~~~~~^~~ src/import/hwpf/fapi2/include/buffer.H: In member function ‘fapi2::buffer& fapi2::buffer::flipBit()’: src/import/hwpf/fapi2/include/buffer.H:316:49: error: expected primary-expression before ‘)’ token iv_data ^= buffer().setBit(); ^ In both cases the call site needs to be prepended with the keyword 'template'. Otherwise the name is assumed to be a non-template (as per C++ 14.2/4). Change-Id: I925c35d51787c4f4f232372f0e1299ec2a5cab42 Signed-off-by: Joel Stanley Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/49760 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: HWSV CI Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Daniel M. Crowell Reviewed-by: ANDRE A. MARIN Reviewed-by: Jennifer A. Stofer

Enable and fix error log variable_buffer support.

2017-10-23T22:50:28+00:00

Errorlog support for the fapi2::variable_buffer type was not enabled in hostboot. Tests showed that when enabled, variable_buffer data was not being propagated properly to the error log. The issue was found to be that the pointer to the variable_buffer's internal data was not being properly passed to an ffdc_t object. Also, transferring the size of the variable_buffer data was not being correctly communicated to an ffdc_t object because a specialization of the getErrorInfoFfdcSize template function is needed. Becuase the specialization of the getErrorInfoFfdcSize function with an ffdc_t parameter did not exist, the code base used the primary function template for the getErrorInfoFfdcSize function which just returns the size of an ffdc_t object passed to it instead of the size of the contained data within the ffdc_t. Changes: * Added specialization of getErrorInfoFfdcSize for fapi2::ffdc_t. * Enabled variable_buffer support in parseErrorInfo.mk. * Added const overload of the pointer() method for the fapi2::buffer and fapi2::variable_buffer classes. This to allow these methods to be used in the set_BUFFER methods that take a const reference to objects of these classes. * Modified parseErrorInfo.pl to generate code to use the above mentioned pointer methods. The adjusted generated code fixes the problem of assigning an incorrect buffer pointer. Change-Id: I96dc89fbb68ee6a153ca43191181c56804b84ae8 RTC: 175239 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41541 Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: William G. Hoffa Reviewed-by: Richard J. Knight Reviewed-by: Prachi Gupta

Add another writeBit API, modify getBit. Add unit tests.

2017-10-23T22:23:55+00:00

Change-Id: I9bd9efdc4b2c8a2eac26b7b1f1e1ef183d81f9b6 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38817 Tested-by: Jenkins Server Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: STEPHEN GLANCY Reviewed-by: JACOB L. HARVEY Reviewed-by: Matt K. Light Reviewed-by: Thi N. Tran

Modify freq & dep. files. Add cas latency & unit tests

2017-10-23T21:00:38+00:00

Change-Id: I205bf48e54fb3c8f19f973f58f8ec1d4c7345a23 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/22632 Tested-by: PPE CI Tested-by: Jenkins Server Reviewed-by: Brian R. Silver Tested-by: Hostboot CI Reviewed-by: JACOB L. HARVEY Reviewed-by: STEPHEN GLANCY Reviewed-by: Louis Stermole Reviewed-by: Jennifer A. Stofer

Fix mask calculation in buffer insert function

2017-10-23T20:53:46+00:00

Change-Id: Iec346df5b73f4e1796a73b1c6ac8fcebfcf58c4d Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/21589 Tested-by: Jenkins Server Reviewed-by: Sachin Gupta Reviewed-by: Brian Silver Reviewed-by: Jennifer A. Stofer

added plat_trace.H include for FAPI_ERR use in buffer.H

2017-10-23T20:51:54+00:00

Change-Id: If0a6884e7005022eb5e2730883e8c3bef16c95e3 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/21456 Tested-by: Jenkins Server Reviewed-by: Richard J. Knight Reviewed-by: Brian Silver Reviewed-by: Jennifer A. Stofer

fapi2 doxygen warning/error cleanup from ecmd repository

2017-10-23T20:51:52+00:00

Change-Id: I502a6f79f461632588b46e51d5892e2d6b74942d Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/20985 Tested-by: Jenkins Server Reviewed-by: Matt K. Light Reviewed-by: Brian Silver Reviewed-by: Jennifer A. Stofer

FAPI2 - Error/FFDC work related updates

2017-10-23T20:51:48+00:00

Change-Id: I2c153d4362791d885b85fee0f4891a9239c6aec7 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/19308 Tested-by: Jenkins Server Reviewed-by: Matt K. Light Reviewed-by: Richard J. Knight Reviewed-by: Jennifer A. Stofer

Fixed overflow problem in buffers

2017-10-23T20:51:43+00:00

Change-Id: Idb3349052373cedaa8955b530a00dd7a25e72122 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/20182 Tested-by: Jenkins Server Reviewed-by: Matt K. Light Reviewed-by: WILLIAM G. HOFFA Reviewed-by: Jennifer A. Stofer

made const extract methods

2017-10-23T20:51:14+00:00

Change-Id: I556f0028fcfae3b3d3892897edf8c853d8873660 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/18831 Tested-by: Jenkins Server Reviewed-by: Thi N. Tran Reviewed-by: Brian Silver Reviewed-by: Jennifer A. Stofer