talos-hcode/import/chips/p9/utils/imageProcs, branch 07-25-2019

Infrastructure support for new MC OMI rings for Axone

2018-08-22T22:56:05+00:00

Key_Cronus_Test=XIP_REGRESS Change-Id: I931305965d8f463233c5c30a3f561c93a4e2e08a Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/64115 Tested-by: Jenkins Server Tested-by: HWSV CI Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Anusha Reddy Rangareddygari Reviewed-by: SRINIVAS V. POLISETTY Reviewed-by: Jennifer A. Stofer

Cleanup: Updated Mvpd access function and removal of unused rings

2018-07-15T15:42:42+00:00

- Removed the function that converts the outdated RS4v2 header format to the current RS4v3 header format in the Mvpd accessor functions, mvpdRingFundFind(). This can be done since all Mvpd in existance on any of our supported P9 systems (i.e., >=P9N DD20) use RS4v3. - Removed two #R rings which are no longer supported since P9n DD10. Because these rings happen to be located at the end of the TOR instance ring sections, it will alter the image, but will not interfere with the traversing of the ringSection image due to the way chiplet and common/instance sub-sections are partitioned. Key_Cronus_Test=XIP_REGRESS Change-Id: I39740a099b224bfade8a97a057453b85498e5880 CQ: SW437855 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/62448 Tested-by: Jenkins Server Tested-by: HWSV CI Tested-by: Cronus HW CI Tested-by: Hostboot CI Tested-by: PPE CI Tested-by: FSP CI Jenkins Reviewed-by: Jennifer A. Stofer

Risk level 3/4/5 support: Step 2 - image update to TOR v7

2018-05-01T15:35:27+00:00

- This commit updates the image ring sections to TOR v7. - It will fail with EKB FSP CI until we include the prereq to the merged step 1 commit in PPE and HB. Key_Cronus_Test=XIP_REGRESS cmvc-prereq: 1053262 cmvc-prereq: 1053182 Change-Id: Ie7452fe42877297da4f0da5cd4e51c989b6ac28d Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57421 Tested-by: Jenkins Server Tested-by: HWSV CI Tested-by: PPE CI Tested-by: Hostboot CI Tested-by: Cronus HW CI Tested-by: FSP CI Jenkins Reviewed-by: James N. Klazynski Reviewed-by: Joseph J. McGill Reviewed-by: Jennifer A. Stofer

Risk level 3/4/5 support: Step 1 - backward compatibility and v6 image

2018-04-26T17:17:20+00:00

- Introducing RV_RL3/4/5 ring variant (RV) support for EC/EQ chiplets. - Dropping RV support for all chiplet's instance rings which saves 456 Quad bytes and 58 Nest bytes in Seeprom's TOR slots (compared to master). - Each additional risk level adds 144 bytes in Seeprom TOR slots. - Various changes to data names associated with ring variants to clarify that the notion of ring variants is now specific only to Common rings while Instance rings only have the BASE variant. - Also, removed backwards compatibility to TOR v5, i.e. from before we introduced RL2 in february. Assumption is that all images/drivers used in fips910/920 and OP920 are TOR v6. - This commit produces a TOR v6 image to ensure EKB FSP CI success. Key_Cronus_Test=XIP_REGRESS Change-Id: Icfcb1e68fd74a10ffc48ee7a5da528a8042ef3b1 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56973 Tested-by: Jenkins Server Tested-by: HWSV CI Tested-by: PPE CI Tested-by: Cronus HW CI Tested-by: Hostboot CI Tested-by: FSP CI Jenkins Reviewed-by: Kahn C. Evans Reviewed-by: James N. Klazynski Reviewed-by: Joseph J. McGill

Fix transposed memset arguments in p9_dd_add

2018-04-06T17:39:23+00:00

Change-Id: Ia0a0f185879cb090ffe5d5b68a166c76ea9f2b6c RTC:189887 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56279 Tested-by: Jenkins Server Tested-by: HWSV CI Tested-by: PPE CI Tested-by: Hostboot CI Tested-by: FSP CI Jenkins Reviewed-by: Claus M. Olsen Reviewed-by: Prachi Gupta Reviewed-by: Jennifer A. Stofer

Code restruct: ring_apply

2018-04-06T17:38:08+00:00

- Consolidating the three _image_ring_generation functions into a single shared, and renamed, ring_section_generation function, - Moving several data centric functions into common_ringId API, - Use of sizeof() instead of hardcoded assumptions about structure or data type sizes, - Renaming of variables which makes sense in the context of the scope of this commit, such as: - ringBuffer renamed to ringSection - ringBufSize renamed to ringSectionSize and type changed to uint32_t - Removes the backward compatibility to TORV3/V4 and now only works with latest TOR version, i.e. 6 at this point. About the Hw_ImageBuild_Prereq: - 51511 must have fully propagated into all repos and drivers used in FSP CI tests before this commit (43175) can be merged. 43175 removes the TORV3/V4 backwards compatibility to support TOR ring sections that have TOR level DD coordination. Key_Cronus_Test=XIP_REGRESS Change-Id: I0af25fa623c1c523eb0297e475066497787f3d15 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43175 Tested-by: Jenkins Server Tested-by: HWSV CI Tested-by: PPE CI Tested-by: Hostboot CI Tested-by: Cronus HW CI Tested-by: FSP CI Jenkins Reviewed-by: Prachi Gupta

Moving DD specific ring coord from TOR to XIP (step 2)

2018-03-22T19:08:33+00:00

Step 2 - Producing XIP coordinated DD packaging of the TOR ring sections. - Updated ring_apply to produce N number of DD specific .rings ring sections and which is then assembled using the DD container API. Key_Cronus_Test=XIP_REGRESS HW-ImageBuild-Prereq=42751 - 42751 must be fully merged in Cronus and HB before this commit (51511) can be merged. This is to avoid a Coreq situation. Change-Id: I2357e4aab29fa3b9b0ba0dc7eb1e463c95e237fa Original-Change-Id: I45a73848f3e8683aae9dcc26fcdf282259c38fcc Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/51511 Tested-by: PPE CI Tested-by: Jenkins Server Tested-by: HWSV CI Tested-by: Cronus HW CI Tested-by: FSP CI Jenkins Reviewed-by: Thi N. Tran Tested-by: Hostboot CI Reviewed-by: Jennifer A. Stofer

Additional risk level support - (step 1) Backward compatibility

2018-03-22T19:07:51+00:00

The purpose of this commit is to avoid a coreq situation by ensuring this commit is fully propagated through our repos and test drivers before introducing the change to the new HW image with two RLs. The commit enables simultaneous support for producing a HW image and retrieving rings from an image that has either one or two risk level (RL) rings in the .rings section. The commit however does NOT actually, yet, make any changes to the image which is the aim of the (step 2) commit 53292. Nor does this commit generate any raw ring files or process any RL2 level rings yet. Again this will happen in 53292. The commit also includes, - various related cleanups in data naming and ring file processing, - some data and invironment specific parts in ring_apply.C have been moved to common_ringId.C. Key_Cronus_Test=XIP_REGRESS HW-Image-Prereq=53292 - This commit (52659) must be fully merged before merging 53292. Change-Id: I6f0b9614f7f7fa8f79f6d180f10d260f99d52562 Original-Change-Id: I402d53c4a3ca6a084c958321069cc6f60e04ad24 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/52659 Tested-by: FSP CI Jenkins Tested-by: Cronus HW CI Dev-Ready: Joseph J. McGill Reviewed-by: Joseph J. McGill Tested-by: Jenkins Server Tested-by: HWSV CI Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Jennifer A. Stofer

Bug fix to TOR API to not check TOR header version against TOR_VERSION

2018-03-22T19:07:17+00:00

I'm removing this check because it is not a valid check for making a decision that the TOR header is invalid (it's still valid). CQ: SW416424 Change-Id: I2cdb78bc18a1fcc718038be41b2965255ba5d0de Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/54017 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: HWSV CI Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Sachin Gupta Reviewed-by: Thi N. Tran Reviewed-by: Jennifer A. Stofer

Fix to TOR API failure on 32b systems

2018-03-22T19:07:16+00:00

This fixes a bug wrt incorrect use of sizeof() on a pointer that only shows up on 32b system (but is luckily successful on 64b systems). Key_Cronus_Test=XIP_REGRESS Change-Id: I9f33c5728cb68acaeee55580c9f1c1b8743cbd8d CQ: SW412437 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53875 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: HWSV CI Reviewed-by: Sachin Gupta Tested-by: PPE CI Tested-by: Cronus HW CI Tested-by: Hostboot CI Reviewed-by: Thi N. Tran Reviewed-by: Jennifer A. Stofer