From cee280efb4397b8c6e08a33b5000b42c885325fd Mon Sep 17 00:00:00 2001 From: mmitchel Date: Sun, 23 Mar 2003 22:57:26 +0000 Subject: PR c/8224 * fold-const.c (extract_muldiv_1): Don't pass through type conversions when signedness changes for division or modulus. PR c/8224 * gcc.dg/20030323-1.c: New test. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@64760 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 6 ++++++ gcc/fold-const.c | 7 ++++++- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/20030323-1.c | 24 ++++++++++++++++++++++++ 4 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/20030323-1.c (limited to 'gcc') diff --git a/gcc/ChangeLog b/gcc/ChangeLog index fc8f41838f7..596e91e0984 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2003-03-23 Glen Nakamura + + PR c/8224 + * fold-const.c (extract_muldiv_1): Don't pass through type conversions + when signedness changes for division or modulus. + 2003-03-24 Alan Modra * config/rs6000/sysv4.h (ASM_OUTPUT_ALIGNED_BSS): Remove unnecessary diff --git a/gcc/fold-const.c b/gcc/fold-const.c index 7b051fa8a6e..0f9f3d419a5 100644 --- a/gcc/fold-const.c +++ b/gcc/fold-const.c @@ -4170,7 +4170,12 @@ extract_muldiv_1 (t, c, code, wide_type) /* ... or its type is larger than ctype, then we cannot pass through this truncation. */ || (GET_MODE_SIZE (TYPE_MODE (ctype)) - < GET_MODE_SIZE (TYPE_MODE (TREE_TYPE (op0)))))) + < GET_MODE_SIZE (TYPE_MODE (TREE_TYPE (op0)))) + /* ... or signedness changes for division or modulus, + then we cannot pass through this conversion. */ + || (code != MULT_EXPR + && (TREE_UNSIGNED (ctype) + != TREE_UNSIGNED (TREE_TYPE (op0)))))) break; /* Pass the constant down and see if we can make a simplification. If diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 05b170ca185..9db85358f04 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2003-03-23 Mikulas Patocka + + PR c/8224 + * gcc.dg/20030323-1.c: New test. + 2003-03-23 Roger Sayle * gcc.c-torture/compile/20030323-1.c: New test case. diff --git a/gcc/testsuite/gcc.dg/20030323-1.c b/gcc/testsuite/gcc.dg/20030323-1.c new file mode 100644 index 00000000000..8a563ec5eb2 --- /dev/null +++ b/gcc/testsuite/gcc.dg/20030323-1.c @@ -0,0 +1,24 @@ +/* { dg-do run } */ + +/* PR c/8224 */ +/* Contributed by Mikulas Patocka */ + +extern void abort (void); + +unsigned f (int x) +{ + return (unsigned) (x / 2) / 2; +} + +unsigned f1 (int x) +{ + unsigned xx = x / 2; + return xx / 2; +} + +int main () +{ + if (f1 (-5) != f (-5)) + abort (); + return 0; +} -- cgit v1.2.3