summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* * tracepoint.c (trace_save): Call the writer's start method.Keith Seitz2013-04-242-0/+6
|
* ld/Yufeng Zhang2013-04-244-10/+24
| | | | | | | | | | | | * emulparams/aarch64elf.sh: Define ELFSIZE=64. * emulparams/aarch64linux.sh: Ditto. * emultempl/aarch64elf.em (aarch64_elf_before_allocation): Replace elf64 with elf${ELFSIZE}. (elf64_aarch64_add_stub_section): Likewise. (build_section_lists): Likewise. (gld${EMULATION_NAME}_after_allocation): Likewise. (gld${EMULATION_NAME}_finish): Likewise. (aarch64_elf_create_output_section_statements): Likewise.
* bfd/Roland McGrath2013-04-242-1460/+1503
| | | | | | | | | | * elf32-arm.c (elf32_arm_allocate_plt_entry): If HTAB->nacl_p, allocate space for PLT header even if IS_IPLT_ENTRY. (arm_nacl_put_plt0): New function, broken out of ... (elf32_arm_finish_dynamic_sections): ... here. Call it. If HTAB->nacl_p, set up the PLT header in .iplt too. (elf32_arm_output_arch_local_syms): If HTAB->nacl_p, write a mapping symbol for the start of .iplt too.
* PR ld/15389Nick Clifton2013-04-242-0/+6
| | | | * scripttempl/avr.sc: Add .note.gnu.build-id section.
* 2013-04-24 Muhammad Bilal <mbilal@codesourcery.com>Muhammad Bilal2013-04-244-0/+21
| | | | | | | | | | | PR gdb/10462 * cli/cli-decode.c (lookup_command): Show an error if there is no space before argument. 2013-04-24 Muhammad Bilal <mbilal@codesourcery.com> PR gdb/10462 * gdb.base/setshow.exp: Add test case.
* oops - revert accidental commitNick Clifton2013-04-241-38/+0
|
* *** empty log message ***Nick Clifton2013-04-241-4/+7
|
* * ecoff.c: casting the return value of BFD_ALIGN to intNick Clifton2013-04-246-13/+51
| | | | | | * elf32-tic6x.c: removing unused variables * elf32-v850.c: redefine the type of a variable (int -> bfd_vma) * vms-alpha.c: initialize a variable
* *** empty log message ***gdbadmin2013-04-241-1/+1
|
* daily updateAlan Modra2013-04-241-1/+1
|
* * common/filestuff.c: Check USE_WIN32API before includingTom Tromey2013-04-233-4/+35
| | | | | | | | | | | sys/socket.h. (HAVE_F_GETFD): New define. (mark_cloexec): Check HAVE_F_GETFD. (gdb_open_cloexec): Change 'mode' to unsigned long. (gdb_socketpair_cloexec): Check HAVE_SOCKETPAIR. (gdb_pipe_cloexec): Check HAVE_PIPE. * common/filestuff.h (gdb_open_cloexec): Change 'mode' to unsigned long.
* merge from gccDJ Delorie2013-04-232-8/+29
|
* 2013-04-23 Hui Zhu <hui@codesourcery.com>Hui Zhu2013-04-234-2/+19
| | | | | | | | | | | | PR gdb/15293 * breakpoint.c (bpstat_what): Add BPSTAT_WHAT_SINGLE to bp_dprintf. 2013-04-23 Hui Zhu <hui@codesourcery.com> PR gdb/15293 * gdb.base/dprintf.exp: Add ignore command.
* 2013-04-23 Hui Zhu <hui@codesourcery.com>Hui Zhu2013-04-234-3/+30
| | | | | | | | | | | | | | PR gdb/15165 * breakpoint.c (dprintf_print_recreate): New. (save_breakpoints): Let it not save dprintf commands. (initialize_breakpoint_ops): Set dprintf_print_recreate. 2013-04-23 Hui Zhu <hui@codesourcery.com> PR gdb/15165 * gdb.base/save-bp.exp: Add test for dprintf.
* daily updateAlan Modra2013-04-231-1/+1
|
* *** empty log message ***gdbadmin2013-04-231-1/+1
|
* * gdb.gdb/selftest.exp (do_steps_and_nexts): Check forTom Tromey2013-04-222-0/+9
| | | | notice_open_fds.
* 2013-04-22 Jan-Benedict Glaw <jbglaw@lug-owl.de>Jan-Benedict Glaw2013-04-223-16/+11
| | | | | * Makefile.def: Sync with GCC. * Makefile.in: Regenerate.
* PR gdb/7912:Tom Tromey2013-04-2237-67/+583
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Makefile.in (SFILES): Add filestuff.c (COMMON_OBS): Add filestuff.o. (filestuff.o): New target. * auto-load.c (auto_load_objfile_script_1): Use gdb_fopen_cloexec. * auxv.c (procfs_xfer_auxv): Use gdb_open_cloexec. * cli/cli-cmds.c (shell_escape): Call close_most_fds. * cli/cli-dump.c (fopen_with_cleanup): Use gdb_fopen_cloexec. * common/agent.c (gdb_connect_sync_socket): Use gdb_socket_cloexec. * common/filestuff.c: New file. * common/filestuff.h: New file. * common/linux-osdata.c (linux_common_core_of_thread) (command_from_pid, commandline_from_pid, print_source_lines) (linux_xfer_osdata_shm, linux_xfer_osdata_sem) (linux_xfer_osdata_msg, linux_xfer_osdata_modules): Use gdb_fopen_cloexec. * common/linux-procfs.c (linux_proc_get_int) (linux_proc_pid_has_state): Use gdb_fopen_cloexec. * config.in, configure: Rebuild. * configure.ac: Don't check for sys/socket.h. Check for fdwalk, pipe2. * corelow.c (core_open): Use gdb_open_cloexec. * dwarf2read.c (write_psymtabs_to_index): Use gdb_fopen_cloexec. * fork-child.c (fork_inferior): Call close_most_fds. * gdb_bfd.c (gdb_bfd_open): Use gdb_open_cloexec. * inf-child.c (inf_child_fileio_readlink): Use gdb_open_cloexec. * linux-nat.c (linux_nat_thread_name, linux_proc_pending_signals): Use gdb_fopen_cloexec. (linux_proc_xfer_partial, linux_proc_xfer_spu): Use gdb_open_cloexec. (linux_async_pipe): Use gdb_pipe_cloexec. * remote-fileio.c (remote_fileio_func_open): Use gdb_open_cloexec. * remote.c (remote_file_put, remote_file_get): Use gdb_fopen_cloexec. * ser-pipe.c (pipe_open): Use gdb_socketpair_cloexec, close_most_fds. * ser-tcp.c (net_open): Use gdb_socket_cloexec. * ser-unix.c (hardwire_open): Use gdb_open_cloexec. * solib.c (solib_find): Use gdb_open_cloexec. * source.c (openp, find_and_open_source): Use gdb_open_cloexec. * tracepoint.c (tfile_start): Use gdb_fopen_cloexec. (tfile_open): Use gdb_open_cloexec. * tui/tui-io.c (tui_initialize_io): Use gdb_pipe_cloexec. * ui-file.c (gdb_fopen): Use gdb_fopen_cloexec. * xml-support.c (xml_fetch_content_from_file): Use gdb_fopen_cloexec. * main.c (captured_main): Call notice_open_fds. gdbserver * Makefile.in (SFILES): Add filestuff.c. (OBS): Add filestuff.o. (filestuff.o): New target. * config.in, configure: Rebuild. * configure.ac: Check for fdwalk, pipe2.
* 2013-04-22 Edjunior Machado <emachado@linux.vnet.ibm.com>Edjunior Barbosa Machado2013-04-222-3/+10
| | | | | | | * remote-sim.c (dump_mem): Change the type of 'buf' parameter from 'char *' to 'gdb_byte *'. (gdbsim_store_register): Change the type of 'tmp' from 'char' to 'gdb_byte'.
* 2013-04-22 Jan-Benedict Glaw <jbglaw@lug-owl.de>Jan-Benedict Glaw2013-04-223-0/+9
| | | | | * configure.ac: Sync with GCC. * configure: Regenerated.
* PR ld/15382Alan Modra2013-04-222-4/+10
| | | | | * elf-bfd.h (RELOC_AGAINST_DISCARDED_SECTION): Don't multiply sh_size or reloc_count adjustment by count.
* gdb/Yao Qi2013-04-222-1/+5
| | | | * infrun.c: Fix typo in comment.
* 2013-04-22 Sergio Durigan Junior <sergiodj@redhat.com>Sergio Durigan Junior2013-04-222-1/+6
| | | | | * gdb.arch/arm-bl-branch-dest.exp: Replace additional_flags by ldflags.
* Andrew Haley found a bug on GDB running on ARM when usingSergio Durigan Junior2013-04-225-1/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | --enable-64-bit-bfd. Basically the issue happens when dealing with "bl" instructions: GDB does branch destination calculation and (wrongly) sign-extends the PC. Here is a piece of his original message explaining the problem: > next_pc = arm_get_next_pc (frame, get_frame_pc (frame)); > > /* The Linux kernel offers some user-mode helpers in a high page. We can > not read this page (as of 2.6.23), and even if we could then we couldn't > set breakpoints in it, and even if we could then the atomic operations > would fail when interrupted. They are all called as functions and return > to the address in LR, so step to there instead. */ > if (next_pc > 0xffff0000) > next_pc = get_frame_register_unsigned (frame, ARM_LR_REGNUM); > > arm_insert_single_step_breakpoint (gdbarch, aspace, next_pc); > > Unfortunately, branch destination addresses are SIGN EXTENDED to 64 > bits. So, > > (top-gdb) p/x next_pc > $14 = 0xffffffffb6df2864 > > Which triggers the next_pc = get_frame_register_unsigned(), and we > cannot step into any branches because the destination PC is wrong. Anyway, the fix is simple and Andrew himself provided it for us. It took a while for me to figure out how to trigger the bug (in order to write a testcase for it), but I finally made it. The attached patch fixes the problem (by casting to `unsigned long' instead of just `long'), and also includes a testcase to reproduce the issue. gdb/ChangeLog: 2013-04-22 Andrew Haley <aph@redhat.com> * arm-tdep.c (BranchDest): Cast result as "unsigned long", instead of "long". gdb/testsuite/ChangeLog: 2013-04-22 Sergio Durigan Junior <sergiodj@redhat.com> * gdb.arch/arm-bl-branch-dest.c: New file. * gdb.arch/arm-bl-branch-dest.exp: Likewise.
* bfd/Alan Modra2013-04-2214-102/+124
| | | | | | | | | | | | | | | | | | | | | * elf64-ppc.c (ppc64_elf_check_relocs): Don't call create_linkage_sections here.. (ppc64_elf_init_stub_bfd): ..do so here. Return status. (create_linkage_sections): Move earlier in file. (ppc64_elf_setup_section_lists): Remove now useless htab->brlt test. * elf64-ppc.h (ppc64_elf_init_stub_bfd): Update proto. ld/ * emultempl/ppc64elf.em (ppc_create_output_section_statements): Check return from ppc64_elf_init_stub_bfd. ld/testsuite/ * ld-powerpc/tlsexe.d: Adjust. * ld-powerpc/tlsexe.r: Adjust. * ld-powerpc/tlsexetoc.d: Adjust. * ld-powerpc/tlsexetoc.r: Adjust. * ld-powerpc/tlsso.d: Adjust. * ld-powerpc/tlsso.r: Adjust. * ld-powerpc/tlstocso.d: Adjust. * ld-powerpc/tlstocso.r: Adjust.
* *** empty log message ***gdbadmin2013-04-221-1/+1
|
* daily updateAlan Modra2013-04-221-1/+1
|
* PR gold/15355Alan Modra2013-04-212-24/+32
| | | | | * layout.cc (Layout::segment_precedes): Allow more than one segment with the same type and flags.
* *** empty log message ***gdbadmin2013-04-211-1/+1
|
* daily updateAlan Modra2013-04-211-1/+1
|
* gdb/Yao Qi2013-04-202-2/+8
| | | | | | * ctf.c (ctf_fetch_registers): Change the type of 'regs' from 'char *' to 'gdb_byte *'. Cast the return value of 'bt_ctf_get_char_array' to 'gdb_byte *'.
* *** empty log message ***gdbadmin2013-04-201-1/+1
|
* daily updateAlan Modra2013-04-201-1/+1
|
* s/signness/signedness in gdbint.texinfo.Pedro Alves2013-04-192-1/+6
| | | | | | | | | | "signedness" is more typical. gdb/doc/ 2013-04-19 Pedro Alves <palves@redhat.com> * gdbint.texinfo (Misc Guidelines) <Compiler Warnings>: Write "signedness" instead of "signness".
* Enable -Wpointer-sign by default.Pedro Alves2013-04-195-9/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | This enables -Wpointer-sign by default. I've checked that --enable-targets=all builds fine with the following as --host, on x86_64 Fedora 17 --build: x86_64 GNU/Linux i386 GNU/Linux i386 MinGW-w64 i386 msdos/djgpp OK? gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * configure.ac (build_warnings): Replace -Wno-pointer-sign with -Wpointer-sign. * configure: Regenerate. gdb/doc 2013-04-19 Pedro Alves <palves@redhat.com> * gdbint.texinfo (Misc Guidelines) <Compiler Warnings>: Replace -Wno-pointer-sign text with text on -Wpointer-sign.
* 2013-04-19 Nathan Froyd <froydnj@codesourcery.com>Hafiz Abid Qadeer2013-04-192-0/+17
| | | | * ppc-instructions (isel): New instruction.
* Make GDB -Wpointer-sign clean on MinGW too.Pedro Alves2013-04-192-1/+9
| | | | | | | | | | | | | | | | | This is the remaining issue impeding GDB to build with "-Wpointer-sign -Werror" with Fedora 17's i686-w64-mingw32 cross toolchain. ../../src/gdb/ser-tcp.c: In function 'net_read_prim': ../../src/gdb/ser-tcp.c:341:3: error: pointer targets in passing argument 2 of 'recv' differ in signedness [-Werror=pointer-sign] In file included from ../../src/gdb/serial.h:23:0, from ../../src/gdb/ser-tcp.c:21: /usr/i686-w64-mingw32/sys-root/mingw/include/winsock2.h:983:34: note: expected 'char *' but argument is of type 'unsigned char *' gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * ser-tcp.c (net_read_prim): Cast second argument to recv to 'void *'.
* -Wpointer-sign: monitor.c.Pedro Alves2013-04-192-7/+17
| | | | | | | | | | | | | | | | | This fixes -Wpointer-sign issues in monitor.c. Tested by building on x86_64 Fedora 17 w/ --enable-targets=all. gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * monitor.c (monitor_write_memory, monitor_write_memory_bytes): Change type of 'myaddr' parameter to gdb_byte pointer. (monitor_write_memory_longlongs): Likewise. Cast 'myaddr' pointer to 'long long' pointer instead of to 'unsigned long long'. (monitor_write_memory_block, monitor_read_memory_single) (monitor_read_memory): Change type of 'myaddr' parameter to gdb_byte pointer.
* -Wpointer-sign: record.c.Pedro Alves2013-04-192-1/+6
| | | | | | | | | | | | | | | | | ../../src/gdb/record.c: In function ‘set_record_insn_history_size’: ../../src/gdb/record.c:670:5: error: pointer targets in passing argument 2 of ‘validate_history_size’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/record.c:646:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ ../../src/gdb/record.c: In function ‘set_record_call_history_size’: ../../src/gdb/record.c:682:5: error: pointer targets in passing argument 2 of ‘validate_history_size’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/record.c:646:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ This fixes it in the obvious way. gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * record.c (validate_history_size): Make parameter 'setting' unsigned.
* -Wpointer-sign: ctf.c.Pedro Alves2013-04-192-7/+13
| | | | | | | | | | | | | | | ctf_save_write's second parameter is gdb_byte *, and all these arguments are 'char *'. Since this function is ultimately just writing host bytes to a local file with fwrite, an alternative would be to change ctf_save_write to take a 'void *' instead of 'gdb_byte *', thus removing the need for any cast (we have more calls with casts than without). gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * ctf.c (ctf_write_uploaded_tsv, ctf_write_uploaded_tp): Add casts to 'gdb_byte *'.
* -Wpointer-sign: cp-valprint.c.Pedro Alves2013-04-192-1/+6
| | | | | | | | | | | | | | | | Fix: ../../src/gdb/cp-valprint.c: In function ‘cp_print_class_member’: ../../src/gdb/cp-valprint.c:793:3: error: pointer targets in passing argument 2 of ‘cp_find_class_member’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/cp-valprint.c:721:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ 'fieldno' is used throughout as 'int', so just follow the trend. gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * cp-valprint.c (cp_print_class_member): Change type of 'fieldno' local to int.
* -Wpointer-sign: ada-lang.c, ada-tasks.c.Pedro Alves2013-04-193-2/+8
| | | | | | | | | | | We're reading strings using the target memory access routines, which work with raw bytes, so we need a couple casts. gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * ada-lang.c (print_it_exception): Add cast to gdb_byte *. * ada-tasks.c (read_fat_string_value): Likewise.
* -Wpointer-sign: dwarf2-frame.c: Pass unsigned variable to safe_read_uleb128.Pedro Alves2013-04-192-3/+9
| | | | | | | | | | | | | | The 'bytes_read' change should be obvious. As for the other hunk, we're passing the address of the signed 'offset' to safe_read_uleb128, which expects unsigned. Fix it by passing the address of the unsigned 'utmp' instead, like already done on other spots in the file. gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * dwarf2-frame.c (execute_cfa_program): Make 'bytes_read' local unsigned. Pass 'tmp' to safe_read_uleb128 instead of the signed 'offset', and adjust.
* -Wpointer-sign: dwarf2read.c.Pedro Alves2013-04-192-2/+7
| | | | | | | | | | | | | | This fixes the remaining issues necessary to make the DWARF reader -Wpointer-sign clean. The 'filename' bit should be obvious. 'constant_pool' holds the contents of an obstack, which are 'char *'. gdb_byte would work too, but it'd need more casts elsewhere, so I just chose the minimal approach. Any way would be fine with me. gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * dwarf2read.c (dwarf2_get_dwz_file): Add cast to const char *. (read_index_from_section): Add cast to 'char *'.
* -Wpointer-sign: xcoffread.c.Pedro Alves2013-04-192-1/+5
| | | | | | | | | | | | | | | ../../src/gdb/xcoffread.c: In function ‘xcoff_initial_scan’: ../../src/gdb/xcoffread.c:2982:17: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign] 'debugsec' is a 'bfd_byte *', holding the result of a bfd_get_full_section_contents. 'info->debugsec' holds the same contents throughout the whole xcoff read, and everywhere it's used to read symbol names. Simply adding a cast feels appropriate. gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * xcoffread.c (xcoff_initial_scan): Add cast to 'char *'.
* -Wpointer-sign: coff-pe-read.c: treat strings in PE/COFF data as char *.Pedro Alves2013-04-192-3/+8
| | | | | | | | | | | A couple places take a pointer to the middle of some raw section buffer and treat them as strings. Add casts to char * as appropriate, fixing -Wpointer-sign warnings. gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * coff-pe-read.c (read_pe_exported_syms): Handle strings as char.
* -Wpointer-sign: bookmarks.Pedro Alves2013-04-193-6/+16
| | | | | | | | | | | | | | | | | Bookmarks are opaque to the core code -- by design, the target is free to use any sort of blob as bookmark identifier. The record target chooses to use strings for bookmarks. This adds casts following that direction, fixing -Wpointer-sign warnings. gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * record-full.c (record_full_get_bookmark): Change local 'ret' type to char * and add cast to gdb_byte *. (record_full_goto_bookmark): Handle 'bookmark' argument as a string. * reverse.c (goto_bookmark_command): Add casts to gdb_byte *.
* -Wpointer-sign: python/.Pedro Alves2013-04-194-7/+18
| | | | | | | | | | | | | | | | This fixes -Wpointer-sign warnings in the python/ code in the manner that seems most appropriate to me. gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * python/py-inferior.c (infpy_write_memory): Add cast to gdb_byte * python/py-prettyprint.c (print_string_repr): Change type of 'output' local to char *. Add cast to gdb_byte * in LA_PRINT_STRING call. (print_children): Change type of 'output' local to char *. * python/py-value.c (valpy_string): Add cast to const char * in PyUnicode_Decode call.
* -Wpointer-sign: remote-mips.c.Pedro Alves2013-04-192-15/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | remote-mips.c has a bunch of -Wpointer-sign warnings: ../../src/gdb/remote-mips.c: In function ‘mips_receive_packet’: ../../src/gdb/remote-mips.c:1128:7: error: pointer targets in passing argument 2 of ‘mips_cksum’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/remote-mips.c:830:1: note: expected ‘const unsigned char *’ but argument is of type ‘char *’ ../../src/gdb/remote-mips.c:1135:7: error: pointer targets in passing argument 2 of ‘mips_cksum’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/remote-mips.c:830:1: note: expected ‘const unsigned char *’ but argument is of type ‘char *’ ../../src/gdb/remote-mips.c: In function ‘mips_load_srec’: ../../src/gdb/remote-mips.c:2830:12: error: pointer targets in passing argument 4 of ‘mips_make_srec’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/remote-mips.c:134:12: note: expected ‘unsigned char *’ but argument is of type ‘char *’ ../../src/gdb/remote-mips.c: In function ‘pmon_zeroset’: ../../src/gdb/remote-mips.c:3030:3: error: pointer targets in passing argument 4 of ‘pmon_makeb64’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/remote-mips.c:2977:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ ../../src/gdb/remote-mips.c: In function ‘pmon_make_fastrec’: ../../src/gdb/remote-mips.c:3124:6: error: pointer targets in passing argument 3 of ‘pmon_zeroset’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/remote-mips.c:3025:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ ../../src/gdb/remote-mips.c:3126:4: error: pointer targets in passing argument 4 of ‘pmon_makeb64’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/remote-mips.c:2977:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ ../../src/gdb/remote-mips.c:3148:3: error: pointer targets in passing argument 3 of ‘pmon_zeroset’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/remote-mips.c:3025:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ ../../src/gdb/remote-mips.c:3153:3: error: pointer targets in passing argument 3 of ‘pmon_zeroset’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/remote-mips.c:3025:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ ../../src/gdb/remote-mips.c:3154:8: error: pointer targets in passing argument 4 of ‘pmon_makeb64’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/remote-mips.c:2977:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ ../../src/gdb/remote-mips.c: In function ‘pmon_load_fast’: ../../src/gdb/remote-mips.c:3423:2: error: pointer targets in passing argument 4 of ‘pmon_makeb64’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/remote-mips.c:2977:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ ../../src/gdb/remote-mips.c:3457:4: error: pointer targets in passing argument 3 of ‘pmon_checkset’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/remote-mips.c:3051:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ ../../src/gdb/remote-mips.c:3484:8: error: pointer targets in passing argument 3 of ‘pmon_zeroset’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/remote-mips.c:3025:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ ../../src/gdb/remote-mips.c:3489:3: error: pointer targets in passing argument 3 of ‘pmon_checkset’ differ in signedness [-Werror=pointer-sign] ../../src/gdb/remote-mips.c:3051:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’ The mips packet payload is ASCII, so it makes sense for mips_send_packet and mips_receive_packet to expose 'char *'-based interfaces, as currently they do. But, mips packets have a binary header, so if you look at e.g., mips_receive_packet's implementation, you'll see "unsigned char" buffers in use. I find it the most natural to make the payload pointer passed to mips_cksum 'char *' too. The other changes are straightforward adjustments -- a checksum is naturally unsigned, and there's one point where we're reading a bfd section. gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * remote-mips.c (mips_cksum): Rename 'data' parameter to 'datastr' and change its type to 'const char *'. Adjust. (mips_send_packet): Add cast to 'char *', and remove cast to 'unsigned char *'. (mips_receive_packet): Remove cast to 'unsigned char *'. (mips_load_srec): Use bfd_byte. (pmon_makeb64, pmon_zeroset): Make 'chksum' parameter unsigned. (pmon_checkset): Make 'value' parameter unsigned.
OpenPOWER on IntegriCloud