| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we don't protect against forwarding to remote
url, so things like:
https://<bmc-address>/#/login?next=http:%2F%2Fyahoo.com
can be used to forward an unsuspecting user to a different
url. This fixes that issue.
Tested: Local redirects still work, above link does not
Closes #109
Change-Id: I4d6c52880156802860f405af43037fb84235912f
Signed-off-by: James Feist <james.feist@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- New navigation provides intuitive structure for showing relationship
between sections and pages
- Menu keeps an open state, which allows easy clicking to sibling pages
- Ability to preview all page sections w/o hover over blocking page content
- Allows user to see where they are within navigation at all times
Tested: Opened each page and confirmed new navigation worked, clicked through
to all pages successfully.
Change-Id: Ie10dc95d8e15ee9bf89a3bec9ff231c0a7065ed9
Signed-off-by: Kathy Pine <kathryn.elainex.pine@intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
https://github.com/openbmc/openbmc/commit/19e81d3f3b731681a57bb5ef9681d33cc291bde8
restricts SSH authentication to only admin role users.
Updated the table.
Tested: Loaded on a Witherspoon
Change-Id: Ice5c93dc6dc4aa937de2c3fb9072c2f81719325c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://github.com/openbmc/bmcweb/commit/e9e6d240ab85e515f8d264e39b47a75043b73374
added a new user role, NoAccess.
https://github.com/openbmc/bmcweb/commit/cb3e11fadd77b04f5b26aefbde18411625e5e304
removed Callback.
This "NoAccess" role can not ssh, access Redfish, the D-Bus API, or
IPMI.
Tested: Loaded on a witherspoon.
Change-Id: I4f870fdefb5342344fd442876d671a59864bbf34
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Related to https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/27270
Currently the only condition checked when user is logged in was the
"LOGIN_ID" value in browser session storage. The only place in the code
where it is set is the Basic Authorization flow.
In case of mTLS authentication, we are not able to set session storage
value. This is why additional 'IsAuthenticated' cookie is added.
In the case when user session expires, the failing XHR should cause the
page to redirect to the login prompt. Additionally, IsAuthenticated
cookie is removed to disable redirection.
Tested: verified the flow with the mTLS changes. User is put in the
webUI interface without login prompt when using mTLS authentication. If
the authentication fails, browser redirects to the login page.
Signed-off-by: Wiktor Gołgowski <wiktor.golgowski@intel.com>
Change-Id: Ia7061f3e146c6547d4bfdf42940150b1a5c06903
|
|
|
|
|
|
|
|
|
|
| |
- Remove all references to the AuthenticationType property since our
request is a PATCH and we are not changing the value.
Resolves: https://github.com/openbmc/phosphor-webui/issues/102
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I911ac41bf61250847e4c308f09df8fd59dd27fa7
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So far the certificate table was not sorted and it happen that having
multiple certificates they appear on different table position after
machine restart.
That is because the Redfish was used to get the list of certificates
and it does not guarantee any order of elements in returned
collections.
After merging this commit certificates will be always sorted by:
type, issuer name and then by date.
Tested:
Manual tests were made to cofirm that certificates are properly sorted.
Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: Ie8e63d598cd04e2396ed09244a69284e49566f8d
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Created reusuable file upload component to be used on updated firmware page.
Component can:
-Upload file
-Display status icon
-Clear upload field
Made minor style change to file upload on certificate management.
Tested in GUI.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I09bf56eee4d670681ea5e95c1807f8177c0e4c08
|
|
|
|
|
|
|
|
|
| |
Loader was updated with loading icon svg. Added inline style
for loading icon and added loader svg to status-icon directive.
Status icons will be used in file-upload component for firmware page update.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I15e6f9fa39a08fcc8cfe354f8ed4447aab6425a9
|
|
|
|
|
|
|
|
|
| |
Removing margin offset to fix issue with button icons being
visually truncated on Safari. Removing additional redundant
code around same icon/buttons.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ie1ef89023a043a70a0126a21be57febb9afae19a
|
|
|
|
|
|
|
|
|
| |
This reusuable component will help to make sure banner
implementations are consistent and will help reduce
redundant code.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I3a16f65d36c2d61abf54c300e2ed5defeadee298
|
|
|
|
|
|
|
|
|
| |
Create reusable firmware card component that will be
used in the updated firmware page:
https://ibm.invisionapp.com/share/4XNZ0JAMJ7B#/screens/319212821_4-8-D-1_Home
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I86e526c59ac5c2e2c011aed0ce4bc3d82db63b5e
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When using the table component with table actions
enabled, if an icon file name isn't provided, the
action type should display in the table.
This will fix the webpack error when compiling the
table component without an icon to display by changing
the ng-if directive to check for falsy values instead
of just 'null' to also catch 'undefined' values.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I72daeb035e4e5f0391953f9f2ae042d0b9fc2b99
|
|
|
|
|
|
|
|
|
| |
A 10 second timeout was used as a tempoary work-around
before rebooting the BMC on the firmware page–removing
the timeout since it is no longer needed.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I6a95d5f5bb377d3fd3cc0802f7fb3d6d0f177870
|
|
|
|
|
|
|
|
|
| |
- Add password to the createLdapEnableRequest Authentication object to
be sent with the LDAP payload
- Add a Password to scoped ldapProperties object
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I63a880548bc3d9d61c4b73719457ce19222aa354
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With introducing option to add multiple certificates there is a need to give
user a possibility to remove selected certificates, for example when they
expire.
This commit adds implementation of DELETE function to GUI.
A new icon will appear in action section on certificate table.
The delete icon will be enabled only for TrustStore certificates and disabled
for others which does not have support for delete option.
When user clicks on the delete icon then ‘user prompt’ is displayed and after
confirmation, proper redfish action is used to delete the certificate.
Middlewere implementation is here:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/25281
Backend implementation is here:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-certificate-manager/+/25268
Tested on Chrome and Mozilla.
New icon appears in action section.
The delete option is available only for TrustStore certificates.
User is able to delete selected certificate.
Depends-On: I9781c5c79288ec5d080e80e42c63a55e471ddb77
Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: I68c5f54767d6982ae3cb00830b3a1b4f5e237bea
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When I originally wrote CSP into the webui files, I intended to drop it
into the HTML file so it could be removed from bmcweb. Unfortunately,
that plan doesn't fly, as the CSP headers in bmcweb need to remain for
non-html files.
This normally wouldn't matter, but a number of people utilize
BMCWEB_INSECURE_DISABLE_XSS_PREVENTION to run the webui locally and
debug a new webui patch from a working BMC. This causes the CSP headers
to conflict, and the browser to fail with a CSP error on connect-src
when debugging locally.
Removing the CSP section entirely from the webui resolves this, and
doesn't change functionality at all, as it's still covered in bmcweb.
Tested: Will verify on a real platform.
Verified that building the webui locally with the above bmcweb flag
allows the webui to launch correctly.
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: I60e5011361ec3ce1930249a20cf34480beb48a7f
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added new toast notification types, warn and info,
and updated visual styling. All toasts will need
to be manually closed by clicking the 'X' close icon,
except a success toast which will be dismissed
automatically after 10 secs.
- Small updates to critical and success/on icon
- Added new colors for toast status background colors
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I9077109042621b2d3346b4121d6344da502b6b26
|
|
|
|
|
|
|
|
|
|
|
| |
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/26156
is renaming the User role ReadOnly. Update the Roles table.
26156 needs to merge first.
Tested: Loaded on a Witherspoon.
Change-Id: I948a6287d2c447072d5c34595589387e127d59ac
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change applies global styles to improve
page layout consistency and modal management
- Adds page and section styles
- Removes unused styles
- Creates individual html files for modals
- Updates certificate modals to bootstrap modal
- Updates global styles for input file field in file-upload.scss
TODO:
- Update certificate table with table component in separate commit
- Update CSR modal to use global form-field styles in separate commit
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I9b800cb684740da1a9168294433e726efb0f9d0e
|
|
|
|
|
|
|
|
|
|
| |
object-mapper.md is moving under architecture/ as part of
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/26250/
26250 should merge before this is merged.
Change-Id: Ie2372690faf6af9629a15badccb4af31da9041bb
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding styles to make sure the Bootstrap tooltip
directive works by adding opacity to 'in' class that
is added to the tooltip when triggered. This commit
also includes additional custom styles to override
defaults.
We will need these styles to implement tooltips which
are included in upcoming changes like the firmware
page redesign.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I08e8f1f1762dcc24f8a803b87348a5bff25bd65b
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made height and width changes to icons on app header
and system overview to properly align icons in IE11.
Removes additional space in system overview quick
links.
Tested in Chrome, IE11, Safari, Edge.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I7ae24df3fe73ea3502565ed3ee2ccabb2506e098
|
|
|
|
|
|
|
|
|
|
| |
Added height value of 100% to nav-icon in order to properly align
in IE11.
Tested on Chrome, Firefox, Safari, Edge and IE11.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I66b2d4de1b67f546e0709eab70a780a297efbb7a
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This workaround is no longer needed with bmcweb.
curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [] }' \
https://${bmc}/xyz/openbmc_project/network/eth0/attr/NTPServers
See https://github.com/openbmc/openbmc/issues/3240
Tested: Built and loaded on a Witherspoon. Added, removed, and
edited NTP servers.
Change-Id: Ia106067a479c63a5761b1f62c624d3ccc6df55c7
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This workaround is no longer needed with bmcweb.
curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [] }' \
https://${bmc}/xyz/openbmc_project/network/eth0/attr/Nameservers
{
"data": null,
"message": "200 OK",
"status": "ok"
and actually casues an error now do to
https://github.com/openbmc/phosphor-networkd/commit/5fb6c33a49ee2b9718cc9ce0f921d3b6cf38a463
curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [""] }' \
https://${bmc}/xyz/openbmc_project/network/eth0/attr/Nameservers
"data": {
"description": "xyz.openbmc_project.Common.Error.InvalidArgument"
},
"message": "Invalid argument was given.",
See https://github.com/openbmc/openbmc/issues/3240
Tested: Built and loaded on a Witherspoon. Added, removed,
and edited DNS servers.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Change-Id: I278489a8c4682641b61a0e5ab08fd714603b0234
|
|
|
|
|
|
|
|
|
| |
Moved to the new associations interface here:
https://github.com/openbmc/openbmc/issues/3584
Tested: Loaded on a Witherspoon
Change-Id: I2065f0919c8cc9d9dd219a1f9d8d0fc75265fa6f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Logging moved over to the new Associations interface here:
https://github.com/openbmc/phosphor-logging/commit/27d82814c3e79865221f599b98ce069c31c4d60a
Without this change was seeing:
TypeError: "r.data[h].associations is undefined"
getLogs https://w81.aus.stglabs.ibm.com/app.bundle.js:41
d https://w81.aus.stglabs.ibm.com/app.bundle.js:6
d https://w81.aus.stglabs.ibm.com/app.bundle.js:6
$digest https://w81.aus.stglabs.ibm.com/app.bundle.js:6
$apply https://w81.aus.stglabs.ibm.com/app.bundle.js:6
y https://w81.aus.stglabs.ibm.com/app.bundle.js:6
C https://w81.aus.stglabs.ibm.com/app.bundle.js:6
onload https://w81.aus.stglabs.ibm.com/app.bundle.js:6
Possibly unhandled rejection: {}
Added an hasOwnProperty before the foreach.
Tested: No longer see the error. See the "Related items:" on the
event log panel.
Change-Id: I60be885feea72b1388b7cbf4c3a7b9df7dbb9a02
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added a call to reload the route in the promise success callback. This
assures that a newly added manager has a path.
- Update the use of var in for blocks to scope the variable to the
block rather than overwriting the i variable that is hoisted and
scoped to the setSNMP function.
- Change i variable name to managerLength to improve readability
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I18fe9ecc3ca7cca29781a5c24caca73bda71ee43
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If an image fails to activate a toast message is displayed.
Tested on Witherspoon with master build image and
field mode turned on. When image fails to activate,
the failed activation status response returns a 200
ok and an error toast is displayed. Tested with field
mode turned off to verify image activates and BMC reboots.
Tested on all browsers.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I517f184549673e7b807cc0a553a728d05d6dbba1
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add check for gateway value before testing if the string is valid.
The backend seems to handle an empty gateway the same as sending
0.0.0.0. When the GET call is made after sending 0.0.0.0 as the
gateway value, the response returns an empty string. This field
seems to be an override for the default gateway input for the
interface.
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Id6a5575e73a7c8adfff052c89bb4e8ca986d45f9
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a service is enabled, it must be disabled prior
to changing the service type, e.g change from OpenLDAP
to ActiveDirectory.
- Add check to determine if a service is already enabled
- Make two calls if service is already enabled. First to
disable existing service. Second to enable updated
service
- Remove toast message for ssl check and replace with
error message which also keeps submit button disabled
if the regex pattern is not met
Tested:
- Edge
- Safari
- Firefox
- Chrome
- IE 11
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I195eeb7d1cd3621681c18f4dd9aa4414eb079c09
|
|
|
|
|
|
|
|
|
| |
There were a few instances of the icon-warning icon that didn't
include the file extenstion needed to when adding the file attribute
property in the icon directive.
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ib25c28c72285fa214f75258b0b09790d52bb6cc1
|
|
|
|
|
|
|
|
|
|
|
| |
The current event log search doesn't match inputs like
the event id, severity or priority.
This commit will add additional searchable log properties
to the search filter so users can enter search terms like
'High' or 'Error' or other visible keywords.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I569112468a9f97034449799f407137f1651cec16
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Adds heading with new layout consistency class name
-Adds open in new window functionality
Resolves: openbmc/phosphor-webui#81
Tested on a Witherspoon with power on and with build
that allows up to 4 kvm sessions connected
at a time https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/25231.
KVM console loads in firefox, chrome, safari, edge and IE11.
Opening new window and returning to parent window is
functional across all browsers.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I32cda025bdd459740ca2b42d573b431fac687860
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When time mode is initially set to Manual from NTP,
NTP service is disabled and the NTP service is stopping
but not stopped, setting time will return an error.
There are no response messages to notify when
NTP is completely stopped.
To work around, a timeout is set to allow NTP to fully stop
before saving date/time changes.
https://github.com/openbmc/phosphor-time-manager/blob/master/README.md
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: Icb86dfe339a10567aecf9aedd9b0dd696937a398
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The TrustStore should be used to hold TLS certificates, but current
TrustStore implementation does not support multiple certificates.
This GUI change should allow users to add more than one certificate
to TrustStore managed by OpenBMC.
Tested: GUI tests were done on Chromium v74.0.3729 browser.
It is possible to add multiple TrustStore Certificate
and only single LDAP and HTTPs certificates.
Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: Ia7c8400d039e980ad3d1c2cfd25aa7e29699d683
Depends-On: Icd33723c1fc2580679aaaf54b3e99dfb09342402
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss files.
- Moved/removed on, off, critical, warning svg icons from
assets directory
- Updated background-image status icons to use <icon>
or <status-icon> directive
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ic0f06d78b0861d6f60d40b2dcc0b80fd6dad2a88
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "Callback" role currently is an IPMI access point, can ssh
to the BMC, and is a Readonly user in Redfish and the WebUI.
Added a TODO to revisit this.
See:
https://github.com/openbmc/bmcweb/commit/88e097c4cfa1172504d802e9f6b327f095f2748e
Tested: Loaded on a Witherspoon. Now see checkmarks for Callback
in the following rows: Log in to the service and read
resources, IPMI access point, Redfish access point, SSH
access point, and WebUI access point.
Change-Id: Ica4863b1a424d0b115fb48b988c712fe27c99d74
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clicking the refresh button in the app header on the SoL and
KVM pages would fail to reload because the wrong element reference
is passed to the contructor after the reload. Angular recommends
using directives for any DOM manipulation.
- Use the $element ref availble in serial-console.js directive to
select DOM element to open the terminal
- Switch kvm controller to directive to be able to use element ref
in the link function to select DOM element to pass as target
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ia7391e42bf335b8c3558d25df15c052db245ee3d
|
|
|
|
|
|
|
|
|
| |
The current submenu navigation expanstion is too fast.
This commit will change the speed from 110ms to 400ms
and change the timing function from ease to cubic-bezier.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Iec1b9ac9dd19aa8ef43bf1845ab4f1d259b9ef0b
|
|
|
|
|
|
|
|
|
| |
Add 'btn' class on Reboot and Shutdown buttons on
power operations page to make sure borders aren't
rounded.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I3369acd52ad1992d4340ef6c194b81b5dc0ce001
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Fixes accessibility issues for table sort buttons,
fieldset legend, checkboxes and radio buttons
-Fixes tabbing to checkboxes
-Stops tabbing to disabled sort buttons by adding ng-disabled
-Removes aria-hidden from modals
Tested: Verified no violations using DAP tool.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I9ad240d5ed151a362c0000fdab3ebf1f2997b226
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Changed the section name to be access-control
- Moved LDAP Settings and Certificate Management to access-control navigation
- Changed Manage User Account subsection name to Local User Management
Resolves: openbmc/phosphor-webui#619
Signed-off-by: Mira Murali <miramurali23@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I0d94c80c295b997d94c04330fd87f4fc4d229bf8
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds LDAP page and ability to add and change configuration settings.
Adds ability to add, remove and edit user groups for LDAP.
Resolves openbmc/phosphor-webui#38
Resolves openbmc/phosphor-webui#39
Tested: Loaded on to a witherspoon and able to add initial LDAP config
as well us update the configuration and role groups. Appropriate messages displayed
to user when required fields are missing or in the incorrect format.
Change-Id: If8a21f3f9d9334415ead73472e90b2a0823bf9ea
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a user changes the boot setting override option
to 'None' on the Server power operations page, the
Enable one time boot checkbox should not be checked and
'Pending one time boot' message should not be displayed.
- Removed duplicate id and unused ng-change attributes
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ia8771c2984fe41c64dde9b0c702b82a3d8305d7f
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Updated filters to use semantic markup (fieldset)
- Added check for input date type support and updated
expected date format to the legend
- Added error message if date format is invalid
- Updated layout to support error message
Tested the changes in the following browsers:
- Safari
- IE 11
- Chrome
- Edge
- Firefox
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: If0b874644b80640dc5bfd8211459c012807ea492
|
|
|
|
|
|
|
|
|
|
| |
Add ability to remove, enable, disable local users in bulk.
- Updates to table-actions component to fix flickering issue
by including track by $index in ng-repeat
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I67039e9b9d9cf7debe9f6ef87e71210bd4b64251
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes aren't currently implemented on any table.
It will be added to event logs and local user table.
- Create tableCheckbox component to handle custom styles
and indeterminate state which needs to be set with JS
- Update tableComponent layout to allow transition for
toolbar. Updated user-accounts layout and styles to
account for these changes
Tested on Chrome, Safari, Firefox, Edge, IE
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ic57a090db1ef66f9d33facfdc425db868ae8d8c6
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was not used anywhere.
https://github.com/openbmc/phosphor-webui/search?q=warn-slash.svg&unscoped_q=warn-slash.svg
This image was already not in the build. I.e. it was not
at /usr/share/www/app/assets/images/.
Tested: Built the GUI. Looks good.
Change-Id: Ieaacef83baf8c943f4f7679763af1529acd52720
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|