| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| |
|
|
|
|
|
|
|
|
| |
For accessibility reasons, 'role="alert" is required for toast
messages. This notifies screen readers that an error or success
message has appeared. Adds a service layer for toast messages
that adds the role attribute to the message.
Change-Id: Ic4dbf5556337eea589de5692c1b4c3323e771813
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using ngMessages, adds form validation to login page. Also creates a
directive, hasError, to be used to validate form field by passing
in a boolean. This is a proposed pattern to be used moving forward,
as form validation is added to additional pages.
Validation error messages are shown on $touched and on submit.
Unreachable Server and Invalid username and password error messages
remain until input is no longer $pristine after form submission.
In addition, this removes unneeded and unused css styling
Resolves openbmc/phosphor-webui#47
Change-Id: I7a067af67ac74d4cf2977d10f66445720ecae9eb
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
|
|
| |
Makes the table header in sensor page stay fixed after scrolling.
Fixes the allignment of filter button.
Resolves openbmc/phosphor-webui#28
Change-Id: If9b8b0848169b5924b811e67588ff57c8dae7c5c
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
| |
|
|
|
|
|
| |
Replace error and success messages with toast notifications.
Change-Id: I6c68568b7c9db4fd1f85b3de843289cf1bfba376
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Design team proposed that our error and success messages be
delivered as 'toast' messages on the right side of the screen.
This brings in ngToast and implements notifications on SNMP page.
Notifications will fade after 10 seconds or can be dismissed.
https://github.com/tameraydin/ngToast
Change-Id: I1053534cd1ab189ae5c2ac07e2a922acea231c70
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On the Server power operations page, need a width: 100% for the
"Select a power operation" header.
Drop "Row" from power operations div to fix confirm modal being
cut off.
These are needed because of the move to Bootstrap 4.
84e114a
Resolves openbmc/phosphor-webui#51
Change-Id: I7250daf2aed4ce5af7ed5acdf61a65cc38deac72
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bootstrap < 4.1.2 has the following CVE:
https://nvd.nist.gov/vuln/detail/CVE-2018-14041
Removed bootstrap-theme.css due to "Replaced the separate optional
theme with configurable options via SCSS variables
(e.g., $enable-gradients: true)."
Added "width: 100%" to a few places where width 100% was no longer
getting inherited.
Moved a few elements and adjusted styles to get the same look as
before.
See https://getbootstrap.com/docs/4.0/migration/ for more
information.
Tested: Manually on a Witherspoon.
Change-Id: I0a72665ac1ca6eacd0b553a585b1fb15e14ae62c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allows user to display events in their timezone or in UTC.
Previously allowed either ETC or UTC, but listed ETC as
'user timezone'. Updates date time page from GMT offset to
UTC offset for overall consistency. Also updates overview
page to list critical events in user timezone
Resolves openbmc/phosphor-webui#36
Tested: changed timezone settings locally and validated
that correct timezone and UTC offset was presented in
the UI.
Change-Id: I89ca5045eeb789527aa07f5b1baebaa3fbd6b1fa
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
|
| |
-Changing the hover color to be white as
hover and selected states need to look
different.
Change-Id: I65a201b127408a698e50563f2b555fd5c55935dd
Signed-off-by: Ryan Arnell <iffy.ryan@ibm.com>
|
| |
|
|
|
|
|
|
|
| |
Make a REST call to set the MAC address when the
"Save Settings" button is pressed.
Tested: Verified the MAC Address is set.
Change-Id: I39f6d4688842b3453fd219795d07f819ba4ba481
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
| |
No reason to manage a version number separately from the overall
project. Remove the version and rename the element.
Based on feedback on https://gerrit.openbmc-project.xyz/#/c/10364/.
Change-Id: I055445db8bdda36dc408c057132e6e69b8935a6b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
If either TFTP Server IP Address or File Name is empty for the
"Download image file from TFTP server" function, return and
display an error.
Tested: Verified I see this error if either field is empty.
Change-Id: I3da3353dad7cfb0f765d8a662412c3adb3fa4efd
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
| |
Resolves openbmc/openbmc#2894
Tested: Running GUI locally and verified the new texts. Also made sure that
value truncation is not happening.
Change-Id: Ic3947b36ef83fe5cb37190a848c85156cc072afd
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
|
| |
|
|
|
|
|
|
|
|
| |
When a modal is active make it blocked so it can be viewed.
The modals such as confirming activating an image were not
visible. This change makes those modal visible when active.
Tested: Activated several images on a Witherspoon system.
Change-Id: I6667af017ea397344df6b6ed7e08949ffb4a3c55
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Move from gulp server to webpack. This allows the proper
compression to allow the webui to be embedded in the BMC.
2. Update js paths to use requires, not hardcoded paths. This was
required to make the packaging work correctly.
3. Add babel config to do translation.
4. Update angularjs directive calls to use the angular 1.6 syntax for
promises intead of success and fail.
https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$http
5. As a consequence of using NPM/webpack, the versions of angular and
associated modules that were checked in have been updated.
Change-Id: Icb71e2eedb0d9a8943fc914f9dc4be11d0983c00
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
| |
|
|
|
|
|
| |
Updating images and styles after code merge conflicts
Change-Id: I96490926caa41d13e4d625ff67f6a463d7819d34
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
| |
|
|
|
| |
Change-Id: Ie5bd4342fde5809a9ad793bfedf9079b0758de59
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Id4a783d23e18be74048540310523079ec5613e8e
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
|
|
|
| |
- fixed header slider position
- decreased size of main nav buttons based on user feedback
Change-Id: I86f6d2c448352c820e843837368c74407c00ec90
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I9d2895170c50c77b1cbf12fcc069492c9764c88a
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Icfdf19205bc4123ebd1bea086f01323ec41b4685
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I0b2ee399243f0bc3e5ed44bc578a0d153486ed55
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
| |
|
|
|
| |
Change-Id: Id97de89d646bc0c980fd4f0849109047906383e1
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
|
|
| |
in/out.
Change-Id: I9942715f424b0e79196916551d161ccdbf94b7bf
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Idc6930c87f61217f9bf4daab5b82c418606cdf80
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Ib2d1caf520302555b3bfb7b49cb69ae68b6bcfa8
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I7d6633ed965693f92bebddb88a5f081102090bdd
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I2dd38d805ace1e7c8d3141a9858072df5c342331
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
|
|
|
| |
- added aria-hidden = "true" to prevent icons to be read by screen readers
- moved code on pages into "page-header" for better consistency
Change-Id: I3f497b2707991f7f628892a05734eea183a0d01d
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Ie11792db8bedbf693ba5eea87f84b282a878a16a
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I1722a4fbd1e9ac07162c9732d68dfea283a28aed
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Ibea933c20071cc85201420ba1e31fedf9356f55b
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
| |
|
|
|
| |
Change-Id: Id4f8d96b10e429ca469c6169741588dbcc4b5c7a
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
|
| |
|
|
|
|
|
|
|
| |
- changed buttons to spans since not being used in forms
- added aria roles to html elements
- changed low contrast colors
Change-Id: I56e784b226baa7f9b24346446a0a023fcea633d4
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Id8c890714d0a90ae913b6581cd655abcf6cd6781
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Iad633b0986bf37ce63943ab64fdc3279bd419180
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
|
|
|
|
|
| |
- Changed "page last refreshed" label to "Data last refreshed"
- Changed "Configuration" label to "Server Configuration"
- adding flashing of header timestamp on click of "refresh" button
- moved "Server LED" under Server Configuration
Change-Id: I9971fd96da94514a7edc8e4977591c4de85f70c9
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Ia64dfd7ae7e1fb3081d0d5de680b9afa3cab669d
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: If3730f75e796f8f48fd036234711efa23e23f794
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: If77d9119bc9335b5bd5e94ec1d201f6aa8969d0d
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: If46c5dfa5656948747cbf4f2faacab9244f8e40c
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I222d6043a1f3fdddb1c6e8aef190b15a00aea2d6
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I13bae30e86330a8831d35f1d8a2f7da821324e37
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Ife1b7e691f5fcf023616b9151cff6598d346c2c4
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I9a9aa63802beac60a30e35a130a7ad73a3e80f0f
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
|
|
|
| |
- Added clear button to clear input
- changed submit to resize based on content
Change-Id: Ida69f961effc261dc44319ba8710d9b4349ba847
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Ib932b23aa891a1dd3ad3942dc9c8fbcf94f87f2b
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Iedcaaf71a2ac48eb885ac92d9efee0623e949289
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Idc1607033c277eb9a9a278614cc23b4c3d600dd3
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I73c423b867dfd5d4fadfe5bc8d2d6f30d1f632e8
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|