summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Update boot override UI messaging visibilityYoshie Muranaka2019-09-252-5/+21
| | | | | | | | | | | | When a user changes the boot setting override option to 'None' on the Server power operations page, the Enable one time boot checkbox should not be checked and 'Pending one time boot' message should not be displayed. - Removed duplicate id and unused ng-change attributes Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ia8771c2984fe41c64dde9b0c702b82a3d8305d7f
* Add error messaging for error log date filtering and Safari supportDerick Montague2019-09-253-61/+108
| | | | | | | | | | | | | | | | | | - Updated filters to use semantic markup (fieldset) - Added check for input date type support and updated expected date format to the legend - Added error message if date format is invalid - Updated layout to support error message Tested the changes in the following browsers: - Safari - IE 11 - Chrome - Edge - Firefox Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: If0b874644b80640dc5bfd8211459c012807ea492
* Add batch actions to local user tableYoshie Muranaka2019-09-246-26/+112
| | | | | | | | | | Add ability to remove, enable, disable local users in bulk. - Updates to table-actions component to fix flickering issue by including track by $index in ng-repeat Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I67039e9b9d9cf7debe9f6ef87e71210bd4b64251
* Add batch action functionality to table ComponentYoshie Muranaka2019-09-2410-136/+590
| | | | | | | | | | | | | | | | These changes aren't currently implemented on any table. It will be added to event logs and local user table. - Create tableCheckbox component to handle custom styles and indeterminate state which needs to be set with JS - Update tableComponent layout to allow transition for toolbar. Updated user-accounts layout and styles to account for these changes Tested on Chrome, Safari, Firefox, Edge, IE Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ic57a090db1ef66f9d33facfdc425db868ae8d8c6
* Remove unused image warn-slash.svgGunnar Mills2019-09-241-1/+0
| | | | | | | | | | | | | This was not used anywhere. https://github.com/openbmc/phosphor-webui/search?q=warn-slash.svg&unscoped_q=warn-slash.svg This image was already not in the build. I.e. it was not at /usr/share/www/app/assets/images/. Tested: Built the GUI. Looks good. Change-Id: Ieaacef83baf8c943f4f7679763af1529acd52720 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused image crit-x.svgGunnar Mills2019-09-241-1/+0
| | | | | | | | | | | | | This was not used anywhere. https://github.com/openbmc/phosphor-webui/search?q=crit-x.svg&unscoped_q=crit-x.svg This image was already not in the build. I.e. it was not at /usr/share/www/app/assets/images/. Tested: Built the GUI. Looks good. Change-Id: I7650a8866745eae0a7ef789bd63ab94e4ec18ef2 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Move Virtual Media files and routeGunnar Mills2019-09-249-12/+12
| | | | | | | | | | | | | | | "Virtual media" was already part of the "Server control" submenu but the files were at app/configuration and the route was /configuration. Marta Mazur did a similar file and route move here as part of supporting multiple Virtual Media endpoints: https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/25218 Tested: Built and loaded on a Witherspoon. The VM route is now: #/server-control/virtual-media. Was able to use the VM panel. Change-Id: Iec46a8ece7ddfbc356bc1e71875def70c4418027 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove Purpose property from inventory itemGunnar Mills2019-09-241-0/+10
| | | | | | | | | | | | | | | | | | | | | The Purpose property is not useful in the inventory item. The field overflows to another line. The Purpose property under a power supply inventory item: PURPOSE xyz.openbmc_project.Software.Version.VersionPurpose.Other When we move to Redfish, this can be removed. An alternatives considered was only using the last part of the purpose property (e.g. Other). Still didn not find this userful to customers so just removed. https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Software/Version.interface.yaml#L14 Tested: Built and loaded on a Witherspoon. Don't see the property. Change-Id: Ie004c90f6a5e625cfa65ba39ab2be97e5e256705 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Update package versionGunnar Mills2019-09-232-2/+2
| | | | | | | | | | | | | | | | | | | | | | Have the package.json version follow the version used in OpenBMC. cat /etc/os-release ID="openbmc-phosphor" NAME="Phosphor OpenBMC (Phosphor OpenBMC Project Reference Distro)" VERSION="2.8.0-dev" VERSION_ID="2.8.0-dev-277-g08902b0-dirty" PRETTY_NAME="Phosphor OpenBMC (Phosphor OpenBMC Project Reference Distro) 2.8.0-dev" BUILD_ID="2.8.0-dev" OPENBMC_TARGET_MACHINE="witherspoon When a 2.8.0 branch is created this should be updated to "2.8.0" before the 2.8.0 tag in the 2.8.0 branch. After the 2.8.0 branch, when a 2.9.0-dev OpenBMC tag is created, this should be updated to "2.9.0-dev". Tested: npm install Change-Id: Ica774624efb49b194250b61488c7c68f4c74c1a8 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add expand/collapse functionality to table ComponentYoshie Muranaka2019-09-203-24/+106
| | | | | | | | | | | | This commit will add optional expand/collapse functionality to the shared table component. Expand/collapse is not implemented on any existing table but will be used on the redesigned event log table. Tested on Chrome, Safari, Firefox, Edge, IE Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ia7ecde7b5525c11c68ebdf9f609c8d690c312969
* Add sort functionality to table ComponentYoshie Muranaka2019-09-209-65/+198
| | | | | | | | | | | | | | | | | Added optional sort function to the shared table component. Table sort is not implemented on any existing table, but will be used in the redesigned Event Log table. - Changed table model attribute to two separate properties data and header to take advantage of $onChanges lifecycle hook - Update local user table and user role table to account for these updates Tested on Chrome, Safari, Firefox, Edge, IE Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I4fe68e78ae9d1228d7d9350538f61076036b1089
* Certificate management alert icons implementation and alignmentDixsie Wolmers2019-09-193-2/+17
| | | | | | | | | | | - Replaces background image icons with icon directive - Sizes and aligns icons in certificate table TODO: - Remove critical icon background image in separate commit Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I2e10bc3f3432331b6dd9354dbcd0e32480894ece
* Fix filter bar clear filter buttonDixsie Wolmers2019-09-114-4/+12
| | | | | | | | | | | | | | | | Makes filter button screen reader friendly and accessible. - Adds icon directive for close icon - Adds button type - Icon is aria-hidden and uses an aria-label attribute with the value set to clear filter Tested: - Filter inputs clear on close button click Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: Ifcbe603c2771156fe7a03359b144e0a0acd5e3f1
* Update SNMP page layoutDixsie Wolmers2019-09-112-150/+98
| | | | | | | | | | | | | | | This change applies global styles to improve page layout consistency and removes unnecessary custom styling. - Adds page, section, form field and actions styles - Removes unused styles Tested: - Passes DAP Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I96bb4732fdf160b2cc9eff0ad3ed9309ab1b9ea4
* Fix IE11 SNMP edit bugDixsie Wolmers2019-09-112-31/+8
| | | | | | | | | | | | | | - Removes edit button from form - Removes focus-within (not compatible with IE11 and Edge) and pointer-event Tested: - Input fields are editable and can be saved - DAP violations and page layout consistency will be addressed in separate commit Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I2ccd06802137c2969fec686abc5b5f8e785725b6
* Fix missing expiring/expired icons and warnning messages in certificate tablemiramurali232019-09-105-32/+41
| | | | | | | | | | | | | - Confirmed with backend developer that we should be checking certificate expiration date with bmc date/time set - Converted both certificate expiration date and bmc date/time to EPOCH time to fix the bug Tested: Go to Date and Time settings and change BMC time to be after or 30 days before a certificate expiration date. Then either a warning or expiration icon and message will be displayed next to the date and message on top of the table. To remove the expiration or warning date, upload a certificate that has an expiration date greater than 30 days after bmc time set. The icon and warning message should now disappear. Signed-off-by: Mira Murali <miramurali23@gmail.com> Change-Id: I9389fe3cce5a555945adf9c56180897a6be047bf
* Fix certificate management tabbingDixsie Wolmers2019-09-043-8/+32
| | | | | | | | | | | | - Adds focus to "choose file" button when replacing certificate - Adds input-file.scss to elements Tested: - Passes DAP - Tabs correctly in all browsers Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I48c61f4176bc3e3fe55425dafc79e8f2edb934b2
* Fix issue on IE cannot open SOL pageKuiying Wang2019-09-043-1/+17
| | | | | | | | | | | | | | | The root cause is that TextEncoder/TextDecoder does not support IE More detail at https://caniuse.com/#feat=textencoder One workable solution is to include text-encoder lib, as this patch did. Tested: IE visit BMC and navigate to "#/server-control/remote-console" SOL page is working well. Change-Id: I5019c626afcf67916252db4115af7616c7a9759b Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>
* Fix SoL open in new tab Safari bugYoshie Muranaka2019-09-041-10/+14
| | | | | | | | Wrapped WebSocket constructor in try/catch block to avoid compile errors in controller. Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I38fbc1e5898b0b70d8a16e3f16a244e04e18347e
* Update local user role tableYoshie Muranaka2019-09-041-2/+4
| | | | | | | | | | Currently the Operator and User roles are not able to change their own account's password. This commit will remove checkmarks from 'Update password for current user account' description for Operator and User until it is supported by Redfish. Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I93f1b37c116b74970790c9e4ad358db071ca8524
* Add 'wss:' to connect-src directive in CSPYoshie Muranaka2019-09-041-1/+1
| | | | | | | | | | This will fix Safari console errors for WebSocket connections. This fix is dependent on https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/24610 Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I54987124037c206773bbc4ee690f854bfae8fa19
* Fix IE11 replace certificate buttonDixsie Wolmers2019-08-291-13/+25
| | | | | | | | | | | | | | - Refactored button and icon markup on certificate management in order to trigger click in IE11 Tested: - Confirmed button functionality in Chrome, IE11, Firefox, Edge and Safari - Buttons and icons pass DAP - File upload inaccessible, unable to tab to "choose file" button Will correct in separate commit Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I6b0b9a56386a74b25a7a35d0cc03c9b0d32c3478
* Run npm-check updateGunnar Mills2019-08-292-443/+513
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ran "npm-check --update-all --save-exact". We were missing the following dependencies: Missing dependencies * regenerator-runtime * is-path-inside * pkg-dir https://github.com/openbmc/phosphor-webui/commit/dc25db0301ae6d4dabab6d98fb8447832a8c30e2 added regenerator-runtime, is-path-inside, and pkg-dir. This change adds them as a dependency. Running npm-check also updated a few packages. Since moving to webpack-dev-server 3.8, a random port will be used, need the following bmcweb change: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/24610 A random port breaks running the GUI locally (assuming XSS disabled) because of: https://github.com/openbmc/bmcweb/blob/43b761d0c8f5c4c39199093ee4bcd60698e77138/include/security_headers_middleware.hpp#L52 Tested: Built and loaded on a Witherspoon. No regressions observed. Ran the GUI locally with CSRF and XSS disabled with 24610. Change-Id: I57ff3edff979b24f7c0a7256d47fa47412041ad7 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Fix IE11 remove button on network settingsDixsie Wolmers2019-08-291-2/+2
| | | | | | | | | - Adds button type to buttons for IPv4 and DNS Tested: Verified remove button deletes IPv4 and DNS server Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I7827f49a910c14b9df0575f678d8f121258446f6
* Add user role privilege tableYoshie Muranaka2019-08-2711-10/+146
| | | | | | | | Created a directive to handle display of user privilege roles on the local user management page. Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I83caea33356012752c7a67301fa2a372f0c28620
* Update README to indicate how to disable CSRF from BMCWEBDerick Montague2019-08-271-10/+17
| | | | | | | | | If a user needs to test when running locally, there are two options that need to be turned on from BMC web. This update adds the CSRF option to the documentation. Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I2473a0654678397ab84b90c647aaf4c256247ed8
* Add tableActions componentYoshie Muranaka2019-08-278-32/+148
| | | | | | | | | Creating a separate table actions component to allow row action customizations like disabling certain actions and rendering different icons. Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I85e96045af27701f5ecc4af9bf824e248abccbf5
* Add local user manual unlockYoshie Muranaka2019-08-234-9/+90
| | | | | | | | Enables manual unlock from the GUI when a user is locked out due to failed login attempts above allowed threshold. Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I63e28a4d6feed9eb6d4d09c0431d31e7bd6924c2
* Enable CA certificate uploadYoshie Muranaka2019-08-225-14/+48
| | | | | | | | This patchset enables CA certificate type to be uploaded in the GUI. Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I52953933f6fd3dbd363c42b887996942b99b358e
* Create csr modalmiramurali232019-08-228-42/+729
| | | | | | | | | | | | | | | | | | The CSR Modal allows users to generate a CSR code. Once the user types in the necessary information to generate the CSR code, that modal will then render the code and the user will be able to either copy the code or download the code in a txt file. Tested: loaded onto Witherspoon and able to view on certificate management page. Click on generate csr and type in necessary (or any additional info), then click on generate CSR. The CSR code is then visible and is able to be copied or downloaded. In error state in which CSR code is unable to generate, the modal closes and an error toast message appears. FYI: Sometimes you have to reboot system in order for csr to successfully generate.y Signed-off-by: Mira Murali <miramurali23@gmail.com> Change-Id: I3cca09c494357496166164b5ee8ff99250ef981d
* Fix app header template rendering in SafariYoshie Muranaka2019-08-222-40/+47
| | | | | | | | | | Add 'connect-src' directive to Content Security Policy to allow WebSocket connection. Added additional error handling when Websocket connection refused. Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I83cfaa0b314099aea57ee7f2be75a0658462b2a9
* Add boot option override and TPM enable toggleDixsie Wolmers2019-08-219-178/+603
| | | | | | | | | | | | | | | | | - Adds ability to set a bootsource override to allowable target value - Adds ability to enable or disable TPM required policy - Replaces power operations confirm directive with bootstrap modal Tested: Confirmed override settings saved to redfish but unable to verify if settings are automatically set to disabled by petitboot after a one time boot. Passes DAP. Resolves openbmc/phosphor-webui#82 Resolves openbmc/phosphor-webui#90 Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: If0ffd6f9328939d70c7958ee11fb90bd20a1e685 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add password visibility toggleYoshie Muranaka2019-08-196-0/+78
| | | | | | | | | This commit will add a new password visibility toggle directive. The new directive was added to the local user management, user modal password input fields. Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I4e2baf53eec04aaff1bba26948779de6e447e3e7
* Update local user table to new designYoshie Muranaka2019-08-1319-400/+957
| | | | | | | | | | | | | | | | | | | | | | This commit will introduce a reusable data table component. By creating a reusable component, we can ensure tables in the GUI will look consistent and common table actions (sort, select row) are shared. - Created new components directory to store shared components - Add password-confirmation directive - Remove some error handling from API utils so it can be handled in the UI TODO: - Add show/hide toggle to password fields - Enhance table component with icons - Manual user unlock - Batch table actions - Role table Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I03c95874d2942a2450a5da2f1d2a8bb895aa1746
* Update overview page to use new UI patternsDerick Montague2019-08-1213-314/+329
| | | | | | | | | | | | | | | | | | | | - Use page, section, list-pair to establish consistent layout - Update header and overview page to use new caret icon - Reordered Server and BMC information to accomodate small screen views - Added chevron icons to create consistency between header and server overview page quick links - Changed edit hostname text to use the standard icon - Added OR operator to short circuit the server model, server serial number, and server manufacturer to display N/A if the information is not available Change-Id: I6619f5369ff290555142e85aa432e901c4f93d2d Signed-off-by: Derick Montague <derick.montague@ibm.com>
* Update toggle componentDixsie Wolmers2019-08-0919-211/+375
| | | | | | | | | | | | | | | | | - Adds text to indicate the current state of the toggle button to meet accessibility guidelines - Update size, color, and focus of toggle component to fix DAP violations - Add page, section, and list-pair layout patterns established on the power usage page to begin a pattern for consistent page layout - Add form__field and form__actions to help with form layout consistency. Tested: Verified toggle functions in the GUI and tested with screen reader. Passes DAP. Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: Iaa8646b1179cc307971065c455f4b9448095d1ec
* Extending certificate table with Issuer and Subject columns.Zbigniew Kurzynski2019-08-053-9/+43
| | | | | | | | | | | | | This commit introduce two new columns on certificate table. It should help user to differentiate multiple mTLS certificates. Date format was changed to 'medium' one to accommodate two new columns. Small corrections were made to action button paddings to make the icon better centered. Tested: GUI tests were done on Chromium v74.0.3729 browser. Desktop and mobile version. Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com> Change-Id: I660b74dd8b50f854ebbdad1890bbf99b3675f4cd
* Fix IE11 supportEd Tanous2019-08-055-20/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While we don't really officially support IE, it would be nice if _most_ non-complicated things actually worked. Given where transpilation is, and the fact that we already have webpack, this isn't actually that riddiculous of an idea. using babel was the intent with the original webpack stuff, but it turns out babel-loader wasn't pulling in the babelrc properly when it was in the root dir, so babel wasn't actually transpiling anything properly. Functionally, this commit does 3 things: 1. Fixes the published Accepts header, as the ajax call confuses IE if it doesn't have an encoding. 2. Includes core-js, to allow us to not really have to worry about javascript features that aren't present in a given browser. 4. Includes the config to support all browsers with > 0.25% market share, which should keep us compatible with most stuff. Requires a patch to bmcweb for the updated charset header, as we didn't handle that properly previously. https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/24063 Tested: Loaded the bmcweb patch. Started the webui in IE11 with the console open. Observed that webui launches and logs in properly with no errors on the console. Opened the webui in chrome to verify that nothing was broken. Appears working as it was before. Measured the pre-rootfs size before and after this patchset. It adds 36KB to the final package size. (404KB to 440KB). For supporting IE11 (and probably other browsers) I think this is well worth the cost. Signed-off-by: Ed Tanous <ed.tanous@intel.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Change-Id: Ie402e3296deede466a7a05726ebd7a18bead0b80
* Remove Associations property from inventory itemGunnar Mills2019-07-311-5/+26
| | | | | | | | | | | | | | | | | | | | | | | If the inventory item had a Assocations interface, it would have a Assocations property. This Assocations property showed on the inventory panel under the individual inventory item dropdown. There can be a lot of Associations, the chassis for example associates to a lot of sensors, and they are long, full D-Bus paths. Not very useful and can overwhelm the dropdown so remove the property. One day we might want something to associate an inventory item to an object (e.g. sensors). This would require design changes to accommodate this. Support both the old and new Associations interface. See https://github.com/openbmc/openbmc/issues/3584 Tested: Built an image and loaded on a Witherspoon. No longer see this property. Change-Id: Ib67e36c7536a42eb56e65b6dbe6fd8798976ee08 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Move the required npm version to 6.0.1Gunnar Mills2019-07-312-2/+2
| | | | | | | | | | | | | | | | | | | | | Since moved to a npm 6 generated package-lock.json, bump the required npm version to prevent churn in package-lock.json. This is a "advisory only", to enforce, the package.json would need "engineStrict" : true, http://www.marcusoft.net/2015/03/packagejson-and-engines-and-enginestrict.html Fine that users build with npm 5 as long as they don't check in their package-lock.json. After downgrading to 5.6 and running npm install bash-4.1$ git diff package-lock.json | wc -l 7913 Tested: "npm install && npm run build" with an npm 5.6, still builds. Change-Id: I77899eabc1f6a450a40e005dd43404b034c31768 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Use npm-check-updates and npm audit fixGunnar Mills2019-07-312-2211/+2373
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Upgraded npm to 6.10.2, which includes npm audit. Installed npm-check-updates and then ran: ncu -u; npm audit fix This is a npm 6 package-lock.json. Recommend using npm 6 from here out to avoid churn in the package-lock.json caused by npm 5 vs npm 6. Before: found 24 high severity vulnerabilities in 12251 scanned packages run `npm audit fix` to fix 24 of them. After: found 0 vulnerabilities in 12251 scanned packages npm 6 was released a year and half ago and has "security is built in". npm 6/5.10 moved package-lock.json from exact versions to loosly versions. tilde and caret are now present in the package-lock.json The previous commits helps a little by "specific version in package.json guarantees the version only a the top level commit" Even though package-lock.json has tilde and carets (scary!), the package-lock.json still lock sub-dependencies according to npm. https://github.com/npm/npm/issues/20434#issuecomment-395637874 OpenBMC uses nodejs_10.15.3 which has npm 6.4.1. https://github.com/openbmc/openbmc/blob/master/meta-openembedded/meta-oe/recipes-devtools/nodejs/nodejs_10.15.3.bb https://nodejs.org/en/download/releases/ Also see: https://github.com/npm/npm/issues/20891 Resolves openbmc/phosphor-webui#91 Tested: Built image and loaded on Witherspoon Change-Id: I436be724ac4b27bb00a4b4c20077ddf981c43c9f Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove carets from package.jsonGunnar Mills2019-07-311-34/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | caret (^) backwards compatible new functionality old functionality deprecated, but operational large internal refactor bug fix Some of the packages were already missing carets. This better reflects our package management, we have a npm 5 package-lock.json that is intended to lock the repo down to a specific set of versions of packages to help our build reliability, and insulate us a little from the NPM stability issues. When the Web UI was still in its infancy, OpenBMC got burned from this. What NPM called "Compatible with version" introduced build failures overnight without a code change. Found in some package-lock.json documentation: "A specific version in package.json guarantees the version only at the top level." npm update, npm audit fix, npm-check-updates will still behave the same. This is helps a future commit that moves to a package-lock.json generated by npm 6. npm 6 changes package-lock.json from exact versions to loosly versions. tilde and caret will be added to the package-log.json. See: https://github.com/npm/npm/issues/20434 https://github.com/npm/npm/issues/20891 Tested: Build and loaded on a Witherspoon Change-Id: Ie28f5b903f71215285df07c650a58c11037efccd Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Change package name to phosphor-webuiGunnar Mills2019-07-312-2/+2
| | | | | | | | | Most other npm projects have the same package.json name as the repository. phosphor-webui makes more sense here a name. Tested: npm install && npm run build Change-Id: If0d8697bda5332ce3b4ae86bda620d37cb447de2 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* package.json add authorGunnar Mills2019-07-311-2/+6
| | | | | | | | Added OpenBMC developers as the author, along with an email and url. Tested: npm install Change-Id: I57eee00db1904d72c9791128a194be19761b01f4 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Improve package.json descriptionGunnar Mills2019-07-311-1/+1
| | | | | | | | Description was lacking. Took this description from the README. Tested: npm install Change-Id: Ie9664a6bc9f3d6418c3e6ee63053ec643cc733f1 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Update package.json licenseGunnar Mills2019-07-311-1/+7
| | | | | | | | | | package.json had the wrong license. Use the Apache 2.0 license defined at https://github.com/openbmc/phosphor-webui/blob/master/LICENSE Tested: npm install Change-Id: I82e94b5261fa159bb8066101199c539725b0f782 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Update icons to fix sizing and overflow issuesYoshie Muranaka2019-07-293-3/+8
| | | | | | | | | | | | Re-exported icon-control.svg and icon-replace.svg to resolve issues around sizing and overflow. These new icons will allow us to remove CSS 'hacks' in place to prevent unexpected focus state overflows and allow icon resizing by changing the width on the icon class name. Small scss updates were included to account for this fix. Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I07bbe5bb0c82ee653f2342089c0c1373a51cc168
* Refactor power operationsYoshie Muranaka2019-07-294-177/+154
| | | | | | | | | | | | | | | | | | Refactored power operations to use checkHostStatus function that checks host_status property provided by dataService, instead of polling for host/chassis status. Added property to check when a power operation is in progress. This property will show/hide the in progress message and make other operations unavailable until the operation completes. We were previously checking whether the server_state property was set to 'Unreachable', which enables the Power on button in the middle of a reboot, since the server_state changes to 'Off' during reboot. - Removed unused $timeout service Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I234749a9a875c7370b52bd23ed74d6e9617cf5e2
* npm updateGunnar Mills2019-07-262-1165/+1035
| | | | | | | | | | | | | | | Have a security vulnerability around lodash. This partially addresses. See https://github.com/lodash/lodash/pull/4336 for more information. Opened to address the remaining vulnerability: https://github.com/openbmc/phosphor-webui/issues/91 Tested: Built image and loaded on a Witherspoon. Change-Id: I071c916058bc6ce7dd2032bf1af5b5c8e6545dec Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add 403 $location redirect to http interceptor serviceYoshie Muranaka2019-07-244-2/+28
| | | | | | | | | | | | This is a temporary solution to redirect any 403 responses to a dedicated 403 'Unauthorized' page. This could occur on inital navigation to a page or while attempting an operation. Once permission role mapping is defined, the code should be updated to handle 403 responses in context of user attempted actions. Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ia207f2bcdd87fb20888fe6a1588d0ccd310e484c
OpenPOWER on IntegriCloud