| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
| |
The menu item is called "Server LED".
The title is called "Server LED".
The route is server-control/server-led.
Tested: Verified server LED still works.
Change-Id: I1c70cfb6cd36868a191aa51363437dcdcc6d9a6b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WebUI has a main menu with 5 options: Server overview,
Server health, Server control, Server Configuration, Users.
These 5 main menu items each have a directory in /app/,
although the directory names differ slightly.
These 5 main menu items are also modules whose content includes
their sub-menu items (again names differ slightly).
E.g. "Firmware" and "Network settings" are sub-menu items of the
main menu item "Server configuration" which is located in the
app/configuration dir and part of the app.configuration module.
The Server LED sub menu item did not follow this pattern and was
under the wrong directory and in the wrong module. Moved it.
In a future commit I renamed it from unit-id.
Tested: Verified server LED still works.
Change-Id: I02e3a7995cf8ccc5b487c345866651d984c8d70c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
| |
Change-Id: I2dcd3625cf72c774d84399e35d3c7be19f744d5c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
If given 2 network interfaces: eth0 and eth0_60 (a VLAN interface),
and eth0_60 is selected a "cancel" of the form would result in eth0
being selected. Fixed this by moving getNetworkInfo() to a function
and calling it on a cancel. Also, call this new function after a
successful network set (a temporary fix).
Tested: The above case keeps eth0_60 selected.
Change-Id: I136ca1030cbbb053ca3b96241197c56488204dfd
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two scroll bars are displayed on the right hand side of the SoL console
menu as the element exceeds the screen size. Fix removes the unwanted
scroll bar
Resolves openbmc/openbmc#3243
Tested: Running webui locally and verified that extra scroll bar is not
showing at the Serial over LAN (SoL) console menu
Change-Id: I25537f8007b81f698d396ef03d6c381e61806bd6
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All the constants are defined here:
https://github.com/openbmc/phosphor-webui/blob/master/app/common/services/constants.js
Constants are injected as part of app.common.services.
This environment-constants.js or environment-constants.json could
be repurposed to configure features but going with something else,
https://gerrit.openbmc-project.xyz/#/c/11311/.
Tested: Quick manual regression test on the pages.
Change-Id: I59ba4f47fe8a927cb5f68a2657dfea9c61cd5f28
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The firmware controllers are in app/configuration/controllers/
The firmware styles are in app/configuration/styles/
This app/firmware dir is unused.
Tested: Quick manual regression test on firmware page and other
pages.
Change-Id: I9cd4d3b1368f8d5637de782e4315be583dd48883
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The filter search did not work for the event type (e.g.
"xyz.openbmc_project.Software.Version.Error.ManifestFileFailure")
Added the event type to the search terms.
Resolves openbmc/phosphor-webui#5
Tested: See example.xyz.openbmc_project.Example.Elog.AutoTestSimple
events on typing "auto" or "test".
Change-Id: I47361a4fee0285c5e09f63599bcdacbd51a7f3cd
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This uses websocket mechanism to retrieve the server power state and
update the same.
Resolves openbmc/openbmc#3102
Tested: Running GUI locally and verified the following scenarios:
- Power on operation from GUI and host command line
- Power off operation from host command line
- Warm reboot operation from GUI
- Cold reboot operation from GUI
- Immediate shutdown operation from GUI
- Orderly shutdown operation from GUI
In all of the above scenarios state change is notified to GUI at right time.
Change-Id: I1c97ae10419078dfe16a1d097082580c29827fb7
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding a package lock is intended to lock the repo down to a specific
set of versions of packages to help our build reliability, and insulate
us a little from the NPM stability issues.
See link for more details on what a package-lock file does:
https://docs.npmjs.com/files/package-lock.json
Change-Id: I8d9753db141b7bd8f72d943f31eb36d28921a317
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Added a button which allows the user to add new DNS Servers.
After pressing the button a new empty field appears.
Resolves openbmc/openbmc#3089
Tested: Added several new DNS Servers on a Witherspoon.
Change-Id: Ic6a6d2b798ad177b0e9aeb64ba3e4993af442305
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Nameservers" is called "DNS Servers" on the GUI. Update the
property if it has changed when the user hits Save settings
and confirms.
Had difficulties getting the DNS input fields to update the
interface.Nameservers array. The
"ng-blur="interface.Nameservers[$index] = dns" solution is from:
https://stackoverflow.com/questions/13714884/difficulty-with-ng-model-ng-repeat-and-inputs
Tested: Changed some DNS Servers on a Witherspoon.
Change-Id: Ib9c4be044d0725ac50e57e2733c3dc2ef8e29053
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added parameter validation for the IPV4 properties: IP Address,
Gateway, and Netmask prefix length.
This is important since we delete the IPV4 interface before adding
the new one (i.e. if the add is unsuccessful we are down an IPV4
interface). This validation helps to prevent some of the
unsuccessful adds.
Took the logic from the network manager valid parameter checks:
https://github.com/openbmc/phosphor-networkd/blob/master/util.cpp#L217
Moved "Netmask Prefix Length" to a "number" to do this. It should
have been a number.
Tested: A variety of good and bad values.
Change-Id: Idf4486489097bc426164b9543ea8c05eb54a2bf8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since an IPV4 interface (e.g. IP address, gateway, or netmask) edit
is a delete then an add and the GUI can't calculate the interface
id (e.g. 5c083707) beforehand and it is not returned by the REST
call, reload the page after an edit, which makes another REST call.
Do this for all network changes, instead of just IPV4 interface
edits due to the possibility of a set network failing even
though it returned success, openbmc/openbmc#1641.
This REST call also updates dataService and old_interface
which is used to know which data has changed if the user
continues to edit network settings.
The issue this is solving is the GUI deletes the old IPV4
interface (5c083707), creates a new one (4d9b1add), then
let's say the user modifies the IPV4 interface again without
a refresh, the GUI doesn't know what old IPV4 interface to
delete (i.e. the GUI doesn't know to delete 4d9b1add).
Choose 4 seconds to give the network manager time to set
the network.
Tested: Did the above scenario.
Change-Id: I36cb438b12eb6540dc74f235f8f134df67e60389
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
VLAN interfaces look like:
/xyz/openbmc_project/network/eth0_60
Modified the regexes to pick up VLAN interfaces and VLAN IPV4
interfaces.
To create a VLAN interface from the command line:
busctl call xyz.openbmc_project.Network \
/xyz/openbmc_project/network \
xyz.openbmc_project.Network.VLAN.Create VLAN su "eth0" 60
Tested: Set the Netmask, IP Address, and Gateway on a Witherspoon
VLAN IPV4 interface.
Change-Id: If5f3c042cc8b75e8d0e6f27d921c4347c5216bd2
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unexpected error is seen from the web gui due to the connection
loss during below known scenarios:
1. Initiating Reboot BMC from web gui
2. Restart of the nginx service
3. Trying to login to the web gui after a long idle time
Fix avoids unexpected error display from web gui.
Resolves openbmc/openbmc#3211
Tested: Running GUI locally and verified that unexpected error is not
coming when BMC reboots
Change-Id: I93974c53ab4fb414b938229d39fdf872b45a3e2c
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The error logs were ordered "81, 80, 8, 79 ..."
sortAscending was causing this, remove it and switch "+Id" to "-Id"
which is the correct way to do descending ordering.
http://www.tutorialspark.com/AngularJS/AngularJS_Filter_orderBy.php
Resolves openbmc/openbmc#3233
Tested: Server Overview page and event log page both show correct
order now.
Change-Id: Ie1aee542cec8a6157c538838037ce82fc2525e46
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Added a loading spinner that appears when set network settings are
confirmed. This fits with the other pages such as firmware update.
Tested: See the spinner when Save settings are confirmed.
Change-Id: Iec321e036ad7a81d960109397b3a60ffdf256062
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set the DHCP enabled field when the user selects "Save settings"
and accepts the popup. Added a TODO for issue #3154, Rest server
should return a proper JSON bool.
Resolves openbmc/openbmc#3165
Tested: Set "Obtain an IP address automatically using DHCP"
on a Witherspoon.
Change-Id: I45c817e3ddd8bf9c4f582460b1f9230e38548ff8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a gateway, netmask, or IP address of an IPV4 interface changes on
the page, when the user hits "Save changes" and confirms the popup,
delete the old IPV4 interface and create a new one with the new
values. After talking with Ratan, deleting then adding is the
the correct way to change IPV4 interfaces.
More information can be found in the network README up for review:
https://gerrit.openbmc-project.xyz/#/c/6872/
Tested: Changed IPV4 interface properties on a Witherspoon.
Also tested a Witherspoon in DHCP mode then moved over to a static
IP.
Change-Id: Idc0026aa01533ea327b53efc57e21147c4b68967
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Before setting the Mac Address, Hostname, or DefaultGateway,
check to see if those settings changed.
Change-Id: Ifc735b61734ced13e2554651d74dc44d761f3432
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Set the Hostname field when the user selects "Save settings"
and accepts the popup. Before Hostname was readonly.
Tested: Set the Hostname on a Witherspoon
Change-Id: I9de840ee9d52ec4a9ae1fd69d4ea27f62b0baf17
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Set the DefaultGateway field when the user selects "Save settings"
and accepts the popup. Moved to q.all() with a promise array.
Later commits will add to this array and do a check to make sure
the field changed before setting the value.
Tested: Set the DefaultGateway on a Witherspoon
Change-Id: Ica6abe14169f00bc3195f34a08db61ddbc09fa92
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the Event ID and Description event log properties
are present, display the error log title as <ID>: <Desc>
and move the Message property down into the box with the
other additional data fields.
If they aren't present, or not filled in (which in the case of
the event ID is a value of 'None'), leave the title as it
currently is, which is the Message property.
Tested: Verify UI fields when the event ID is valid, when
it's still in the event data but not valid, and when it isn't
in the event data at all.
Resolves openbmc/openbmc#3056
Change-Id: I455fc257b7d3713aceee2975d5240fb226cfa87e
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Restrict the number of high priority event logs to the 5 newest on
the server overview page. All the event logs can still be viewed on
the event log page. The server overview page should just show a
summary and not show all the high priority event logs, which could
number as high as 200.
Resolves openbmc/openbmc#3160
Tested: Running GUI locally and verified the number of high priority
events as 4, 5, 6 and 10.
Change-Id: I3fc22c8d13eb66a6b045d46180f1d195d74e67c3
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
| |
"Domain Name" is not as important of a network settings as
"Default Gateway". Remove it for now, later we will add fields for
the other network settings but getting the basic network settings
going for now. To setup the network, the user needs to configure
the Default Gateway, MAC Address, IP, Gateway, and netmask.
Change-Id: I27066dc188c3c30a01051b473a7ce10837d40fab
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Origin is not an important network setting, remove it, and
add "Netmask Prefix Length" which is an important network setting.
"Netmask Prefix Length" is called PrefixLength in the REST API.
To help clarify call this field "Netmask Prefix Length".
Change-Id: I59d99e98dabf8b53e74c81abb24d96b4026c2247
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
A modal appears when the user clicks "Save settings".
This modal warns the user of the dangers of changing
network settings.
Change-Id: I20e45e8a814d9c5e3d048a0ed2523025f55d0c4d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
When the Cancel button is hit on the network
settings page, reload the page, refreshing the
network settings.
Change-Id: Icc3d51e9b319bd70f7c7ab5b911b17728b5273b4
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Make a REST call to set the MAC address when the
"Save Settings" button is pressed.
Tested: Verified the MAC Address is set.
Change-Id: I39f6d4688842b3453fd219795d07f819ba4ba481
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
The phosphor-webui repo requires only certain directories
be verified with clang-format. This script utilizes the
override capabilities of the format-code.sh CI process
to handle this.
Change-Id: Icb759a7d94d2b007fa88261dacc39913b1076a0a
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
|
|
|
|
|
|
| |
Broke clang-format here:
https://gerrit.openbmc-project.xyz/#/c/10649/
Change-Id: I7cba713ae05d4ed1b1a4ffb013a0cd04fc0082a6
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Moved ignoreHttpError to the controller and set it to false after
testPassword.
Tested: Changed the password.
Change-Id: If860c073bcedcfba6a0743ea656c76ff06fd7de0
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Once merged, this repository will have CI enforce
the coding guidelines in the .clang-format file.
Change-Id: I96a05972665f9c67625c6850c3da25edc540be06
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Found this pointer on stackoverflow:
https://stackoverflow.com/a/31660434/5508494
End goal is to get the code formatted well enough that
clang format will run correctly against it.
Change-Id: I80053e78d253d8eee49233e42d55e5807ae8fdc8
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
|
|
|
|
|
|
| |
The Uglifying build error is 2871 not 2781.
https://github.com/openbmc/openbmc/issues/2871
Change-Id: I84dedc50c1cc2f45a04eacd1d83cd43bd2a7230f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Before this text was "edit server name". On the Network page we call
it "hostname" and the rest call is "Hostname". To be consistent
change to "edit hostname".
Change-Id: I0042f56cc77180dbb0cc51f7e955762f1eeafb4d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
After logging in the GUI was trying to load
multi-server-recent-controller.html.
Resolves openbmc/openbmc#3194
Change-Id: I109af0a9a94d0e0f3729d383473be43de91bb22f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
| |
High should not be capitalized.
This follows the other options in the box: "Turn on server LED",
"Edit network settings", and "Serial over LAN console"
Before: "View x High priority events"
After: "View x high priority events"
Change-Id: I11b8487881cff9da4e6de58871204125045bbea8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some internal testing found that when a server image is
uploaded and activated, the BMC reboots. This is because
the reboot variable defaults to true and it is not manipulated
in the server image activate code path, but it shares the
common activate image code path with the BMC which look at this
variable to determine if it should reboot the BMC.
Testing: Verified server image activate did not result in BMC
rebooting. Verified when option to reboot BMC after BMC update,
that BMC rebooted. Verified when option to not reboot BMC after
BMC update, that BMC did not reboot.
Resolves openbmc/openbmc#3188
Change-Id: Ib2f6b9cb6af27c11ad0f5c6fc33f161ac3ffa611
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes uglifyJs invalid assignment.
Before we were using the uglifyjs-webpack-plugin ^0.4.6 coming
from webpack.
Took from
https://github.com/webpack-contrib/uglifyjs-webpack-plugin/issues/187
Resolves openbmc/openbmc#3200
Change-Id: I29907caeeb49122cdddf6e6793070671a4525231
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal is to load as much data as possible on the
'Server overview' page. In original code, multiple promises are
executed in parallel using $q.all() to get data for the page.
When any of the promises fails, the remaining promises are
aborted. The fix is to write a method to resolve the promise
returned from each of the APIUtils calls, which would set the scope
variables, and pass the promise returned by it to $q.all instead.
Resolves openbmc/openbmc#3151
Change-Id: I361c80ddd2665dbe43f8a635eda42ef2b5c0788c
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renamed the BMC Host/BMC IP Address field:
"BMC Host or BMC IP Address".
Like Password and Username, this is displayed as all caps.
We got feedback that "Host" could mean a lot of things
and should specify this is the BMC.
Closes openbmc/openbmc#3147
Change-Id: If8b4e7b8a8bf912631fb39cc271ee87ce38c470d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
No reason to manage a version number separately from the overall
project. Remove the version and rename the element.
Based on feedback on https://gerrit.openbmc-project.xyz/#/c/10364/.
Change-Id: I055445db8bdda36dc408c057132e6e69b8935a6b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The apiInterceptor code was blindly overriding the http
timeout. This caused issues for functions like code update
image uploads which can require more then the default 20
seconds.
During the course of investigating this defect, it was questioned
why the interceptor code was needed at all since the default
was set in the httpsRequest base. Some web searching found
https://stackoverflow.com/questions/15015416/how-to-set-a-global-http-timeout-in-angularjs
which discusses why this does not work.
Testing: Verified requested timeout used during image upload
and default used otherwise.
Resolves openbmc/openbmc#3182
Change-Id: I9b58a328cf7ef7d224b3c4704d9d40edcc2b4d80
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
A failed image is an image that was unsuccess during activation.
The firmware code allows these images to be activated so should the
GUI.
Resolves openbmc/openbmc#3144
Tested: Verified I see an "Activate" button on a "Failed" image.
Change-Id: I3a5623d186dafd7656a045ba28e6bd636ee39420
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reversed the event log order to show the newest event first
Resolves openbmc/openbmc#3161
Tested: Running GUI locally and verified the order in both Server
overview page and in Server health -> Event log page
Change-Id: I1f1265332bb426d3f2a13932cfd5445740c3f49b
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Testing: Verified edit button correctly updates hostname on BMC and
it is correctly refreshed in the web interface.
Resolves openbmc/openbmc#3104
Change-Id: I28eb6366bde7c01b84d2fab54317aaf69ec2dba8
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
| |
The user needs the ability to set the hostname
in a few different spots.
Change-Id: Ia70e7c773d7ff951a505f3297d8eaf1b3d14fa73
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
|
|
|
|
|
|
|
| |
This reverts commit 7a3928da6aecfa20d6676150d978bca8eba62ab5.
Commits coming on top of this to add the required function in.
Change-Id: I5fe903f33de66577a807a391227dabaea0ddd69d
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|