summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Add comment for keyCode 13Gunnar Mills2018-09-121-0/+2
| | | | | | | keyCode 13 is the 'Enter' button. Change-Id: I49d6fc00b8e009835b93ed1f62f7f22be083216e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Login: Remove unused APIUtilsGunnar Mills2018-09-121-2/+2
| | | | | | | Tested: Able to login Change-Id: I50e459b5b3f35e731649377665449123d4934709 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Login: Remove unused routeParamsGunnar Mills2018-09-121-2/+2
| | | | | | Tested: Able to login Change-Id: Id87900c160781edf4cb473d32f7d7fa3112c6dd7 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove vendors.jsbeccabroek2018-09-114-18/+2
| | | | | | | | | | | hterm was removed in https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-webui/+/12603/ and vendors.js is no longer needed. No longer need to exclude from gulp-options or from sonar as this directory no longer exists. Change-Id: Ib3e781174192d43b5e1dcf5d7390223d0261051c Signed-off-by: beccabroek <beccabroek@gmail.com>
* Remove htermbeccabroek2018-09-115-23693/+1
| | | | | | | | hterm is no longer necessary in the webpack with transition to xterm. Change-Id: I057f7222929a2c040ba60620d8f576956caa8e3d Signed-off-by: beccabroek <beccabroek@gmail.com>
* Switch to xtermbeccabroek2018-09-117-43/+47
| | | | | | | | | | | | | | | | | Switch to xterm from hterm in the GUI, as it supports more encoding styles. Was seeing errors in console thrown by hterm during boot. Also resolves the issue of text wrapping observed in the below issue. Resolves openbmc/openbmc#3262 Tested: Errors are no longer thrown during boot related to encoding. xterm displaying console messages and delivering messages. Change-Id: I9f39c3616d7ff2c1045ff1ad29f603c65784ab30 Signed-off-by: beccabroek <beccabroek@gmail.com>
* move phosphor webui into 2018 styleEd Tanous2018-09-115-13212/+5224
| | | | | | | | | | | | | | | | | | | | | This commit moves us to the latest versions of all the packages we use. For the bitbake build to succeed, it requires the patchset here to be merged. Details on why are available on that commit. https://gerrit.openbmc-project.xyz/#/c/openbmc/openbmc/+/12561/2//COMMIT_MSG@10 This upgrade of webpack is done to decrease our size on flash, and to increase the load time of the webui. In my basic testing, this patchset decreases the webui load time (to the login page) by about 40% and significnatly reduces the load on the bmc. This is because the entire page is loaded in a single request. This should also save some runtime memory on the BMC as well, as the webui route is now greatly decreased. Basic testing shows that we have gone from 1188KB of pre-squashfs flash used to down to 456KB. Change-Id: I5992f2808978ee0e6b00196b030f7b122cac20d9 Signed-off-by: Ed Tanous <ed.tanous@intel.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Move to default headersGunnar Mills2018-09-112-172/+13
| | | | | | | | | | | | | | | | | | | | Set the $httpProvider.defaults.headers. Overwrite the default on upload image. For more information see: https://docs.angularjs.org/api/ng/service/$http#setting-http-headers Removed "Content-Type" on GET request. There is no "Content-Type" on a GET request. Content-Type is only used with POST, PUT, and PATCH requests. See: https://en.wikipedia.org/wiki/List_of_HTTP_header_fields Tested: Manual regression test of Web UI. Performed tasks such as firmware image upload, booting the server, and deleting event logs. Change-Id: I9217ba3eab40d40a331322d0848bdc5c5ca93767 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* SOL console in new window buttonbeccabroek2018-09-104-4/+13
| | | | | | | | | | | | | Created button to open SOL console in new window. Resolves openbmc/openbmc#3153 Tested: Verified that button brings up new window and that SOL console functions in new window. Change-Id: Idf8ff314e9a14cba0820823afd1ce60e4b3bbc4f Signed-off-by: beccabroek <beccabroek@gmail.com>
* Create SOL console directivebeccabroek2018-09-108-116/+74
| | | | | | | | | | | | Created serial-console directive in order to avoid duplicate code between remote-console-controller and remote-console-window-controller. Tested: Verified that SOL console functions as expected after refactor Change-Id: I8cfc8e78cc2325c813e5bef608886859df6b3ab8 Signed-off-by: beccabroek <beccabroek@gmail.com>
* 'Critical' Server Health on 'High' Priority logsGunnar Mills2018-09-103-36/+11
| | | | | | | | | | | | | | Set the Server health, located in the header, to Critical when a 'High' Priority log is present. Before to determine what the Server health was the SEVERITY_TO_HEALTH_MAP was used. This followed the SEVERITY_TO_PRIORITY_MAP most of the time. Removed code and made this simpler. Checked with the design team and this way was the original intent. Resolves openbmc/phosphor-webui#16 Change-Id: I2b3dab87cf1c31e9ef156c8e4f3a1592ed49403e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused dataService sensorDataGunnar Mills2018-09-102-2/+0
| | | | | | | dataService.sensorData was set but never used. Change-Id: I0fffd578c1c4391fec3bc3354e09dfb00db5d03e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove remote_window_activeGunnar Mills2018-09-101-9/+0
| | | | | | | | remote_window_active is no longer used. Remove in: https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-webui/+/12344/ Change-Id: I9629e64daa3dee9907a0a872fa1743fb4438f7ae Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused dataService.loading_messageGunnar Mills2018-09-101-1/+0
| | | | | Change-Id: Ic335a812537fc935264108bb7f9f93a05134c3b2 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Fix '$scope.filteredLogs is undefined'Gunnar Mills2018-09-101-0/+1
| | | | | | | | | | | | | | | When loading the "Event log" page '$scope.filteredLogs is undefined' is logged in the console. https://github.com/openbmc/phosphor-webui/commit/1ca1d7e10ed0ef47206bb89f6dcc5778b1239519 moved the watch on the all logs checkbox to $scope.filteredLogs. Add $scope.filteredLogs to the top of the file so it is not undefined on page load. Tested: No longer see the console message. Change-Id: Ifa49b416db1a692fc16b3325cef26f59189855a8 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Create new SNMP Settings pageGunnar Mills2018-09-108-3/+90
| | | | | | | | | | | | Created new page to display SNMP Managers. Display the SNMP Manager's IP and port. https://github.com/openbmc/phosphor-snmp/blob/master/docs/snmp-configuration.md Future commits will allow the user to add and delete SNMP managers. Change-Id: Ia5d633c11728a580c06b25c412e8673925cdc597 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Have loader wait for Last Power OperationGunnar Mills2018-09-101-11/+16
| | | | | | | | The loader (blue spinning half circle) should wait for the call to get the Last Power Operation Time. Change-Id: I105a5742244fb417cd3ab609e2c14771c28792cb Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add Host TimeGunnar Mills2018-09-052-1/+8
| | | | | | | | | | | If the Time Owner is 'BMC', 'Host', or 'Both' a single time field is present with a title of "BMC and Host Time". If the Time Owner is 'Split', meaning the BMC and Host have separate times, 2 time fields are present "BMC Time" and "Host Time". Tested: Set Time Owner to "BMC" and Time Owner to "Split". Change-Id: I6399fa30e4489d4bd62250b639e66e60cf9c2426 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add Time Owner and Time ModeGunnar Mills2018-09-053-3/+36
| | | | | | | | | Added the Time Owner and the Time Mode Created a new function that enumerates /xyz/openbmc_project/time. Tested: See Time Mode and Time Owner Change-Id: I3d1788bdb87b99028000d13c868b4a0cbfbc3006 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Create "Date and time settings" pageGunnar Mills2018-09-054-8/+56
| | | | | | | | | | | | | | | | | There was a Date and time page in the GUI. Enhanced it to display the BMC time and added it to the menu so users could navigate to it. Future things planned for this page: Setting the time, time mode, and time owner. Adding a NTP server. More information can be found in the time manager README: https://github.com/openbmc/phosphor-time-manager/blob/master/README.md Tested: See the BMC time. Change-Id: Ia3ac2385cb45ec8009ed6df0899c3410fe18ef64 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove 1/0 boolean workaroundGunnar Mills2018-09-051-7/+0
| | | | | | | | | | | With https://github.com/openbmc/phosphor-rest-server/commit/6691e7ca4e2adf52bac1fc3a82ed35adfce4349c and https://github.com/openbmc/bmcweb/commit/b79d4eef01f5fd2a24bb8dd28792810aa718cdee merged, this is no longer needed. Change-Id: I73393cdb90b4a5dec2c402235059b5fe49e7ade0 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused sensors-controllerGunnar Mills2018-09-044-219/+0
| | | | | | | | | A 2nd sensors page was visible at server-health/sensors/:type. This page was not reachable from the menu and did not work. This page had several bugs flagged by sonar scanner. Change-Id: Ib444fb398e49d469ba0693ba46856e0a5ac961d1 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused inventory-controllerGunnar Mills2018-09-044-594/+0
| | | | | | | | | A 2nd inventory page was visible at server-health/inventory. This page had hardcoded data and was not reachable from the menu. This page had several bugs flagged by sonar scanner. Change-Id: I672ad5436c877fedb409810d0ed71c58a48d1997 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove hack for 1/0 booleansGunnar Mills2018-09-041-3/+2
| | | | | | | | | | | | With https://github.com/openbmc/phosphor-rest-server/commit/6691e7ca4e2adf52bac1fc3a82ed35adfce4349c and https://github.com/openbmc/bmcweb/commit/b79d4eef01f5fd2a24bb8dd28792810aa718cdee merged, this is no longer needed. This code removed here was breaking displaying the DHCP value. Change-Id: I465908190b1254238da8699a324a31a51771dace Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Move to clang-format-6.0Gunnar Mills2018-09-0438-72/+24
| | | | | | | The docker image moved from clang-format-5.0 to clang-format-6.0. Change-Id: I3c615d7df1f21569531b4dc2cb0bc4f425cb43f8 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Event log select all checkboxbeccabroek2018-08-302-2/+2
| | | | | | | | | | | | | | | | | Previously the select all checkbox selected all events, regardless of the filter applied. In addition, if all the events on a filtered page were selected, the checkbox was not checked. Resolves openbmc/openbmc#3373 Tested: select all checkbox selects only the events visible to the user. If all events are selected, 'select all' checkbox is checked. Change-Id: Ibd5d1942b5c1c745a544d680288fd10206c7bbc6 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Checkbox not selected with 0 log events selectedbeccabroek2018-08-291-1/+1
| | | | | | | | | | | | | When 0 events are displayed, the 'select all' checkbox should not be selected by default. Resolves openbmc/openbmc#2747 Tested: box is not checked in the case of 0 events displayed. Change-Id: I50a12175d29f433d9e2ba0d9c1ff4413ebc018f4 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Remove 2nd CopyWebpackPlugin varGunnar Mills2018-08-291-1/+0
| | | | | | | Found using sonar scanner. Change-Id: I7ca70f2d13a8adfeebfee2b727ffed7c118a89bc Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove double variable setGunnar Mills2018-08-281-2/+1
| | | | | | | | | "loading" was set twice in a row. Remove the 1st. Found using sonar scanner. Change-Id: I21b40f316b7227ea003daae7924b992c1a1ed77b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add config.json fileGunnar Mills2018-08-242-0/+4
| | | | | | | | | | | This config file will hold such data as page selection. E.g. "powerManagement":false would disable importing the power management page. This file would be overwrote in bbappends. Change-Id: I740503c61b28e97792a91823cb37c7ae549650a9 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Set the power capGunnar Mills2018-08-245-48/+195
| | | | | | | | | | | | | Created toggle button to enable power cap and a text field to set it. This form is similar to the set network form. Moved logic for displaying the power cap as disabled to the overview controller. Resolves openbmc/openbmc#3221 Tested: Set the power cap on a Witherspoon Change-Id: I62346fe3ed123b9df58d159cee2584937d46213c Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused chassisPowerOnGunnar Mills2018-08-241-27/+0
| | | | | | | chassisPowerOff was unused and called the host object. Change-Id: If4ac2051f4eac594ac98810b157255e3294bf89a Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add Power Usage PageGunnar Mills2018-08-2412-38/+104
| | | | | | | | | | | | | | | | | Created a new page, "Manage Power Usage". This page is under the "Server control" tab. This new page currently just displays the power consumption. Future commits will allow the user to set the power cap from this page. One day, things like power consumption trending data could also be on this page. There was a blank unused controller which was for similar things, removed it. Tested: See the page and the consumption data. Uploaded screenshots to openbmc/openbmc#3221 Change-Id: I9f97c58a086f34c1c1990c03d5e05b081619bd5c Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused get BMC functionsGunnar Mills2018-08-221-49/+0
| | | | | | | | getBMCEthernetInfo and getBMCInfo were unused. Change-Id: I625e71803fb6c6e49ff968ad58a0021684aa723a Tested: Manual GUI regression test on a Witherspoon. Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Turn uglification back onEd Tanous2018-08-202-6/+8
| | | | | | | | | | | | | | | Fixes github bug openbmc/openbmc#2871 Turn on uglification again. It turns out, we only had one issue preventing the UI from starting when running in uglified mode. This patchset fixes the issue, and reenables uglification. This patchset drops our gzip compressed payload size by about 50K (about 14%). While it doesn't seem like a lot now, it increases our ability to scale the javascript payloads going forward. Change-Id: I0744687203a9db0f4b26d1e1d2f4e3bdb4a52f78 Signed-off-by: Ed Tanous <ed.tanous@intel.com>
* Update READMEGunnar Mills2018-08-161-15/+22
| | | | | | | | Wrote a repo description and updated some wording and headers. Tested: Used an online markdown editor. Change-Id: I1b944fbdda4adc88f9469622507c4d95daa66bf1 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add Becca as a WebUI reviewerGunnar Mills2018-08-151-0/+1
| | | | | | | | Becca has been contributing to the Web UI and expressed interest in being a reviewer. Change-Id: I5f5c9838a3acbbbd0dd39917dac72bc72c73acce Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Have MAINTAINERS file match other reposGunnar Mills2018-08-151-2/+46
| | | | | | | | Copied another repos MAINTAINERS file. WebUI differed for some reason. Change-Id: I56c94818cd7664f78dedfc0b599b3ae7be6cd467 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Last power operationbeccabroek2018-08-113-6/+28
| | | | | | | | | | | | | | | Displays correct power operation time. In the case that there has not been a power operation, 'not available' is displayed. Resolves openbmc/openbmc#2957 Tested: The GUI displayed 'not available' when it received a 0 value and the correct date when an epoch was recieved. Signed-off-by: beccabroek <rebecca.shaw@ibm.com> Change-Id: I9573a1cdcd31ba4c02888bd46d195c91fdb916a7
* Focus on newly created DNS server fieldGunnar Mills2018-08-072-3/+23
| | | | | | | | | | | | | | | | | | | Got feedback from IBM's design team that to help usability after adding a DNS Server field, focus on the newly created DNS server field. Decided to go with a directive instead of putting this in a controller after reading: https://stackoverflow.com/questions/22292832/angular-ng-init-pass-element-to-scope, https://github.com/angular/angular.js/issues/9031, https://groups.google.com/forum/#!topic/angular/6uxWl8Z0DPw Having dom manipulation code in the controller is frowned upon. Tested: Verified the field is in focus (i.e. the cursor is in the textbox). Change-Id: Ia548361e7ac47363e05ea2963807bca0c5bf51e2 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Transparent favicon backgroundbeccabroek2018-07-271-0/+0
| | | | | | | | | Remove white background in OpenBmc favicon. Resolves openbmc/openbmc#3193 Change-Id: Ia879def1046ee07f49019c021ac1080b5ce09ca4 Signed-off-by: beccabroek <rebecca.shaw@ibm.com>
* Add Last Reboot Timebeccabroek2018-07-273-9/+23
| | | | | | | | | | | Added last reboot date and time to Reboot BMC Page. Resolves openbmc/openbmc#2956 Tested: Rebooted and verified the date and time were correct. Change-Id: I81cf46f0ad7f4e910cd6645de9830d2952091770 Signed-off-by: beccabroek <rebecca.shaw@ibm.com>
* Copy to clipboard button to include titlebeccabroek2018-07-272-1/+4
| | | | | | | | | | | | | On the Event Log page, copy button previously copied error only. Updates to also include title of event. Resolves openbmc/openbmc#3146 Tested: The copy button now copies the title in addition to the error to the clipboard. Change-Id: I9580a620046203cdcb2025d0ea1cf0030e0851cb Signed-off-by: beccabroek <rebecca.shaw@ibm.com>
* Fix change priority down arrow logicGunnar Mills2018-07-271-2/+2
| | | | | | | | | | | | | | If the Boot priority was an "Active" image then a "Functional" image. The down arrow would be grayed out on the "Active" image. It should not have been grayed out, i.e. the user should be able to lower the priority on an "Active" image if there is a functional image below it in the table. Resolves openbmc/openbmc#3228 Tested: Tested this case and uploaded an image of the result to 3228. Change-Id: I6033886354f76671a4d33c4d8a79097428311e93 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Fix firmware page not loadingGunnar Mills2018-07-241-3/+7
| | | | | | | | | | | | | | | Had an image without an "Activation" property. This image did not have an Activation interface. Added an if for the Activation property. Also moved the activationStatus var so it would be empty if the Activation property did not exist. Resolves openbmc/openbmc#3309 Tested: The page loads now with the image missing the Activation property. Change-Id: I252e1277c88ce0a8b59b4f7441b1032954cef3e0 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove diagnostics pageGunnar Mills2018-07-246-32/+0
| | | | | | | | This page was unused and unreachable from the menu. Cleaning up the code base. Change-Id: Icebccb111f0d775cc6bd2c95a5588f67a75af9cf Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove file pageGunnar Mills2018-07-246-31/+0
| | | | | | | | This page was unused and unreachable from the menu. Cleaning up the code base. Change-Id: Id2529d95768d3885448efebb6d24833ffe35c3b6 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove security pageGunnar Mills2018-07-246-32/+1
| | | | | | | | This page was unused and haven't heard of any plans to implement it. Cleaning up the code base. Change-Id: Ie4fadc57e42f9b1c8fbc7f4c848f001ff062210f Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Date validation on event log filteringbeccabroek2018-07-211-2/+2
| | | | | | | | | User can no longer select an invalid date range. Resolves openbmc/openbmc#3158 Change-Id: Ife8479b465786a617a1746fdbc5b6359f3c36e40 Signed-off-by: beccabroek <rebecca.shaw@ibm.com>
* Fixed spelling errorsRebecca Shaw2018-07-192-2/+2
| | | | | Change-Id: I4b668b6246508d3bedda75ca179da1615516bad4 Signed-off-by: Rebecca Shaw <rebecca.shaw@ibm.com>
OpenPOWER on IntegriCloud