summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* log-filter: remove tip for date formatAlexander Filippov2018-11-161-3/+3
| | | | | | | | | The date picker already has the tip for the date format, which one uses locale settings. This commit removes the tip from the label. Change-Id: Ib45b6c620dab2031cf0f36c5389111df7cb91ef5 Signed-off-by: Alexander Filippov <a.filippov@yadro.com>
* Present number of sensors availableIftekharul Islam2018-11-161-1/+1
| | | | | | | | | | - Following the same pattern as event logs where number count of items are visible all the time Resolves openbmc/phosphor-webui#29 Change-Id: I1c79c72f9afa98eb834a4504543ed88e3973f034 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Move to Bootstrap 4Gunnar Mills2018-11-1517-47/+47
| | | | | | | | | | | | | | | | | | | | | Bootstrap < 4.1.2 has the following CVE: https://nvd.nist.gov/vuln/detail/CVE-2018-14041 Removed bootstrap-theme.css due to "Replaced the separate optional theme with configurable options via SCSS variables (e.g., $enable-gradients: true)." Added "width: 100%" to a few places where width 100% was no longer getting inherited. Moved a few elements and adjusted styles to get the same look as before. See https://getbootstrap.com/docs/4.0/migration/ for more information. Tested: Manually on a Witherspoon. Change-Id: I0a72665ac1ca6eacd0b553a585b1fb15e14ae62c Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* redfish: fix json formatJames Feist2018-11-141-4/+9
| | | | | | | | | | | | Quotes were missing on Arrays, and some commas were in the wrong spot. Tested-by: Copied the output of the managers schema and ran it through python json formatter and it started to pass. Change-Id: Ica6b35b0076654fae6204a99380c05dec1ac401b Signed-off-by: James Feist <james.feist@linux.intel.com>
* Server Health: Check if logs are resolvedGunnar Mills2018-11-121-5/+5
| | | | | | | | | When determining the server health, check if the logs are resolved. A resolved log should not cause the server health to display "Warning" or "Critical". Change-Id: I9bd46150410719441876b03c129cdf2e280150d4 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Move more info iconbeccabroek2018-11-071-2/+4
| | | | | | | | | | | | Currently, the more info icon (...) is positioned too far from the server version on the firmware page. This places the icon 20 px to the right, so that it is clearly associated with the version. Resolves openbmc/phosphor-webui#23 Change-Id: I5d1dc6bf1446c9f10ee0181d9b9fa2eb3e53e498 Signed-off-by: beccabroek <beccabroek@gmail.com>
* app/index: Remove authorGunnar Mills2018-11-071-1/+0
| | | | | | | This is the only file with a "@author". Change-Id: Iaf95c79f387532750dea44cd5cb16154103ce498 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove GulpGunnar Mills2018-11-069-283/+1
| | | | | | | | | | | | Moved to webpack here: https://github.com/openbmc/phosphor-webui/commit/bbcf670a1c8c7463556eb006bc8f6bbfe29af3e4 Gulp is no longer used and would not work without some restructuring of the app. Tested: Built the app and scped onto a Witherspoon. Change-Id: Id2f5feff2608c33460dd4276a5293973dfe8e9c8 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display log events in user timebeccabroek2018-11-068-139/+169
| | | | | | | | | | | | | | | | | Allows user to display events in their timezone or in UTC. Previously allowed either ETC or UTC, but listed ETC as 'user timezone'. Updates date time page from GMT offset to UTC offset for overall consistency. Also updates overview page to list critical events in user timezone Resolves openbmc/phosphor-webui#36 Tested: changed timezone settings locally and validated that correct timezone and UTC offset was presented in the UI. Change-Id: I89ca5045eeb789527aa07f5b1baebaa3fbd6b1fa Signed-off-by: beccabroek <beccabroek@gmail.com>
* SNMP: Use lowerCamelCase for varsGunnar Mills2018-11-022-11/+11
| | | | | | | Following https://google.github.io/styleguide/jsguide.html. Change-Id: Ib7704018622571cf1701d3a525dc01297bed7243 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Only update SNMP fields if changedGunnar Mills2018-11-022-8/+13
| | | | | | | | | Use ng-change to determine if the SNMP fields, Address and Port, have changed and should be updated. Tested: Only see the rest calls when the fields have changed. Change-Id: I324c9c422a8b6dfb8816925167953e16099f8044 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Update package-lock.jsonGunnar Mills2018-11-021-9/+540
| | | | | | | | | Use https, instead of http for a few packages. Use bootstrap 3 instead of 4. Generated using npm install. Tested: Manual regression testing on a Witherspoon. Change-Id: Icf729b4a782aabbeec2206d73f727c4586e81c36 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* API Utils: Remove date-time headersGunnar Mills2018-11-021-24/+0
| | | | | | | | These are not needed due to: https://github.com/openbmc/phosphor-webui/commit/dd9d4c32992568d0b634df10a0eeaf7fcd06d3dd Change-Id: Ic58569c774bc2524089e74fb108fb764df89c4e7 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Package.json: Bump npm and nodejsGunnar Mills2018-10-311-2/+2
| | | | | | | | | | | | | | | | | | The npm and node versions listed in package.json were too old to compile. Updated them to match the versions in the README. If using an older version then these, the webui will still try to compile but will display a warning message like: ╭─────────────────────────────────────╮ │ │ │ Update available 5.6.0 → 6.4.1 │ │ Run npm i -g npm to update │ │ │ ╰─────────────────────────────────────╯ Change-Id: If7165f80c9344f3bcab92b1399c52925676515bb Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Consistent date time formatbeccabroek2018-10-292-2/+2
| | | | | | | | | | | | | Format on event log page and overview page of date and time should match the format of 'data last refreshed' with the exception of the timezone being listed with the event log. Resolves openbmc/phosphor-webui#21 Change-Id: I21d43e45f45d2f9eebc7c08f4345201bef354a06 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Remove SNMP ManagersGunnar Mills2018-10-292-5/+18
| | | | | | | | | | Allow the user to remove SNMP Managers. If the SNMP Manager being removed exists in the backend, make a call to remove it. Tested: Removed SNMP Managers on a Witherspoon Change-Id: Ib392cda30754adfaa58f6301592c2d666ff2c29e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add and modify SNMP ManagersGunnar Mills2018-10-294-12/+199
| | | | | | | | This allows the user to add and edit SNMP managers. Tested: Added SNMP managers on a Witherspoon. Change-Id: Iab8d6463b03de75928e4989135172d93ab0f28a3 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Clarify versions required for npm and nodejsAndrew Geissler2018-10-231-2/+8
| | | | | | | | | | The default versions that come with Ubuntu 16.04 and 18.04 are not high enough. Clarify level requirements and provide some pointers on how to update. Change-Id: I05032d44086951a21c44ab28836e96f31dd4a918 Signed-off-by: Andrew Geissler <geissonator@yahoo.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove multi-server controllerGunnar Mills2018-10-2311-677/+2
| | | | | | | | | | | | | | | | | Removed all pages associated with the multi-server feature. Before, this page was visible at /multi-server/overview. This page is not used and there is a lot of work to get multi-server working. There was also a lot of hardcoded values in the multi-server controllers. This code could still be used in the future by looking at the git history or checking out an earlier tag. Removing these controllers saves us a few KBs in the image. Tested: Manual regression testing on a Witherspoon. Change-Id: Ic2f727a80404291338a66cde4857cf1f4ad228b2 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Change navigation hover background colorRyan Arnell2018-10-222-4/+10
| | | | | | | | | -Changing the hover color to be white as hover and selected states need to look different. Change-Id: I65a201b127408a698e50563f2b555fd5c55935dd Signed-off-by: Ryan Arnell <iffy.ryan@ibm.com>
* Clarify where npm install must be runAndrew Geissler2018-10-221-0/+2
| | | | | | | | | | There was some confusion on this at the hackathon. People were running this prior to cloning the git repository which then resulted in issues with the run-script server command later. Change-Id: I7f13f7dd90899d0b64ccd83f19a9a2eb0e10cf1e Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
* Date-time: Use lowerCamelCase for varsGunnar Mills2018-10-192-41/+42
| | | | | | | | Following https://google.github.io/styleguide/jsguide.html. Also, added a comment to clarify a variable. Change-Id: I27dd8c0af6187ccd3f8093b88ebe2674fd42747b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Capitalize "Edit" hostnameGunnar Mills2018-10-181-1/+1
| | | | | | | | | To match other links, capitalize the first letter of "Edit". Resolves openbmc/phosphor-webui#25 Change-Id: I6da98358c68223b7a70e5500f3a83a6cd57a5f32 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Include bmcweb XSS disable in READMEAndrew Geissler2018-10-151-0/+5
| | | | | | | | | If bmcweb is hosting the webui then XSS needs to be disabled to connect a local webui instance to the BMC. Change-Id: I538f657eed65939021120baa71c63728f2e6a828 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
* Order hardware componentsbeccabroek2018-10-111-7/+44
| | | | | | | | | | | | Lists hardware components by depth, and within those with the same depth, orders the components alphanumerically. Places child components beneath their parent compenent. Resolves openbmc/openbmc#3386 Change-Id: I4b0e63164fbc9bd24078b9e36c6dc7788be06744 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Functional version font colorbeccabroek2018-10-111-1/+1
| | | | | | | | | | Blue makes the text appear to be a link. Updated text color to dark grey. Resolves openbmc/phosphor-webui#22 Change-Id: I5950473844d2edfeaf5ede80b46984bc152d7483 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Update code styling for network pagebeccabroek2018-10-092-51/+48
| | | | | | | | | | Now that the following style guide is being used: https://google.github.io/styleguide/jsguide.html#naming Some of the variable naming in this class needs to be updated. Change-Id: I6ca7a0ea7255ab2314bb4b5fc2d89cff9006039a Signed-off-by: beccabroek <beccabroek@gmail.com>
* login-controller.html: Fix indentsGunnar Mills2018-10-091-21/+21
| | | | | Change-Id: Ie6867b29eb7e785ad48c918d605ccfff955e3102 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add and Update IPV4 addressbeccabroek2018-10-092-18/+55
| | | | | | | | | | | | | | | | | | This allows user to add IPV4 addresses and updates logic for editing IPV4 addresses. Resolves openbmc/phosphor-webui#12 Tested: Added, removed and modified IPV4 addresses, called API to verify that addresses had been correctly modified. Verified that if address had not been modified, no change was made for that address. Change-Id: I3dd25565f4f610dce2023e23348f6eb8d00add3d Signed-off-by: beccabroek <beccabroek@gmail.com>
* Fix setting image priorityGunnar Mills2018-10-091-2/+2
| | | | | | | | | | | | | | | | | | | | | | Let's say there are 2 images, A and B. A has a priority of 0 and B has a priority of 50. Lowest priority is the image used to boot from and appears at the top of the image tables (A in this case). If the user wanted image B to be the image with the lowest priority, they would have to hit the up arrow 50 times in the old logic. Move to setting the priority based on the image above, for the up arrow, or below, for the down arrow. If 2 images have the same priority, the image whose priority is being updated wins and the image who already has that priority gets bumped up 1, this is why when moving an image down we set to the below image's priority +1, but don't need this -1 when moving an image up in the table. Tested: Can still change the priority. Change-Id: If87e1d863ab909c276247072cc45e40b67cf686b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add "(Primary)" to first NTP ServerGunnar Mills2018-10-091-1/+1
| | | | | | | | | The IBM design team though adding "(Primary)" to the first NTP Server made it more clear that this NTP server is the first NTP server the time manager talks to. Change-Id: Iaadbc4958621146db072541668a7a6f0a8834de4 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Set Host Time from correct fieldsGunnar Mills2018-10-091-9/+16
| | | | | | | | | | | | | In all cases except when the time owner is "Split", Host and BMC time share fields. Make sure to set the Host time from the correct fields, which is these shared fields in all cases except when time owner is "Split". Resolves openbmc/phosphor-webui#20 Tested: Able to set the Host and BMC time Change-Id: I69985fd2de08fe71c62fd57dd1fa872f7f33ba09 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Set the Host Time if "Split" and "NTP"Gunnar Mills2018-10-091-2/+6
| | | | | | | | | | | From: https://github.com/openbmc/phosphor-time-manager Mode Owner Set BMC Time Set Host Time NTP SPLIT Fail to set OK Resolves openbmc/phosphor-webui#19 Change-Id: I72f5617581533a2bb17d415b45bdf7ec6372ecab Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* User Management: Do not autocomplete passwordsGunnar Mills2018-10-091-3/+3
| | | | | | | | | Security scanners list autocomplete on as a medium priority issue. The concern being someone could use it to compromise a BMC with a password saved on a compromised computer. Change-Id: Ibefa75af19046e056955406c1e4d31331d82f19f Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove IPV4 addressesbeccabroek2018-10-043-20/+55
| | | | | | | | Tested: Able to remove existing IPV4 addresses. Change-Id: I772bee6ad6b68bc0a69351f3e5386acc659241ef Signed-off-by: beccabroek <beccabroek@gmail.com>
* Date-time: Change h2 titleGunnar Mills2018-10-031-1/+1
| | | | | | | This title is more clear. Change-Id: I8e4f89b1d2d91fe0745dedfcea1af124033d5cca Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* log-search-control.html: Fix indentingGunnar Mills2018-09-271-6/+6
| | | | | Change-Id: I11074705553aba7b1b8a8ebc1a97b472a5fb1de5 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Revert "Remove unused dataService"Gunnar Mills2018-09-261-4/+6
| | | | | | | | | This reverts commit e13275b837ed38b7e8553316accedb51b32ef37b. dataService is used in powerOn(), warmReboot() and isServerOff(). Change-Id: I8635ac88f93b6354ea7d352f92c9a7f4281e21a5 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused dataServiceGunnar Mills2018-09-261-6/+4
| | | | | Change-Id: I99e0d16a56908beb1397bb4c15390c72c3b2f3f5 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove tabs from HTML filesGunnar Mills2018-09-2521-1243/+1243
| | | | | | | | | | | | From https://google.github.io/styleguide/htmlcssguide.html "Indentation Indent by 2 spaces at a time. Don't use tabs or mix tabs and spaces for indentation." Tested: Manual regression testing on a Witherspoon. Change-Id: Ief7137dabc869b73b73f9947337fbb0abb5ca497 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Resizing SOL consolebeccabroek2018-09-251-2/+4
| | | | | | | | | | | | Makes no changes to how the console currently looks, but makes overriding the css height of the terminal easier. Resolves openbmc/phosphor-webui#8 Change-Id: Ie198462eaf42578c848fe9285c3065ef6e26b1b2 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Do not autocomplete username and passwordGunnar Mills2018-09-251-2/+2
| | | | | | | | | | | Security scanners list autocomplete on as a medium priority issue. The concern being someone could use it to compromise a bmc with a password saved on a compromised computer. Resolves openbmc/phosphor-webui#18 Change-Id: Ie6936d84a0b94a81781a077d1542a6ce1d413d6d Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add Redfish into the web-uiJames Feist2018-09-245-1/+392
| | | | | | | | | | | | | | Currently only GET is supported, but to add PATCH in the future for redfish, support should be moved from being hosted directly by bmcweb into the webui. Tested-by: Navigated to http://localhost:8080/#/redfish/v1/ with bmc attached and was able to view all of redfish. Also tested on platform. Change-Id: I1dc3936b6b48835a1f69698fcb4fd6fcdb6d91ac Signed-off-by: James Feist <james.feist@linux.intel.com>
* Make wording consistentGunnar Mills2018-09-201-1/+1
| | | | | | | | | | | The IBM design team identified this wording as inconsistent. In the tables below the "running" image is called "Functional", here it is called "In-memory". Change to "Functional" to match the table below. Change-Id: I4b1a45f3cbcc578b0f807577dd2c3a9c54714a02 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Activate image and reboot hostbeccabroek2018-09-194-81/+186
| | | | | | | | | | | | | | | | | | | When activating a host image, gives the option to: a) Activate image without booting b) Activate image and boot host. If server is in 'off' status the option is to power on. If the server is in 'unavailable', 'on', or 'error' status the option is to reboot Also updated polling during boot and reboot to use /subscribe API. Resolves openbmc/openbmc#3323 Tested: The GUI displays the options and boots / reboots appropriately based on server status. Change-Id: I62c19e094ecc7112263c26844fcd30b2bf3c2b84 Signed-off-by: beccabroek <rebecca.shaw@ibm.com>
* Button to remove NTP serverGunnar Mills2018-09-193-6/+22
| | | | | Change-Id: I58a3a894c192fafb551e07302b107bcd776e4901 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Button to remove DNS serverbeccabroek2018-09-183-7/+23
| | | | | | | | | | | | | Added button to remove DNS server from Nameservers list. Resolves openbmc/phosphor-webui#11 Tested: Added and was able to remove DNS servers from list. Page updated appropriately. Change-Id: I64e9d2499465f1aa5f9f34c831961578abf32b2b Signed-off-by: beccabroek <beccabroek@gmail.com>
* MAINTAINERS: Update my email and IRCGunnar Mills2018-09-171-1/+1
| | | | | | | Updated to correct IRC username and preferred email address. Change-Id: I2a959f3e33c4f9c0364043e2eac21c2f93dcc561 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Set time fieldsGunnar Mills2018-09-138-71/+378
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Squashed 5 commits to set the date-time fields: time mode, time owner, BMC time, and host time. Also included is a commit to display the timezone. Set time mode Moved the selection of NTP vs Manual (time mode) to a radio button. Added code to allow the user set it. Tested: Set the time mode on a Witherspoon. Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Set time owner The time owner is now a dropdown and is set when "Save settings" is pressed. Tested: Set the time owner on a Witherspoon Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Set the BMC and Host time The BMC and host have the same time except when time mode is split. Only need to set BMC or host time when time mode is not split. When time mode is split, set both. Use time owner to determine which to set. https://github.com/openbmc/phosphor-time-manager#time-settings Have date and time as two separate inputs, this is due to Firefox not supporting "datetime-local". The "date" and "time" input fields are more widely supported. https://caniuse.com/#feat=input-datetime The idea for 2 separate input fields came from: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local Must set the time mode and time owner before setting the time, this is due to permissions of who can set the time. Tested: Set the date and time on a Witherspoon. Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Add NTP Servers The user can now view and set NTP Servers. Moved setFocusOnNewInput to a common directive since it is used on the NTP Servers and the DNS Servers on the network page. Even though NTPServers is a network interface specific path (e.g. /xyz/openbmc_project/network/eth0/attr/NTPServers) it acts like a global setting, openbmc/phosphor-time-manager#4. Using eth0 for setting and getting the NTP Servers until NTPServers is moved to a non-network interface specific path. In Redfish, NTPServers is a non-network interface specific. Tested: Set NTP Servers on a Witherspoon. Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Add timezone Added the timezone for the host and bmc date time. The timezone looks like "GMT-0400 (EDT)" or "GMT-0500 (CDT)". I got this from https://stackoverflow.com/questions/1091372/getting-the-clients-timezone-in-javascript and choose this formatting over something like "America/Chicago". Tested: See the timezone on a Witherspoon Change-Id: I59a4449d63f73a6ed14cb934f3d8577e46620c4e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Highlight correct fields on errorsGunnar Mills2018-09-122-4/+4
| | | | | | | | | | | | | | | | If the error is 'Invalid username or password', the 'Username' and 'Password' fields now becomes red. On any other error (e.g. Server unreachable) the 'BMC Host or BMC IP Address' field is red. Before the 'BMC Host or BMC IP Address' and 'Username' were red on all errors. Resolves openbmc/phosphor-webui#17 Tested: See correct fields highlighted. Change-Id: I55514cfb428170cd125ec01eb4c7184fbadd3894 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
OpenPOWER on IntegriCloud