phosphor-webui/app/server-health/controllers/inventory-overview-controller.html, branch master

Fix icon-warning syntax error

2019-10-09T14:54:41+00:00

There were a few instances of the icon-warning icon that didn't include the file extenstion needed to when adding the file attribute property in the icon directive. Signed-off-by: Derick Montague Change-Id: Ib25c28c72285fa214f75258b0b09790d52bb6cc1

Clean up icons

2019-10-02T14:02:24+00:00

Clean up duplicate svg icons from assets directory. Created a statusIcon component to dynamically render status icons instead of using background-image in scss files. - Moved/removed on, off, critical, warning svg icons from assets directory - Updated background-image status icons to use or directive Signed-off-by: Yoshie Muranaka Change-Id: Ic0f06d78b0861d6f60d40b2dcc0b80fd6dad2a88

Fix filter bar clear filter button

2019-09-11T21:03:50+00:00

Makes filter button screen reader friendly and accessible. - Adds icon directive for close icon - Adds button type - Icon is aria-hidden and uses an aria-label attribute with the value set to clear filter Tested: - Filter inputs clear on close button click Signed-off-by: Dixsie Wolmers Change-Id: Ifcbe603c2771156fe7a03359b144e0a0acd5e3f1

Consolidate button styles

2019-06-21T19:27:51+00:00

This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes. This patchset also implements a consistent strategy for including icon assets. Currently, svg icons are imported as CSS background images or inlined into the markup. Inlining an svg is preferred, especially when used with buttons or links so the colors can be easily changed for different states (hover, focus, disabled) without having to request variants. The icon provider allows us to inline svgs without cluttering the markup. Webpack config was adjusted to use svg-inline-loader when resolving svgs that are used by the icon provider directive. - All svgs were optimized to remove unncessary information. - Removed unused svg color variants - Moved icons used by icon provider to separate directory to avoid Webpack parsing the files twice - Small changes to navigation icons Signed-off-by: Yoshie Muranaka Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43

Resolve accessibility isssues

2019-04-09T04:40:05+00:00

- Remove unecessary aria-roles - Associate label elements with form elements - Remove extraneous markup on Network settings page - Update generic markup to use definition list when appropriate - Add aria-labels and aria-expanded to accordion triggers Tested: Accessibility issues tested in using Lighthouse in Chrome Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels set focus on the form elements. Visually tested of the Network Settings page in Chrome, Firefox, and Safari to verify layout changes. Resolves openbmc/phosphor-webui#76 Signed-off-by: Derick Montague Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a

Fix inventory dropdown

2019-02-26T22:22:46+00:00

Dropdown on hardware page was cutting off text. Changes styling so that table is in line and all information is displayed as expected. If information exceeds dropdown size, a scroll bar appears. Tested: Appears to be displaying correctly using Chrome, Firefox and Safari. Change-Id: Ib1531c59865a7d7bf4ea1ded7277702e9cd53b8b Signed-off-by: beccabroek

Clean up headers

2019-02-19T14:26:14+00:00

Updates headers to match style guide and makes them consistent throughout pages in the GUI. Removes instances where a header element existed and a different header style was being applied. For example,

Tested: Ran GUI locally and verified that headers look consistent and have the appropriate sizing while using Chrome, Firefox and Safari. Change-Id: I187136298ed2bfd36c40c2b80d5a4f20947cbe56 Signed-off-by: beccabroek

Remove tabs from HTML files

2018-09-25T21:11:35+00:00

From https://google.github.io/styleguide/htmlcssguide.html "Indentation Indent by 2 spaces at a time. Don't use tabs or mix tabs and spaces for indentation." Tested: Manual regression testing on a Witherspoon. Change-Id: Ief7137dabc869b73b73f9947337fbb0abb5ca497 Signed-off-by: Gunnar Mills

Display warning icons on non-functional subcomponents

2018-03-13T14:05:32+00:00

Warning icons are now displayed only in subcomponents that are present and non-functional. Only "present" subcomponents are displayed so only need to check for functional. An example of using this is cores of the cpu. Only display a warning on a present and non-functional core. Resolves openbmc/openbmc#2989 Tested: Only see a warning on a non-functional core. Change-Id: Ic22b7531de4dfcc445bfc5eae7dd23b0089f2cdf Signed-off-by: Gunnar Mills

Only display "present" subcomponents

2018-03-13T14:05:32+00:00

Only display "present" subcomponents of an inventory item. An example of this would be cores of the cpu. Only display present cores. Tested: See only present cores. Change-Id: Ib53d72d24e35f17a047baa15b1eaad0e099576a5 Signed-off-by: Gunnar Mills