phosphor-webui/app/login, branch master

Block forwarding to non-local url

2020-02-11T16:43:02+00:00

Currently we don't protect against forwarding to remote url, so things like: https:///#/login?next=http:%2F%2Fyahoo.com can be used to forward an unsuspecting user to a different url. This fixes that issue. Tested: Local redirects still work, above link does not Closes #109 Change-Id: I4d6c52880156802860f405af43037fb84235912f Signed-off-by: James Feist

Clean up color values

2019-07-09T21:37:46+00:00

This update will clean up slight color variations in the code base by creating and using Sass color variables instead of hex values. Available colors are defined in colors.scss. Any usage of CSS color properties should refer to the mapped color variables in colors.scss. - Removed tags.scss file since tag components no longer used Signed-off-by: Yoshie Muranaka Change-Id: I045030a158469e59d07a9fa8cd8aa9f125f0d383

Consolidate button styles

2019-06-21T19:27:51+00:00

This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes. This patchset also implements a consistent strategy for including icon assets. Currently, svg icons are imported as CSS background images or inlined into the markup. Inlining an svg is preferred, especially when used with buttons or links so the colors can be easily changed for different states (hover, focus, disabled) without having to request variants. The icon provider allows us to inline svgs without cluttering the markup. Webpack config was adjusted to use svg-inline-loader when resolving svgs that are used by the icon provider directive. - All svgs were optimized to remove unncessary information. - Removed unused svg color variants - Moved icons used by icon provider to separate directory to avoid Webpack parsing the files twice - Small changes to navigation icons Signed-off-by: Yoshie Muranaka Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43

Add .ng-leave and .ng-enter rulesets for page transition

2019-05-29T01:01:31+00:00

Adding ngAnimation dependency created added animation to pages during route or location changes. Added transitions to create an elegant transition. Tested: I navigated to every page including logging in and out in Chrome, Firefox and Safari to assure all browsers handle the transition consistently. Resolves openbmc/phosphor-webui#86 Signed-off-by: Derick Montague Change-Id: I14fa1bd790e80f977b7a0ccceccc3eb20ce33ae6

Fix login error message

2019-03-27T13:41:03+00:00

Respose for invalid credentials changed and login page was no longer displaying the correct error message to the user when invalid credentials were entered. Resolves openbmc/phosphor-webui#72 Tested: Logged in with incorrect credentials and saw the correct message. Also logged in with an unreachable host and saw that that message was displaying correctly. Change-Id: I65cc6d6a061986568aded09555c5f75bcd59fe56 Signed-off-by: beccabroek

Form validation on login page

2019-02-02T01:09:14+00:00

Using ngMessages, adds form validation to login page. Also creates a directive, hasError, to be used to validate form field by passing in a boolean. This is a proposed pattern to be used moving forward, as form validation is added to additional pages. Validation error messages are shown on $touched and on submit. Unreachable Server and Invalid username and password error messages remain until input is no longer $pristine after form submission. In addition, this removes unneeded and unused css styling Resolves openbmc/phosphor-webui#47 Change-Id: I7a067af67ac74d4cf2977d10f66445720ecae9eb Signed-off-by: beccabroek

Fix issue for responsive design: Login screen

2019-01-29T18:19:48+00:00

This push fixes the issue of the logo and input alignment in login screen on tablets portrait and landscape mode. They are centrally aligned in these views. Gets rid of the unwanted horizontal scrollbar in tablets. Change-Id: I31fd9caa881e0ffb6b1cd58701d911ee916dd419 Signed-off-by: Ryan Arnell

phosphor-webui: Allow after login redirects

2018-11-19T15:25:50+00:00

When redirecting a user to a login url, it is helpful to be able to point them to a url that after login, will forward to the requested page. This is accomplished by the use of a url param named "next" which specifies the URL that the user wants to be redirected to after login. If no next url is specified, the user is redirected to the overview page, like the vehavior before. Change-Id: Iff0da65632119a8f7ae3f35eb74147ca67563f30 Signed-off-by: Ed Tanous

login-controller.html: Fix indents

2018-10-09T02:19:34+00:00

Change-Id: Ie6867b29eb7e785ad48c918d605ccfff955e3102 Signed-off-by: Gunnar Mills

Do not autocomplete username and password

2018-09-25T15:37:44+00:00

Security scanners list autocomplete on as a medium priority issue. The concern being someone could use it to compromise a bmc with a password saved on a compromised computer. Resolves openbmc/phosphor-webui#18 Change-Id: Ie6936d84a0b94a81781a077d1542a6ce1d413d6d Signed-off-by: Gunnar Mills