phosphor-webui/app/login/controllers/login-controller.html, branch master

Consolidate button styles

2019-06-21T19:27:51+00:00

This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes. This patchset also implements a consistent strategy for including icon assets. Currently, svg icons are imported as CSS background images or inlined into the markup. Inlining an svg is preferred, especially when used with buttons or links so the colors can be easily changed for different states (hover, focus, disabled) without having to request variants. The icon provider allows us to inline svgs without cluttering the markup. Webpack config was adjusted to use svg-inline-loader when resolving svgs that are used by the icon provider directive. - All svgs were optimized to remove unncessary information. - Removed unused svg color variants - Moved icons used by icon provider to separate directory to avoid Webpack parsing the files twice - Small changes to navigation icons Signed-off-by: Yoshie Muranaka Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43

Form validation on login page

2019-02-02T01:09:14+00:00

Using ngMessages, adds form validation to login page. Also creates a directive, hasError, to be used to validate form field by passing in a boolean. This is a proposed pattern to be used moving forward, as form validation is added to additional pages. Validation error messages are shown on $touched and on submit. Unreachable Server and Invalid username and password error messages remain until input is no longer $pristine after form submission. In addition, this removes unneeded and unused css styling Resolves openbmc/phosphor-webui#47 Change-Id: I7a067af67ac74d4cf2977d10f66445720ecae9eb Signed-off-by: beccabroek

Fix issue for responsive design: Login screen

2019-01-29T18:19:48+00:00

This push fixes the issue of the logo and input alignment in login screen on tablets portrait and landscape mode. They are centrally aligned in these views. Gets rid of the unwanted horizontal scrollbar in tablets. Change-Id: I31fd9caa881e0ffb6b1cd58701d911ee916dd419 Signed-off-by: Ryan Arnell

login-controller.html: Fix indents

2018-10-09T02:19:34+00:00

Change-Id: Ie6867b29eb7e785ad48c918d605ccfff955e3102 Signed-off-by: Gunnar Mills

Do not autocomplete username and password

2018-09-25T15:37:44+00:00

Security scanners list autocomplete on as a medium priority issue. The concern being someone could use it to compromise a bmc with a password saved on a compromised computer. Resolves openbmc/phosphor-webui#18 Change-Id: Ie6936d84a0b94a81781a077d1542a6ce1d413d6d Signed-off-by: Gunnar Mills

Highlight correct fields on errors

2018-09-12T15:26:22+00:00

If the error is 'Invalid username or password', the 'Username' and 'Password' fields now becomes red. On any other error (e.g. Server unreachable) the 'BMC Host or BMC IP Address' field is red. Before the 'BMC Host or BMC IP Address' and 'Username' were red on all errors. Resolves openbmc/phosphor-webui#17 Tested: See correct fields highlighted. Change-Id: I55514cfb428170cd125ec01eb4c7184fbadd3894 Signed-off-by: Gunnar Mills

Rename BMC Host/IP field on login

2018-05-18T23:11:33+00:00

Renamed the BMC Host/BMC IP Address field: "BMC Host or BMC IP Address". Like Password and Username, this is displayed as all caps. We got feedback that "Host" could mean a lot of things and should specify this is the BMC. Closes openbmc/openbmc#3147 Change-Id: If8b4e7b8a8bf912631fb39cc271ee87ce38c470d Signed-off-by: Gunnar Mills

Move login error to common error style

2018-04-09T14:55:49+00:00

Created a generic error class, have the login error inherit it. Tested: Verified the login error looks the same. Change-Id: Ief373fa37ea655cfcb544861a4e540abbe65f77e Signed-off-by: Gunnar Mills

Show error message received from server side

2018-03-27T12:10:56+00:00

When an error occurs during authorization, display the error message received from server side instead hardcoded message. Partially resolves openbmc/openbmc#2974 Resolves openbmc/openbmc#3024 Tested: Enter invalid username or password and verify error message Change-Id: I91ca29d5a69e12e12ce490ce3206173de7d41f09 Signed-off-by: Alexander Filippov

Remove reference to IBM in phosphor-webui

2017-11-07T00:51:54+00:00

As phosphor webui is supposed to be the reference implementation, it should not reference IBM, nor have IBM copywritten logos contained within it. If these are neccesary for IBM platforms, they should be done in a bbappend in the bitbake layer, or in a way that doesn't put copywritten materials on BMCs that may not have permission to use and release it. I'm hoping to generate ddiscussion on how the best way to handle this from a build perspective would be, but for now, references should be to the OpenBmc project, not IBM to avoid copyright issues. Change-Id: I73efda399e967ca4446b8df403e94e14ab24aff8 Signed-off-by: Ed Tanous