phosphor-webui/app/configuration/controllers/network-controller.html, branch master

Fix icon-warning syntax error

2019-10-09T14:54:41+00:00

There were a few instances of the icon-warning icon that didn't include the file extenstion needed to when adding the file attribute property in the icon directive. Signed-off-by: Derick Montague Change-Id: Ib25c28c72285fa214f75258b0b09790d52bb6cc1

Clean up icons

2019-10-02T14:02:24+00:00

Clean up duplicate svg icons from assets directory. Created a statusIcon component to dynamically render status icons instead of using background-image in scss files. - Moved/removed on, off, critical, warning svg icons from assets directory - Updated background-image status icons to use or directive Signed-off-by: Yoshie Muranaka Change-Id: Ic0f06d78b0861d6f60d40b2dcc0b80fd6dad2a88

Fix IE11 remove button on network settings

2019-08-29T15:58:27+00:00

- Adds button type to buttons for IPv4 and DNS Tested: Verified remove button deletes IPv4 and DNS server Signed-off-by: Dixsie Wolmers Change-Id: I7827f49a910c14b9df0575f678d8f121258446f6

Consolidate button styles

2019-06-21T19:27:51+00:00

This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes. This patchset also implements a consistent strategy for including icon assets. Currently, svg icons are imported as CSS background images or inlined into the markup. Inlining an svg is preferred, especially when used with buttons or links so the colors can be easily changed for different states (hover, focus, disabled) without having to request variants. The icon provider allows us to inline svgs without cluttering the markup. Webpack config was adjusted to use svg-inline-loader when resolving svgs that are used by the icon provider directive. - All svgs were optimized to remove unncessary information. - Removed unused svg color variants - Moved icons used by icon provider to separate directory to avoid Webpack parsing the files twice - Small changes to navigation icons Signed-off-by: Yoshie Muranaka Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43

Resolve accessibility isssues

2019-04-09T04:40:05+00:00

- Remove unecessary aria-roles - Associate label elements with form elements - Remove extraneous markup on Network settings page - Update generic markup to use definition list when appropriate - Add aria-labels and aria-expanded to accordion triggers Tested: Accessibility issues tested in using Lighthouse in Chrome Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels set focus on the form elements. Visually tested of the Network Settings page in Chrome, Firefox, and Safari to verify layout changes. Resolves openbmc/phosphor-webui#76 Signed-off-by: Derick Montague Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a

Center modals and fix sizing

2019-03-26T13:38:17+00:00

Previously the modals were not centered on the screen and the size of the modal was set to 50% of the screen, leading to a lot of white space within modals with less content. This sizes the modal based on the amount of content within and centers the modal. Also adds the grey modal overlay to the 'confirm network settings' modal to be consistent with the other pages. Resolves openbmc/phosphor-webui#35 Tested: Viewed all modals currently in GUI (Firmware page, network page, and overview page) and modals were sized correctly and appeared with the modal overlay in the background. Change-Id: Ie35d179810d36b8bcbbf39dc1302e773387fa788 Signed-off-by: beccabroek

Clean up headers

2019-02-19T14:26:14+00:00

Updates headers to match style guide and makes them consistent throughout pages in the GUI. Removes instances where a header element existed and a different header style was being applied. For example,

Tested: Ran GUI locally and verified that headers look consistent and have the appropriate sizing while using Chrome, Firefox and Safari. Change-Id: I187136298ed2bfd36c40c2b80d5a4f20947cbe56 Signed-off-by: beccabroek

Add toast to Network Settings page

2019-01-23T19:53:15+00:00

Displays error message if any settings fail to save and success if all succeed on the Network Settings page. Change-Id: Ifddf1822ba59753a217d1ec257b8d0ca870cceed Signed-off-by: beccabroek

Update code styling for network page

2018-10-09T18:22:57+00:00

Now that the following style guide is being used: https://google.github.io/styleguide/jsguide.html#naming Some of the variable naming in this class needs to be updated. Change-Id: I6ca7a0ea7255ab2314bb4b5fc2d89cff9006039a Signed-off-by: beccabroek

Add and Update IPV4 address

2018-10-09T02:19:19+00:00

This allows user to add IPV4 addresses and updates logic for editing IPV4 addresses. Resolves openbmc/phosphor-webui#12 Tested: Added, removed and modified IPV4 addresses, called API to verify that addresses had been correctly modified. Verified that if address had not been modified, no change was made for that address. Change-Id: I3dd25565f4f610dce2023e23348f6eb8d00add3d Signed-off-by: beccabroek